Re: bell patches

2014-02-14 Thread Nicholas Marriott
I don't know why this wouldn't be the right thing to do, can't find a SF issue... maybe it was on the ML? This seems a slightly better change. Index: server-window.c === RCS file: /cvs/src/usr.bin/tmux/server-window.c,v retrieving r

Re: bell patches

2014-02-13 Thread Thomas Adam
On 12 February 2014 22:28, Filip Moc wrote: > Hi, > >> I'm not clear what this bit is supposed to fix, can you give an example? > > Problem is when visual-bell is off and bell-action is set to current > - tmux in this case behaves as if bell-action would be set to any. > Action and whether window

Re: bell patches

2014-02-13 Thread Filip Moc
Hi, > I'm not clear what this bit is supposed to fix, can you give an example? Problem is when visual-bell is off and bell-action is set to current - tmux in this case behaves as if bell-action would be set to any. Action and whether window is current must be checked before call of tty_bell(). O

Re: bell patches

2014-02-12 Thread Nicholas Marriott
Hi I think the winlink_find_by_window bits are fine except there are other places which also need to be changed. > + if ((c->session->curw->window != w) && (action != BELL_ANY)) > + continue; I'm not clear what this bit is supposed to fix, can you give an example?

Re: bell patches

2014-02-04 Thread Thomas Adam
On 3 February 2014 12:46, Filip Moc wrote: > It also makes some other changes - i don't think that use of > winlink_find_by_window(&s->windows, w) is necessary when there is > already wl, but please check whether i didn't miss anything. That's fine. > I also made bell_script.patch which allows u

bell patches

2014-02-04 Thread Filip Moc
Hi, i found out that tmux ignores current/any setting of bell-action when visual-bell is off so i made patch (bell_fix.patch). (checked on git://git.code.sf.net/p/tmux/tmux-code) It also makes some other changes - i don't think that use of winlink_find_by_window(&s->windows, w) is necessary when