Re: potential memory leak in window_copy_copy_selection

2014-02-15 Thread Nicholas Marriott
yes i thought of that and decided against it On Fri, Feb 14, 2014 at 05:02:04PM -0600, J Raynor wrote: > I suppose paste_replace could always handle the freeing of the memory. > This would preserve its fire and forget nature. > > See the attached patch. --

Re: potential memory leak in window_copy_copy_selection

2014-02-14 Thread J Raynor
I suppose paste_replace could always handle the freeing of the memory. This would preserve its fire and forget nature. See the attached patch. tmux-ml.patch Description: Binary data -- Android apps run on BlackBerry 10

Re: potential memory leak in window_copy_copy_selection

2014-02-14 Thread J Raynor
> Why not this instead? Also fix some other similar problems. I was hesitant to free the memory in window_copy_copy_buffer in case the caller wasn't done with it. But since all current callers are done with it, I guess it doesn't matter. Your patch looks good. --

Re: potential memory leak in window_copy_copy_selection

2014-02-14 Thread Nicholas Marriott
Why not this instead? Also fix some other similar problems. Index: cmd-load-buffer.c === RCS file: /cvs/src/usr.bin/tmux/cmd-load-buffer.c,v retrieving revision 1.25 diff -u -p -r1.25 cmd-load-buffer.c --- cmd-load-buffer.c 10 Oct 2