Re: patch adding -c flag to new-session

2013-10-01 Thread Nicholas Marriott
Applied with some minor tweaks, I don't mind the unreachable return because it'll be compiled away and it's better to leave it there for documentation/safety in case of future changes. Thanks On Wed, Aug 21, 2013 at 11:16:40PM -0500, J Raynor wrote: > This looks fine too, except it looks like the

Re: patch adding -c flag to new-session

2013-08-21 Thread J Raynor
This looks fine too, except it looks like the unreachable "return (base);" is still there. Also, the comment above cmd_default_path() mentions using the default-path option, but that's now taken care of elsewhere. So that might need an update.

Re: patch adding -c flag to new-session

2013-08-21 Thread Nicholas Marriott
Maybe this which includes your default-path change in a slightly different form and renames the functions to cmd_default_path and cmdq_default_path. diff --git a/cmd-new-session.c b/cmd-new-session.c index 4eebe63..80829f0 100644 --- a/cmd-new-session.c +++ b/cmd-new-session.c @@ -35,9 +35,10 @@ e

Re: patch adding -c flag to new-session

2013-08-21 Thread Nicholas Marriott
On Wed, Aug 21, 2013 at 04:26:41PM -0500, J Raynor wrote: > There are some conditions I don't know how to generate, so I couldn't > test those. But I tried testing what I could, and it appears that > this preserves the behavior of neww and split-window, and that the > prefixes for "new -c" match t

Re: patch adding -c flag to new-session

2013-08-21 Thread J Raynor
There are some conditions I don't know how to generate, so I couldn't test those. But I tried testing what I could, and it appears that this preserves the behavior of neww and split-window, and that the prefixes for "new -c" match the -c behavior for neww and split-window. Does cmd_default_path1

Re: patch adding -c flag to new-session

2013-08-19 Thread Nicholas Marriott
Hi On Mon, Aug 05, 2013 at 08:21:48PM -0500, J Raynor wrote: > I've attached a new patch that should support the same prefixes as neww. I don't like calling cmd_get_default_path from session.c. How about this instead? (Not tested much.) I'll probably rename cmd_default_path* as soon as I think o

Re: patch adding -c flag to new-session

2013-08-18 Thread Nicholas Marriott
s Marriott Cc: tmux-users@lists.sourceforge.net Subject: Re: patch adding -c flag to new-session I've attached a new patch that should support the same prefixes as neww. -- Get 100% visibility into Java

Re: patch adding -c flag to new-session

2013-08-05 Thread J Raynor
I've attached a new patch that should support the same prefixes as neww. new-c.patch Description: Binary data -- Get your SQL database under version control now! Version control is standard for application code, but datab

Re: patch adding -c flag to new-session

2013-07-30 Thread Nicholas Marriott
Thanks. Thomas sent something similar but I think we should try to do it in a way that supports as many of the same special prefixes as neww as we can sensibly do. This might mean breaking up the helper in cmd.c into two functions. Original message From: J Raynor Date: 30/07/

Re: patch adding -c flag to new-session

2013-07-30 Thread Thomas Adam
On 30 July 2013 07:39, J Raynor wrote: > The TODO list for tmux has this entry: > > * add -c for new-session like new-window > > > I've attached a patch that implements that. https://sourceforge.net/p/tmux/mailman/message/31133999/ -- Thomas Adam