Re: [patch] find-window -TCN (was: Re: find-window searching behavior)

2012-03-20 Thread Nicholas Marriott
Hi I just removed the comment entirely, I think it's clear enough what the code is doing. Cheers On Tue, Mar 20, 2012 at 12:07:30PM -0700, Jonathan Daugherty wrote: > > Applied with some fairly unimportant style changes, thanks. > > Thanks! I just realized that there is a stale comment in my

Re: [patch] find-window -TCN (was: Re: find-window searching behavior)

2012-03-20 Thread Jonathan Daugherty
> Applied with some fairly unimportant style changes, thanks. Thanks! I just realized that there is a stale comment in my patch which made it into yours: a comment mentions 'match_title' but that variable was from a previous version that didn't make it into my final patch. Whoops. -- Jonatha

Re: [patch] find-window -TCN (was: Re: find-window searching behavior)

2012-03-20 Thread Nicholas Marriott
Applied with some fairly unimportant style changes, thanks. On Tue, Mar 20, 2012 at 09:15:18AM -0700, Jonathan Daugherty wrote: > > But that's four diffs... just -T -N -C would be ok but if you do one > > -T flag I think we should have all three. > > Please see the attached patch, which adds -T

[patch] find-window -TCN (was: Re: find-window searching behavior)

2012-03-20 Thread Jonathan Daugherty
> But that's four diffs... just -T -N -C would be ok but if you do one > -T flag I think we should have all three. Please see the attached patch, which adds -T, -C, and -N options for find-window and defaults to -TCN as discussed. I've also updated tmux.1. -- Jonathan Daugherty Software Eng

Re: find-window searching behavior

2012-03-16 Thread Jonathan Daugherty
> You could use window ids (@1 etc) if you want to go to a specific window > but of course that means you need to look them up first. Yeah, it's true, I'd like to avoid that. > I'd be happy with improvements to find-window but I think if we are > adding flags then we should have flags for all the

Re: find-window searching behavior

2012-03-16 Thread Nicholas Marriott
You could use window ids (@1 etc) if you want to go to a specific window but of course that means you need to look them up first. I'd be happy with improvements to find-window but I think if we are adding flags then we should have flags for all the possibilities, so -T for title, -N for name, -C f