Re: Window size

2014-01-31 Thread Nicholas Marriott
Applied, thanks. On Thu, Jan 30, 2014 at 05:38:28PM -0600, J Raynor wrote: > > Please don't use expressions with side-effects like m++ in function > > arguments, it's too easy to miss. > > Ok. I've attached a new patch that meets your request. > diff --git a/input.c b/input.c > index 259fad1..

Re: Window size

2014-01-30 Thread J Raynor
> Please don't use expressions with side-effects like m++ in function > arguments, it's too easy to miss. Ok. I've attached a new patch that meets your request. diff --git a/input.c b/input.c index 259fad1..23804b9 100644 --- a/input.c +++ b/input.c @@ -74,6 +74,7 @@ void input_csi_dispatch_rm(s

Re: Window size

2014-01-30 Thread Nicholas Marriott
Please don't use expressions with side-effects like m++ in function arguments, it's too easy to miss. On Wed, Jan 29, 2014 at 05:53:19PM -0600, J Raynor wrote: > > Take a look at this instead which a) uses a function like CSI, SM etc b) > > don't increment m inside function arguments. > > This w

Re: Window size

2014-01-29 Thread J Raynor
> Take a look at this instead which a) uses a function like CSI, SM etc b) > don't increment m inside function arguments. This works fine. However, I noticed that just incrementing m may cause it to skip over bad input. For example, a winop of 3 is supposed to take 2 arguments. If someone enter

Re: Window size

2014-01-29 Thread Nicholas Marriott
Take a look at this instead which a) uses a function like CSI, SM etc b) don't increment m inside function arguments. Index: input.c === RCS file: /cvs/src/usr.bin/tmux/input.c,v retrieving revision 1.64 diff -u -p -r1.64 input.c ---

Re: Window size

2014-01-29 Thread J Raynor
> How about WINOPS instead of WMN? This matches xterm src and seems a bit > more readable. Otherwise looks good. Sure. I've attached an updated patch with WINOPS instead of WMN. diff --git a/input.c b/input.c index 259fad1..bc4f912 100644 --- a/input.c +++ b/input.c @@ -154,6 +154,7 @@ enum input

Re: Window size

2014-01-29 Thread Nicholas Marriott
How about WINOPS instead of WMN? This matches xterm src and seems a bit more readable. Otherwise looks good. On Wed, Jan 29, 2014 at 01:29:53AM -0600, J Raynor wrote: > Sorry, after I submitted the patch I realized it was incorrect. > Certain options take arguments and my patch didn't account for

Re: Window size

2014-01-28 Thread J Raynor
Sorry, after I submitted the patch I realized it was incorrect. Certain options take arguments and my patch didn't account for that. I've attached a new patch which does. On Wed, Jan 29, 2014 at 12:28 AM, J Raynor wrote: > I've attached a patch which implements this. The 't' group of escape >

Re: Window size

2014-01-28 Thread J Raynor
I've attached a patch which implements this. The 't' group of escape sequences are described as being for "window manipulation" in some documentation, so that's why I picked WMN in the INPUT_CSI_WMN identifier. diff --git a/input.c b/input.c index 259fad1..e27ecbb 100644 --- a/input.c +++ b/input.

Re: Window size

2014-01-28 Thread Nicholas Marriott
Hi. It isn't supported at the moment, needs to be added in input.c Original message From: yohann dupont Date: 22/01/2014 13:39 (GMT+00:00) To: tmux-users@lists.sourceforge.net Subject: Window size Hi, The \033[18t control sequence did'nt return any result. Here a PHP sc

Re: window size change.

2013-01-16 Thread Nicholas Marriott
You need to detach other clients using C-b D, or detach them properly before disconnecting laptop. On Wed, Jan 16, 2013 at 03:21:40PM +0530, Sinbad wrote: >when i disconnect my laptop from the docking station >while tmux is running and connect it back, i see that >the screen size has