Re: Implementing some extra features

2013-02-23 Thread Thiago Padilha
Ok thanks for the info. I just got home now and will go sleep, and when I wake up you will probably be gone already, so I will see what I can do and next sunday you give feedback. Until then On Sat, Feb 23, 2013 at 7:45 PM, Nicholas Marriott < nicholas.marri...@gmail.com> wrote: > I've committe

Re: Implementing some extra features

2013-02-23 Thread Nicholas Marriott
I've committed my cmdq changes after all so you will need to do it that way at some point, the differences aren't substantial - basically what I outlined below, save and reference the cmdq rather than the client and wake it up with cmdq_free/cmdq_continue. If you look at run-shell it should be clea

Re: Implementing some extra features

2013-02-23 Thread Nicholas Marriott
On Sat, Feb 23, 2013 at 06:24:56PM -0300, Thiago Padilha wrote: >I have started to read the source code and began to wonder if those >features are possible to implement. >I'm assuming that a overview(very high level) of what happens when a tmux >command is executed is: Yes this is

Re: Implementing some extra features

2013-02-23 Thread Thiago Padilha
I have started to read the source code and began to wonder if those features are possible to implement. I'm assuming that a overview(very high level) of what happens when a tmux command is executed is: 1- user types 'tmux somecmd' in a shell running inside a tmux session, which opens 'tmux progra

Re: Implementing some extra features

2013-02-22 Thread Nicholas Marriott
No don't need any other changes thanks On Fri, Feb 22, 2013 at 07:14:30PM -0300, Thiago Padilha wrote: > Ok by me, I was just following the existing code :) > > So the patch is good to merge? Need me to do any other modifications? > > On Fri, Feb 22, 2013 at 6:50 PM, Nicholas Marriott > wrote

Re: Implementing some extra features

2013-02-22 Thread Thiago Padilha
Ok by me, I was just following the existing code :) So the patch is good to merge? Need me to do any other modifications? On Fri, Feb 22, 2013 at 6:50 PM, Nicholas Marriott wrote: > On Fri, Feb 22, 2013 at 06:34:14PM -0300, Thiago Padilha wrote: >> I had forgotten to update the man pages to ref

Re: Implementing some extra features

2013-02-22 Thread Nicholas Marriott
On Fri, Feb 22, 2013 at 06:34:14PM -0300, Thiago Padilha wrote: > I had forgotten to update the man pages to reflect the nem flag, this > patch contains the complete thing. I think this is a bit more pithy, don't see a need to info() the old value. diff --git a/cmd-set-option.c b/cmd-set-option.

Re: Implementing some extra features

2013-02-22 Thread Thiago Padilha
I had forgotten to update the man pages to reflect the nem flag, this patch contains the complete thing. set-option-2.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster wit

Re: Implementing some extra features

2013-02-22 Thread Nicholas Marriott
Hi Your mailer has mangled the patch by wrapping lines, can you resend as an attachment? Also you will need to add this new flag to the manpage. On Fri, Feb 22, 2013 at 02:19:56PM -0300, Thiago Padilha wrote: > Added '-o' to set-option, which will only take effect when the value > isn't set yet

Re: Implementing some extra features

2013-02-22 Thread Thiago Padilha
Added '-o' to set-option, which will only take effect when the value isn't set yet. So far only added for user options. I assumed the server runs a single thread, is that right? If not some kind of synchronization is needed on the region that tests if the value is set. On Fri, Feb 22, 2013 at 1

Re: Implementing some extra features

2013-02-22 Thread Nicholas Marriott
On Fri, Feb 22, 2013 at 11:53:21AM -0300, Thiago Padilha wrote: > On Fri, Feb 22, 2013 at 10:30 AM, Nicholas Marriott > wrote: > > For the first of these you can already use the tmux global environment > > or use user options which were added very recently you only need to > > worry about the seco

Re: Implementing some extra features

2013-02-22 Thread Thiago Padilha
On Fri, Feb 22, 2013 at 10:30 AM, Nicholas Marriott wrote: > For the first of these you can already use the tmux global environment > or use user options which were added very recently you only need to > worry about the second. > Nice to know about user options. Even so, I think it still misses th

Re: Implementing some extra features

2013-02-22 Thread Nicholas Marriott
For the first of these you can already use the tmux global environment or use user options which were added very recently you only need to worry about the second. I do not see compelling uses that can't be solved with existing shell or Unix features, can you give us some examples? tmux is not a p