Re: [PATCH] vi-copy: select line with V

2014-11-06 Thread Nicholas Marriott
Applied to OpenBSD now (sorry for the delay). Thanks! On Fri, Aug 08, 2014 at 01:34:52AM +0300, Juho Pohjala wrote: > Hi > > Thanks for the comments! Please check the updated patch. > > > in mode-keys.c you should also update the mode_key_cmdstr_copy array > Yes, new line was already included i

Re: [PATCH] vi-copy: select line with V

2014-08-07 Thread Juho Pohjala
Hi Thanks for the comments! Please check the updated patch. > in mode-keys.c you should also update the mode_key_cmdstr_copy array Yes, new line was already included in the previous patch. BR, Juho On Thu, Aug 7, 2014 at 11:06 PM, Nicholas Marriott wrote: > Yes I will look at this after Open

Re: [PATCH] vi-copy: select line with V

2014-08-07 Thread Nicholas Marriott
Yes I will look at this after OpenBSD tree unlocks. On Wed, Jul 23, 2014 at 09:49:13PM +0100, Balazs Kezes wrote: > On 2014-07-13 00:59 +0300, Juho Pohjala wrote: > > Please have a look at the updated patch. > > Thanks, this works surprisingly well! Some nits: in mode-keys.c you > should also up

Re: [PATCH] vi-copy: select line with V

2014-07-23 Thread Balazs Kezes
On 2014-07-13 00:59 +0300, Juho Pohjala wrote: > Please have a look at the updated patch. Thanks, this works surprisingly well! Some nits: in mode-keys.c you should also update the mode_key_cmdstr_copy array. Also, it would be nice if you could leave the line mode via v (normal mode) or ^v (block

Re: [PATCH] vi-copy: select line with V

2014-07-12 Thread Juho Pohjala
Hi Please have a look at the updated patch. -- Juho On Sun, Jun 22, 2014 at 1:28 PM, Juho Pohjala wrote: > Hi Balazs, > > Thanks for your comments. > > I agree with you and will implement what you suggested. > > -- > Juho > > > On Sat, Jun 21, 2014 at 6:46 PM, Balazs Kezes wrote: >> On 2014-0

Re: [PATCH] vi-copy: select line with V

2014-06-22 Thread Juho Pohjala
Hi Balazs, Thanks for your comments. I agree with you and will implement what you suggested. -- Juho On Sat, Jun 21, 2014 at 6:46 PM, Balazs Kezes wrote: > On 2014-06-21 14:46 +0300, Juho Pohjala wrote: >> Allow selecting the whole line with 'V'. > > I like the idea but your patch only select

Re: [PATCH] vi-copy: select line with V

2014-06-21 Thread Balazs Kezes
On 2014-06-21 14:46 +0300, Juho Pohjala wrote: > Allow selecting the whole line with 'V'. I like the idea but your patch only selects the current line. In vim when you press V you enter line selection mode -- pressing j/k will still keep full lines selected whereas your patch will continue selecti