Re: [PATCH] remember focused window panes while changing focus

2014-02-07 Thread Thomas Adam
On 7 February 2014 22:32, Suraj Kurapati wrote: > Hi Thomas, > > I thought my patch would be committed using "git am" (in which case, > the lengthy description I wrote would become the commit log and my > name would appear in the author field) but it wasn't. No, the commit comes from OpenBSD's CV

Re: [PATCH] remember focused window panes while changing focus

2014-02-07 Thread Thomas Adam
On 7 February 2014 20:16, Suraj Kurapati wrote: > Hi Nicholas, > > The discussion in ticket #97 http://sourceforge.net/p/tmux/tickets/97/ > seems to validate my patch. > > That makes me wonder... has it already been accepted into the tmux codebase? > > If so, could you please tell me the commit SH

Re: [PATCH] remember focused window panes while changing focus

2014-02-07 Thread Suraj Kurapati
Hi Thomas, I thought my patch would be committed using "git am" (in which case, the lengthy description I wrote would become the commit log and my name would appear in the author field) but it wasn't. As a result, I couldn't find my patch in the "git log" output. And so I asked here. :-) Thanks

Re: [PATCH] remember focused window panes while changing focus

2014-02-07 Thread Suraj Kurapati
Hi Nicholas, The discussion in ticket #97 http://sourceforge.net/p/tmux/tickets/97/ seems to validate my patch. That makes me wonder... has it already been accepted into the tmux codebase? If so, could you please tell me the commit SHA so I can verify? Thanks for your consideration. On Wed, Ja

Re: [PATCH] remember focused window panes while changing focus

2014-01-29 Thread Suraj Kurapati
Sorry for the late reply. I totally missed this thread (again) in my inbox. These changes seem fine to me... whatever gets my patch accepted! ;) I re-used *wp instead of adding a new member because I wanted to minimize the amount of changes I made to the codebase. The less changes I make, the e

Re: [PATCH] remember focused window panes while changing focus

2014-01-22 Thread Nicholas Marriott
hi take a look at this please - tweaked style and naming somewhat, particularly we have never used focus for anything apart from the focus events before so no reason to start now also used a new member of layout_cell otherwise it changes the layout string (this seems like another thing that shou

Re: [PATCH] remember focused window panes while changing focus

2014-01-14 Thread Suraj Kurapati
On 1/9/14, Nicholas Marriott wrote: > Could you resend your entire patch please? I haven't had time to look at > it yet and when I do it'd be easier if I have the whole thing in one > email. Sorry for the delay. I have re-sent the entire patch as a reply to this thread.

Re: [PATCH] remember focused window panes while changing focus

2014-01-09 Thread Nicholas Marriott
Could you resend your entire patch please? I haven't had time to look at it yet and when I do it'd be easier if I have the whole thing in one email. Thanks On Tue, Dec 31, 2013 at 08:31:44AM -0800, Suraj Kurapati wrote: > Hello, > > Hello, > > There was a bug in my original patch where `tmux s

Re: [PATCH] remember focused window panes while changing focus

2013-12-31 Thread Suraj Kurapati
Hello, Hello, There was a bug in my original patch where `tmux select-pane` would segfault if the current window had only 1 pane. The following changes fix that bug: diff --git a/window.c b/window.c index 7412a4d..adb67e0 100644 --- a/window.c +++ b/window.c @@ -1163,9 +1163,10 @@ window_pane_r