Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-09-05 Thread Romain Francoise
Nicholas Marriott writes: >> > Although I am a little inclined to instead add #[acs] #[noacs] and make >> > it use screen_write_cnputs so people can use #[format] stuff which might >> > be nice for choose-list. Wouldn't be so nice if you have a window called >> > #[foo] though... so maybe not. >>

Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-09-05 Thread Nicholas Marriott
On Wed, Sep 05, 2012 at 10:49:47PM +0200, Romain Francoise wrote: > Nicholas Marriott writes: > > > Sorry I didn't really give you many clear clues here - we actually need > > to make it pass some code through so the final write is done with the > > charset bit set. How about something like the d

Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-09-05 Thread Romain Francoise
Nicholas Marriott writes: > Sorry I didn't really give you many clear clues here - we actually need > to make it pass some code through so the final write is done with the > charset bit set. How about something like the diff below? Ah yes, very nice. It takes care of the acsc and utf-8 modes in

Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-09-05 Thread Nicholas Marriott
Hi Sorry I didn't really give you many clear clues here - we actually need to make it pass some code through so the final write is done with the charset bit set. How about something like the diff below? Although I am a little inclined to instead add #[acs] #[noacs] and make it use screen_write_cn

Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-09-05 Thread Romain Francoise
Nicholas Marriott writes: > Don't think I want to use UTF-8 arrows unless the ACS arrows will work > too. Ok. Conceptually we just have to use smacs/rmacs around the codes when writing to the terminal and it should work, right? I tried the naive approach below and the escape sequences are not in

Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-09-05 Thread Nicholas Marriott
Hi I took the non-UTF-8 bits of this but changed it to " |->" and " \->". Don't think I want to use UTF-8 arrows unless the ACS arrows will work too. Thanks On Mon, Aug 13, 2012 at 07:37:28PM +0200, Romain Francoise wrote: > Nicholas Marriott writes: > > > The problem is that you need to turn

Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-08-13 Thread Romain Francoise
Nicholas Marriott writes: > The problem is that you need to turn ACS on and off, it's not as simple > as just using and so on. There is currently no way to tell the > window-choose code that a section of an entry should be displayed with > ACS on. Ah, ok. Yeah, that sounds harder to fix. I

Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-08-13 Thread Nicholas Marriott
The problem is that you need to turn ACS on and off, it's not as simple as just using and so on. There is currently no way to tell the window-choose code that a section of an entry should be displayed with ACS on. On Mon, Aug 13, 2012 at 10:42:57AM +0200, Romain Francoise wrote: > Nicholas M

Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-08-13 Thread Romain Francoise
Nicholas Marriott writes: > I don't like using "`" at all, it tends to be very different between > different fonts and look weird in them all. > I'd rather have a solution that always worked not just with UTF-8 :-). Hmm. I didn't find the previous discussion between you and Thomas on this subje

Re: [PATCH] choose-tree: use line-drawing characters if possible

2012-08-11 Thread Nicholas Marriott
I don't like using "`" at all, it tends to be very different between different fonts and look weird in them all. I'd rather have a solution that always worked not just with UTF-8 :-). On Mon, Jul 30, 2012 at 02:54:17PM +0200, Romain Francoise wrote: > This is loosely based on a previous patch by