Re: [PATCH] Implement 'wait-for' command

2013-03-06 Thread Nicholas Marriott
Looks good, applied, thanks. On Wed, Mar 06, 2013 at 07:49:14AM -0300, Thiago Padilha wrote: > Here it is. My first patch contains a example shell script in case you > want to add. > --- > cmd-wait-for.c | 81 > ++ > tmux.1 | 12 ++

Re: [PATCH] Implement 'wait-for' command

2013-03-06 Thread Thiago Padilha
Here it is. My first patch contains a example shell script in case you want to add. --- cmd-wait-for.c | 81 ++ tmux.1 | 12 ++--- 2 files changed, 85 insertions(+), 8 deletions(-) diff --git a/cmd-wait-for.c b/cmd-wait-for.c inde

Re: [PATCH] Implement 'wait-for' command

2013-03-06 Thread Nicholas Marriott
No I don't think it is needed. On Wed, Mar 06, 2013 at 07:31:29AM -0300, Thiago Padilha wrote: > Do you want me to add the example script? > > On Wed, Mar 6, 2013 at 7:09 AM, Thiago Padilha wrote: > > Yes will do in a minute > > > > On Wed, Mar 6, 2013 at 6:58 AM, Nicholas Marriott > > wrote:

Re: [PATCH] Implement 'wait-for' command

2013-03-06 Thread Thiago Padilha
Do you want me to add the example script? On Wed, Mar 6, 2013 at 7:09 AM, Thiago Padilha wrote: > Yes will do in a minute > > On Wed, Mar 6, 2013 at 6:58 AM, Nicholas Marriott > wrote: >> Committed, thanks. Do you want to tweak the lock bits to fit too? >> >> >> On Wed, Mar 06, 2013 at 06:53:12A

Re: [PATCH] Implement 'wait-for' command

2013-03-06 Thread Thiago Padilha
Yes will do in a minute On Wed, Mar 6, 2013 at 6:58 AM, Nicholas Marriott wrote: > Committed, thanks. Do you want to tweak the lock bits to fit too? > > > On Wed, Mar 06, 2013 at 06:53:12AM -0300, Thiago Padilha wrote: >> This looks good to me >> >> On Wed, Mar 6, 2013 at 6:37 AM, Nicholas Marrio

Re: [PATCH] Implement 'wait-for' command

2013-03-06 Thread Nicholas Marriott
Committed, thanks. Do you want to tweak the lock bits to fit too? On Wed, Mar 06, 2013 at 06:53:12AM -0300, Thiago Padilha wrote: > This looks good to me > > On Wed, Mar 6, 2013 at 6:37 AM, Nicholas Marriott > wrote: > > Ok this looks pretty good. I've made a few changes but mainly style/layout

Re: [PATCH] Implement 'wait-for' command

2013-03-06 Thread Thiago Padilha
This looks good to me On Wed, Mar 6, 2013 at 6:37 AM, Nicholas Marriott wrote: > Ok this looks pretty good. I've made a few changes but mainly style/layout > nits: > > - I don't think we need find and find_and_create functions, the find > will only be done once and the create twice (when there

Re: [PATCH] Implement 'wait-for' command

2013-03-06 Thread Nicholas Marriott
Ok this looks pretty good. I've made a few changes but mainly style/layout nits: - I don't think we need find and find_and_create functions, the find will only be done once and the create twice (when there is lock too). - A single cmdq can only be waiting once so no need to have a wrapper str