Re: [PATCH] Fix off by one error

2014-08-11 Thread Nicholas Marriott
Applied thanks On Sun, Aug 10, 2014 at 09:49:14AM +0100, Balazs Kezes wrote: > On 2014-06-07 15:16 +0100, Balazs Kezes wrote: > > OK, I've attached a patch which fixes the behavior for the vi mode and > > also fixes the left key bug for the emacs mode. Please test both > > modes! > > Hi Nicholas

Re: [PATCH] Fix off by one error

2014-08-10 Thread Balazs Kezes
On 2014-06-07 15:16 +0100, Balazs Kezes wrote: > OK, I've attached a patch which fixes the behavior for the vi mode and > also fixes the left key bug for the emacs mode. Please test both > modes! Hi Nicholas! I believe you missed this patch, can you reconsider? Thanks! -- Balazs >From 49b46f56

Re: [PATCH] Fix off by one error

2014-06-19 Thread Nicholas Marriott
Applied, thanks. On Sat, Jun 14, 2014 at 01:54:07PM +0100, Balazs Kezes wrote: > And now I attach another followup patch for the vi mode. Can you > consider/test this one as well? Thanks! > > -- > Balazs > From fb35bdaf02c7991510569abcfd690903558c9532 Mon Sep 17 00:00:00 2001 > From: Balazs Ke

Re: [PATCH] Fix off by one error

2014-06-14 Thread Balazs Kezes
And now I attach another followup patch for the vi mode. Can you consider/test this one as well? Thanks! -- Balazs >From fb35bdaf02c7991510569abcfd690903558c9532 Mon Sep 17 00:00:00 2001 From: Balazs Kezes Date: Sat, 14 Jun 2014 13:45:06 +0100 Subject: [PATCH] Copy newline when cursor at end in

Re: [PATCH] Fix off by one error

2014-06-07 Thread Balazs Kezes
On 2014-06-06 22:47 +0100, Nicholas Marriott wrote: > I'd rather fix the original bug in both modes, but if you want to > change behaviour then do it only in vi mode. OK, I've attached a patch which fixes the behavior for the vi mode and also fixes the left key bug for the emacs mode. Please test

Re: [PATCH] Fix off by one error

2014-06-06 Thread Nicholas Marriott
Hi I'd rather fix the original bug in both modes, but if you want to change behaviour then do it only in vi mode. On Fri, Jun 06, 2014 at 10:36:29PM +0100, Balazs Kezes wrote: > On 2014-06-06 22:28 +0100, Nicholas Marriott wrote: > > Make sure you are in emacs mode, probably VISUAL or EDITOR is

Re: [PATCH] Fix off by one error

2014-06-06 Thread Balazs Kezes
On 2014-06-06 22:28 +0100, Nicholas Marriott wrote: > Make sure you are in emacs mode, probably VISUAL or EDITOR is changing > it for you. It definitely works as I described. IIRC someone added > some special cases for vi, maybe you are hitting one. Ah, that makes sense, I'm in vi mode (mode-keys

Re: [PATCH] Fix off by one error

2014-06-06 Thread Nicholas Marriott
ially) the selection behaviour. Original message From: Balazs Kezes Date: 06/06/2014 21:47 (GMT+00:00) To: Nicholas Marriott Cc: tmux-us...@lists.sf.net Subject: Re: [PATCH] Fix off by one error On 2014-06-06 15:08 +0100, Nicholas Marriott wrote: > If I have:

Re: [PATCH] Fix off by one error

2014-06-06 Thread Balazs Kezes
On 2014-06-06 15:08 +0100, Nicholas Marriott wrote: > If I have: > abcdef > xyz123 > With the cursor on the 1, then if I press C-Space to start the > selection then press Up, the selection should be "def\nxyz". > Your diff leaves me with "def\nxyz1" marked instead (although when I > actually cop

Re: [PATCH] Fix off by one error

2014-06-06 Thread Nicholas Marriott
Hi If I have: abcdef xyz123 With the cursor on the 1, then if I press C-Space to start the selection then press Up, the selection should be "def\nxyz". Your diff leaves me with "def\nxyz1" marked instead (although when I actually copy I still get "def\nxyz"). There are other marking bugs alrea

Re: [PATCH] Fix off by one error

2014-06-03 Thread Nicholas Marriott
I'll try again and give you a better explanation of what changes when I get home. We follow what emacs does if possible. Original message From: Balazs Kezes Date: 31/05/2014 11:41 (GMT+00:00) To: Nicholas Marriott Cc: tmux-us...@lists.sf.net Subject: Re: [PATCH] Fi

Re: [PATCH] Fix off by one error

2014-05-31 Thread Balazs Kezes
On 2014-05-27 14:11 +0100, Nicholas Marriott wrote: > I see the problem but looks like this fix changes the behaviour if you > are at EOL, moving up puts you one character in from the end. I've tested this at EOL and it seems to be working as expected. Can you explain how does it break for you? A

Re: [PATCH] Fix off by one error

2014-05-27 Thread Nicholas Marriott
Hi I see the problem but looks like this fix changes the behaviour if you are at EOL, moving up puts you one character in from the end. On Sat, May 24, 2014 at 11:02:02AM +0100, Balazs Kezes wrote: > On 2014-05-23 11:58 +0100, Nicholas Marriott wrote: > > Can you give me an example? It seems fin

Re: [PATCH] Fix off by one error

2014-05-24 Thread Balazs Kezes
On 2014-05-23 11:58 +0100, Nicholas Marriott wrote: > Can you give me an example? It seems fine to me. Sure. I've attached a screenshot. In the top part you can see that I've selected "quis nostrud" and it is highlighted correctly. But when I press up, the selection changes to "... quis nostru". T

Re: [PATCH] Fix off by one error

2014-05-23 Thread Nicholas Marriott
Can you give me an example? It seems fine to me. On Sun, May 18, 2014 at 10:41:10AM +0100, Balazs Kezes wrote: > When you start a selection and then move a line up, then the starting > cell isn't indicated to be in the selection. It should be and this patch > fixes that. > --- > screen.c | 2 +-