Ok, is this good to go?
On Wed, Apr 22, 2015 at 12:36:14AM +0100, Nicholas Marriott wrote:
> Hi
>
> I made a few changes to your first diff, please take a look. Notably:
>
> - update to latest git
> - renamed some functions and variables to be shorter
> - split window_copy_move_coordinates into
On Wed, 22 Apr 2015 01:57:10 +0100, Łukasz Piątkowski wrote:
> I believe that Nicholas only send the first diff which is refactoring.
> We just need to make sure that nothing is broken/changed with this diff.
Ah, that makes sense now. I'll report any issues with the patch. Thanks!
-
Hi Suraj,
I believe that Nicholas only send the first diff which is refactoring.
We just need to make sure that nothing is broken/changed with this diff.
Cheers,
Lukas
On 4/22/15 1:45 AM, Suraj N. Kurapati wrote:
> On Wed, 22 Apr 2015 00:36:14 +0100, Nicholas Marriott wrote:
>> I made a few cha
On Wed, 22 Apr 2015 00:36:14 +0100, Nicholas Marriott wrote:
> I made a few changes to your first diff, please take a look.
I tried this but I can't seem to trigger the new functionality:
1. Run "tmux copy-mode"
2. Press "?"
3. Start typing some text that is already shown on the screen
4. tmux do
Hi
I made a few changes to your first diff, please take a look. Notably:
- update to latest git
- renamed some functions and variables to be shorter
- split window_copy_move_coordinates into two functions to avoid so much ?:
- passing const int into a function is useless, just use int
- don't use
I think you should highlight by default and use mode-style, so no need
for extra options. I'll look at this again when I'm back home the week
after next.
On Mon, Mar 09, 2015 at 12:47:55AM +, ??ukasz Pi??tkowski wrote:
>I finally got some time to sit down and test my changes again. It app
Was there any follow up to this thread? Incremental search would be a
great feature to have and is on the TODO list.
Thanks.
-FR
On Fri, Aug 8, 2014 at 11:21 AM, Nicholas Marriott <
nicholas.marri...@gmail.com> wrote:
> Hi
>
> Your mailer has mangled the diffs, if you can't fix it so it works
>
Hi Felix,
I didn't have time to work on this, last few months were really busy. I
will try to rebase my changes on top of current revision and test them
before sending the code again. I hope I will find some time before the end
of year.
Cheers
Lukas
On 1 Nov 2014 00:42, "Felix Rosencrantz" wrote
Hi
Your mailer has mangled the diffs, if you can't fix it so it works
inline please send them as attachments instead.
On Mon, Aug 04, 2014 at 07:47:28PM -0700, ??ukasz Pi??tkowski wrote:
>I have split up my changes into 3 diffs, first is refactoring search code
>in window-copy.c, second i
