Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-23 Thread John Long
Hello Frank, On Mon, Apr 22, 2013 at 05:37:04PM +0200, Frank Terbeck wrote: > Okay. Bash uses the readline library for input handling. Zsh does not. > It has its own line editor implementation (zle: man zshzle). So, > generally, if bash works that doesn't mean anything for zsh. I remembered that

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-23 Thread John Long
On Mon, Apr 22, 2013 at 04:40:49PM +0100, Nicholas Marriott wrote: > Hmm this is weird. What is TERM set to inside tmux? screen > Do you have the infocmp command? If so please run "infocmp" inside tmux > and send me the output. It says: Sorry, I don't know anything about your "screen" terminal

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread Frank Terbeck
Hello John, Note, that I didn't read the whole backlog. From what I gathered, your zsh is misbehaving inside of tmux. I can guess what might be going on. Maybe I'm onto something or maybe not. I guess we'll only know if you try. ;) John Long wrote: [...] > Yes, correct. And only with zsh. In bash

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread Nicholas Marriott
Hmm this is weird. What is TERM set to inside tmux? Do you have the infocmp command? If so please run "infocmp" inside tmux and send me the output. On Mon, Apr 22, 2013 at 01:55:18PM +, John Long wrote: > I'm sending this again as attachments since the characters may not be > displayable in

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
I'm sending this again as attachments since the characters may not be displayable in email. First attachment is in xterm, second in tmux. Not sure if attachments will go through to the mailing list though. If it doesn't work let me know and I'll send it to you directly. Script started on Mon Apr 2

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 02:31:13PM +0100, Nicholas Marriott wrote: > Ok so zsh is probably sending something weird. > > Can you run script then reproduce then exit script and send me the > typescript file, eg something like: > > $ script > Script started, output file is typescript > $ abcdef > $

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 02:11:31PM +0100, Nicholas Marriott wrote: > This isn't clear. Are you saying the problem only occurs at the zsh > prompt and not when you do it with cat? Yes. > > If I do this at my shell prompt, where X is the cursor: > > $ abcdefX > > I get: > > $ abcdeX > > If I

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread Nicholas Marriott
Ok so zsh is probably sending something weird. Can you run script then reproduce then exit script and send me the typescript file, eg something like: $ script Script started, output file is typescript $ abcdef $ exit On Mon, Apr 22, 2013 at 01:25:42PM +, John Long wrote: > On Mon, Apr 22,

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 02:15:49PM +0100, Nicholas Marriott wrote: > Ok so the problem only occurs with zsh. > If you reproduce the problem inside tmux and then press C-b r (where C-b > is your tmux prefix key), does the cursor move to the right place? No, it doesn't move at all. ---

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread Nicholas Marriott
Ok so the problem only occurs with zsh. If you reproduce the problem inside tmux and then press C-b r (where C-b is your tmux prefix key), does the cursor move to the right place? On Mon, Apr 22, 2013 at 01:08:54PM +, John Long wrote: > On Mon, Apr 22, 2013 at 01:58:33PM +0100, Nicholas Mar

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 01:08:54PM +, John Long wrote: > > I'm trying to work out if this is because tmux is getting the wrong > > thing from zsh, or getting the right thing from zsh but displaying the > > wrong thing for xterm. > > Wondering about this earlier, I switched to bash before invo

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread Nicholas Marriott
On Mon, Apr 22, 2013 at 01:03:53PM +, John Long wrote: > On Mon, Apr 22, 2013 at 12:48:47PM +, John Long wrote: > > On Mon, Apr 22, 2013 at 01:38:37PM +0100, Nicholas Marriott wrote: > > > Hmm this looks fine too. If you do "cat" outside tmux and press > > > backspace, do you get "^H" or no

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 01:58:33PM +0100, Nicholas Marriott wrote: > Ok, but is that behaviour just at the shell prompt, or if you run "cat" > then do the same, ie you are typing in cat rather than at the shell, > does the cursor also move wrongly? Eg do: > > $ cat > abcdef > > Instead of at the

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 12:48:47PM +, John Long wrote: > On Mon, Apr 22, 2013 at 01:38:37PM +0100, Nicholas Marriott wrote: > > Hmm this looks fine too. If you do "cat" outside tmux and press > > backspace, do you get "^H" or nothing printed? > > It does what I would expect, it erases the t in

Re: Integration of patches for Solaris

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 02:48:04PM +0200, Dagobert Michelsen wrote: > > Thanks for all your work on > > Solaris packaging, fixes, etc. I don't use any of it because I don't want > > the infrastructure and I don't want to make Solaris' preexisting package > > hell any worse, > > I really don't und

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread Nicholas Marriott
On Mon, Apr 22, 2013 at 12:48:47PM +, John Long wrote: > On Mon, Apr 22, 2013 at 01:38:37PM +0100, Nicholas Marriott wrote: > > Hmm this looks fine too. If you do "cat" outside tmux and press > > backspace, do you get "^H" or nothing printed? > > It does what I would expect, it erases the t in

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 01:38:37PM +0100, Nicholas Marriott wrote: > Hmm this looks fine too. If you do "cat" outside tmux and press > backspace, do you get "^H" or nothing printed? It does what I would expect, it erases the t in cat and leaves me with ca, no funny characters are printed. > > Wh

Re: Integration of patches for Solaris

2013-04-22 Thread Dagobert Michelsen
Hi John, Am 22.04.2013 um 13:28 schrieb John Long : > On Mon, Apr 22, 2013 at 01:00:19PM +0200, Dagobert Michelsen wrote: > >> No, that is just the files from git. "Using git" is facilitating the command >> listed on the webpage >> git clone git://git.code.sf.net/p/tmux/tmux-code tmux-tmux-code

Re: Integration of patches for Solaris

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 01:20:29PM +0100, Nicholas Marriott wrote: > > Unfortunately, I am having the same problem I have always had on Solaris > > Intel: the backspace key goes in the wrong direction. This is real odd > > because on Solaris SPARC it works ok. > > > > Do you or anyone else have a

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread Nicholas Marriott
Hmm this looks fine too. If you do "cat" outside tmux and press backspace, do you get "^H" or nothing printed? When you say the backspace goes forward, do you mean that the cursor moves right but the character is still deleted, or the cursor moves but the character isn't deleted, or what? Does it

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 01:25:55PM +0100, Nicholas Marriott wrote: > The stty looks fine I think, but I wonder if you backspace key is > sending ^H rather than ^?. > > I wonder if that is the case and your TERM has left or right set to ^H. > > Can you start tmux and then do "tmux info" and send m

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread Nicholas Marriott
The stty looks fine I think, but I wonder if you backspace key is sending ^H rather than ^?. I wonder if that is the case and your TERM has left or right set to ^H. Can you start tmux and then do "tmux info" and send me the output? On Mon, Apr 22, 2013 at 12:16:55PM +, John Long wrote: >

Re: Integration of patches for Solaris

2013-04-22 Thread Nicholas Marriott
On Mon, Apr 22, 2013 at 12:00:24PM +, John Long wrote: > Hi Nicholas, > > Thank you very much. In the meantime after I got Dagobert's answer and had > not yet received your post, I compiled and installed the latest gawk and the > tmux build goes ok now. It still looks we're in somewhat of a fl

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 12:54:59PM +0100, Nicholas Marriott wrote: > What was the mail subject of the previous thread? This was my first email to the list, with a bad subject line since I was posting past my bedtime: http://sourceforge.net/mailarchive/message.php?msg_id=29643966 Sometime after t

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 12:54:59PM +0100, Nicholas Marriott wrote: > What was the mail subject of the previous thread? Oh, sorry, I suppose you mean the thread from last year? Let me check and I'll post here again as soon as I find it. Thanks.

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel]

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 12:54:59PM +0100, Nicholas Marriott wrote: > What was the mail subject of the previous thread? Same as above, minus the "[backspace key.." etc. > Can you send me "stty -a" output inside and outside tmux? Yes, thank you here it is: This is the stty -a output from an xter

Re: Integration of patches for Solaris

2013-04-22 Thread John Long
Hi Nicholas, Thank you very much. In the meantime after I got Dagobert's answer and had not yet received your post, I compiled and installed the latest gawk and the tmux build goes ok now. It still looks we're in somewhat of a flux regarding which of Dagobert's patches made it to head because with

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread Nicholas Marriott
What was the mail subject of the previous thread? Can you send me "stty -a" output inside and outside tmux? On Mon, Apr 22, 2013 at 11:47:32AM +, John Long wrote: > > > The script is for gawk, not nawk. Feel free to use e.g. the one from > > > > OpenCSW. > > I built the latest copy of gawk

Re: Integration of patches for Solaris

2013-04-22 Thread Nicholas Marriott
The script isn't for awk, I think we just invoke it in a way nawk isn't pleased with. Try this please: You will need to run autogen.sh again. diff --git a/Makefile.am b/Makefile.am index c5369fd..c131940 100644 --- a/Makefile.am +++ b/Makefile.am @@ -242,7 +242,7 @@ tmux.1: tmux.1.in if t

Re: Integration of patches for Solaris [backspace key goes forward on Solaris Intel

2013-04-22 Thread John Long
> > The script is for gawk, not nawk. Feel free to use e.g. the one from > > > OpenCSW. I built the latest copy of gawk and now tmux builds ok, but I am back to the same problem I reported last year, which is the backspace key goes forward. Do you have any idea what could be causing this? It's bee

Re: Integration of patches for Solaris

2013-04-22 Thread John Long
Hi Dagobert, On Mon, Apr 22, 2013 at 01:00:19PM +0200, Dagobert Michelsen wrote: > No, that is just the files from git. "Using git" is facilitating the command > listed on the webpage > git clone git://git.code.sf.net/p/tmux/tmux-code tmux-tmux-code > or something. Learning git pays off, but ha

Re: Integration of patches for Solaris

2013-04-22 Thread Dagobert Michelsen
Hi John, Am 22.04.2013 um 12:46 schrieb John Long : > On Sun, Apr 21, 2013 at 10:55:29PM +0200, Dagobert Michelsen wrote: >> Hi John, >> >> Am 21.04.2013 um 17:26 schrieb John Long : >>> On Sun, Apr 21, 2013 at 05:16:09PM +0200, Dagobert Michelsen wrote: Am 21.04.2013 um 12:48 schrieb John L

Re: Integration of patches for Solaris

2013-04-22 Thread John Long
On Mon, Apr 22, 2013 at 09:45:29AM +0100, Nicholas Marriott wrote: > In the first diff it should be enough just to remove the #include line > because compat.h already includes it, so I have done that. > > The lockf change has gone into the OpenBSD repo rather than portable so > will be pulled thro

Re: Integration of patches for Solaris

2013-04-22 Thread John Long
On Sun, Apr 21, 2013 at 10:55:29PM +0200, Dagobert Michelsen wrote: > Hi John, > > Am 21.04.2013 um 17:26 schrieb John Long : > > On Sun, Apr 21, 2013 at 05:16:09PM +0200, Dagobert Michelsen wrote: > >> Am 21.04.2013 um 12:48 schrieb John Long: > >> All patches are against HEAD: > >> https://sour

Re: Integration of patches for Solaris

2013-04-22 Thread Nicholas Marriott
In the first diff it should be enough just to remove the #include line because compat.h already includes it, so I have done that. The lockf change has gone into the OpenBSD repo rather than portable so will be pulled through to git in the next sync. Applied the cfmakeraw change as-is. Many thank

Re: Integration of patches for Solaris

2013-04-21 Thread Dagobert Michelsen
Hi John, Am 21.04.2013 um 17:26 schrieb John Long : > On Sun, Apr 21, 2013 at 05:16:09PM +0200, Dagobert Michelsen wrote: >> Am 21.04.2013 um 12:48 schrieb John Long: >> All patches are against HEAD: >> https://sourceforge.net/p/tmux/tmux-code/ci/master/tree/ > > Ok, downloaded the tarball… I s

Re: Integration of patches for Solaris

2013-04-21 Thread John Long
On Sun, Apr 21, 2013 at 05:16:09PM +0200, Dagobert Michelsen wrote: > Hi John, > > Am 21.04.2013 um 12:48 schrieb John Long: > All patches are against HEAD: > https://sourceforge.net/p/tmux/tmux-code/ci/master/tree/ Ok, downloaded the tarball... > > Make sure to call autogen.sh before buildin

Re: Integration of patches for Solaris

2013-04-21 Thread Dagobert Michelsen
Hi John, Am 21.04.2013 um 12:48 schrieb John Long: > I tried applying these against 1.8 and the first patch doesn't apply. I > tried to apply it manually (looks pretty simple) but the code doesn't build, > it had various errors (some includes weren't picked up) and the timersub > function wasn't f

Re: Integration of patches for Solaris

2013-04-21 Thread John Long
Thanks, will you please post a note here when they're in so I can download the lastest tarball and try again? /jl On Sun, Apr 21, 2013 at 01:22:06PM +0100, Nicholas Marriott wrote: > BTW these changes look fine to me and I will apply them when I have a > bit more time, thanks > > > > On Sun, A

Re: Integration of patches for Solaris

2013-04-21 Thread Nicholas Marriott
BTW these changes look fine to me and I will apply them when I have a bit more time, thanks On Sun, Apr 21, 2013 at 10:30:41AM +0200, Dagobert Michelsen wrote: > Hi John, > > Am 20.04.2013 um 21:40 schrieb John Long : > > On Fri, Apr 19, 2013 at 04:14:16PM +0200, Dagobert Michelsen wrote: > >>

Re: Integration of patches for Solaris

2013-04-21 Thread John Long
Hi Dagobert, I tried applying these against 1.8 and the first patch doesn't apply. I tried to apply it manually (looks pretty simple) but the code doesn't build, it had various errors (some includes weren't picked up) and the timersub function wasn't found. I did a bunch of hand updates but then t

Re: Integration of patches for Solaris

2013-04-21 Thread John Long
Hi Dagobert, Thanks alot, I'll get back to you in asap. I want to test this on the latest stable version on Intel and SPARC. /jl On Sun, Apr 21, 2013 at 10:30:41AM +0200, Dagobert Michelsen wrote: > Hi John, > > Am 20.04.2013 um 21:40 schrieb John Long : > > On Fri, Apr 19, 2013 at 04:14:16PM +

Re: Integration of patches for Solaris

2013-04-21 Thread Dagobert Michelsen
Hi John, Am 20.04.2013 um 21:40 schrieb John Long : > On Fri, Apr 19, 2013 at 04:14:16PM +0200, Dagobert Michelsen wrote: >> I rewrote the patch to use contrib/ substitutions for cfmakeraw and use >> lockf: >> https://sourceforge.net/p/tmux/tmux-code/merge-requests/3/ > > Thank you. Is there so

Re: Integration of patches for Solaris

2013-04-20 Thread John Long
On Fri, Apr 19, 2013 at 04:14:16PM +0200, Dagobert Michelsen wrote: > Hi Nicholas, > > I rewrote the patch to use contrib/ substitutions for cfmakeraw and use lockf: > https://sourceforge.net/p/tmux/tmux-code/merge-requests/3/ Thank you. Is there some way to download all the changes so I can ap

Integration of patches for Solaris

2013-04-19 Thread Dagobert Michelsen
Hi Nicholas, I rewrote the patch to use contrib/ substitutions for cfmakeraw and use lockf: https://sourceforge.net/p/tmux/tmux-code/merge-requests/3/ Would it be possible to merge it or is there something missing from my side? Best regards -- Dago -