Re: Crash on master

2015-02-09 Thread Nicholas Marriott
Yes it will use @0 from session 0, if you try to move from another session to the current one using the window id, it will fail. On Mon, Feb 09, 2015 at 10:55:50AM -0500, Ben Boeckel wrote: > On Mon, Feb 09, 2015 at 15:53:59 +, Nicholas Marriott wrote: > > Hmm weird it doesn't work for me, oh

Re: Crash on master

2015-02-09 Thread Ben Boeckel
On Mon, Feb 09, 2015 at 15:53:59 +, Nicholas Marriott wrote: > Hmm weird it doesn't work for me, oh well... Maybe because my test case was: tmux # in another terminal tmux tmux movew -s @0 -t 1:1 and it just grabbed *session* 0 instead? --Ben --

Re: Crash on master

2015-02-09 Thread Nicholas Marriott
Hmm weird it doesn't work for me, oh well... On Mon, Feb 09, 2015 at 10:39:33AM -0500, Ben Boeckel wrote: > On Mon, Feb 09, 2015 at 12:37:26 +, Nicholas Marriott wrote: > > (I think what you were trying would not work at the moment, we should > > probably make cmd_lookup_window pass @foo thro

Re: Crash on master

2015-02-09 Thread Ben Boeckel
On Mon, Feb 09, 2015 at 12:37:26 +, Nicholas Marriott wrote: > (I think what you were trying would not work at the moment, we should > probably make cmd_lookup_window pass @foo through cmd_window_session if > it isn't in the current session...) Hmm. It *does* work, but it also hasn't crashed s

Re: Crash on master

2015-02-09 Thread Nicholas Marriott
Hmm. The windows list can contain NULL, so window_find_by_id is probably wrong here, but I'm not sure how you got to that codepath in the first place. Clearly it is possible though. (I think what you were trying would not work at the moment, we should probably make cmd_lookup_window pass @foo thro

Crash on master

2015-02-08 Thread Ben Boeckel
Hi, With commit df6488a47088ec8bcddc6a1cfa85fec1a462c789, I experienced a crash that I haven't been able to reproduce (yet). The setup (as close as I can remember): - days-old session; up to session 23 by the command in the backtrace; - client attached to a session with window id 398 as the l