Re: Commit 7360ff breaks compiling on OSX 10.6.8

2013-04-10 Thread Nicholas Marriott
Applied, thanks. On Tue, Apr 02, 2013 at 01:32:56PM +0900, OZAKI Kiichi wrote: > Sorry, my patch caused compile error. I didn't make sure the availability on > other OS X version (my env is 10.8.x). > > I replaced proc_bsdshortinfo by proc_bsdinfo, which exists on 10.5 and later. > https://gist

Re: Commit 7360ff breaks compiling on OSX 10.6.8

2013-04-03 Thread Jared Scheel
Oh, nice Chris. I can definitely give it a try. This looks like it would be better to go into tmux. -Jared On Tue, Apr 2, 2013 at 2:33 AM, Chris Johnsen wrote: > The MacPorts project has come up with a different approach to fixing > the 1.8 build on OS X 10.6: use proc_bsdinfo instead of > proc_

Re: Commit 7360ff breaks compiling on OSX 10.6.8

2013-04-02 Thread OZAKI Kiichi
Sorry, my patch caused compile error. I didn't make sure the availability on other OS X version (my env is 10.8.x). I replaced proc_bsdshortinfo by proc_bsdinfo, which exists on 10.5 and later. https://gist.github.com/ichizok/5289677/raw/da84bc2bcc0578b2df0222c01f831c0fd50d1b45/osdep-datwin.c.pat

Re: Commit 7360ff breaks compiling on OSX 10.6.8

2013-04-02 Thread Chris Johnsen
The MacPorts project has come up with a different approach to fixing the 1.8 build on OS X 10.6: use proc_bsdinfo instead of proc_bsdshortinfo. The former looks to be a superset of the latter (based on the struct declarations), and it looks like it has been around since 10.5. https://trac.macp

Re: Commit 7360ff breaks compiling on OSX 10.6.8

2013-03-28 Thread Jared Scheel
Worked like a charm! Probably figured out I meant 10.6.8 (for when people see this thread months from now and a 10.8.6 really exists). Thanks! -Jared On Wed, Mar 27, 2013 at 3:34 PM, Nicholas Marriott < nicholas.marri...@gmail.com> wrote: > Hmm sure. This fixed an actual bug so we shouldn't just

Re: Commit 7360ff breaks compiling on OSX 10.6.8

2013-03-28 Thread Nicholas Marriott
Ok thanks. On Wed, Mar 27, 2013 at 09:02:15PM -0500, Chris Johnsen wrote: > On Wed, Mar 27, 2013 at 5:37 PM, Nicholas Marriott > wrote: > > Can anyone please test this on OS X 10.7 and make sure it still builds and > > automatic-rename still works? > > I do not have a 10.7 machine, but I was ab

Re: Commit 7360ff breaks compiling on OSX 10.6.8

2013-03-27 Thread Chris Johnsen
On Wed, Mar 27, 2013 at 5:37 PM, Nicholas Marriott wrote: > Can anyone please test this on OS X 10.7 and make sure it still builds and > automatic-rename still works? I do not have a 10.7 machine, but I was able to dig up another 10.6.8 machine. The change to check for __MAC_10_7 does let the cur

Re: Commit 7360ff breaks compiling on OSX 10.6.8

2013-03-27 Thread Nicholas Marriott
Can anyone please test this on OS X 10.7 and make sure it still builds and automatic-rename still works? On Wed, Mar 27, 2013 at 04:02:04PM -0500, Jared Scheel wrote: >Worked like a charm! Probably figured out I meant 10.6.8 (for when people >see this thread months from now and a 10.8.6

Re: Commit 7360ff breaks compiling on OSX 10.6.8

2013-03-27 Thread Nicholas Marriott
Hmm sure. This fixed an actual bug so we shouldn't just revert. So unless you know how to fix the previous code for old OS X version, we may just disable automatic rename. Can you try this? Untested of course. There is probably a less stupid way to check the OS X version, if you know it let me kn

Commit 7360ff breaks compiling on OSX 10.6.8

2013-03-27 Thread Jared Scheel
This commit results in a failure to compile on 10.8.6: http://sourceforge.net/p/tmux/tmux-code/ci/7360ff4496bfd159ac5935a18de675f067c375db/ Error: osdep-darwin.c: In function ‘osdep_get_name’: osdep-darwin.c:36: error: storage size of ‘bsdinfo’ isn’t known osdep-darwin.c:43: error: ‘PROC_PIDT_SHOR