Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-08-04 Thread Daniel Ralston
On Sat, Jul 27, 2013 at 9:55 AM, Nicholas Marriott wrote: > I don't think it is right to move recalculate_sizes(), we should do > whatever is needed to make it safe to call it there. Do you have a > backtrace? I do indeed, and here it is. I also have the full core dump compressed down to 2.5 Mb.

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-08-04 Thread Daniel Ralston
On Sat, Jul 27, 2013 at 8:07 AM, Nicholas Marriott wrote: > Does this do it instead? > > diff --git a/server-fn.c b/server-fn.c > index 7ef6413..37ef879 100644 > --- a/server-fn.c > +++ b/server-fn.c > @@ -396,9 +396,9 @@ server_destroy_session_group(struct session *s) > if ((sg = session_

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-08-04 Thread Daniel Ralston
After applying your patch, I can't reproduce the crash anymore. Looks like that fixed it. Thanks! Daniel On Sat, Jul 27, 2013 at 11:45 AM, Nicholas Marriott wrote: > Try this please. > > The fix is the first part in resize.c to make recalculate_sizes() handle > an empty window with no activ

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-08-04 Thread Daniel Ralston
On Sat, Jul 27, 2013 at 4:49 AM, Thomas Adam wrote: > I appreciate your bug reports, because they're easy for me to reproduce, but > the next time you submit one, I'd appreciate something like a corefile > backtrace. Ah, I had wondered about that. I'll include a core dump with my bug reports from

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-07-30 Thread Nicholas Marriott
ion's last window's program from a grouped session After applying your patch, I can't reproduce the crash anymore. Looks like that fixed it. Thanks!     Daniel On Sat, Jul 27, 2013 at 11:45 AM, Nicholas Marriott wrote: > Try this please. > > The fix is the f

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-07-27 Thread Nicholas Marriott
Try this please. The fix is the first part in resize.c to make recalculate_sizes() handle an empty window with no active pane. This can happen because the window is in two sessions and isn't destroyed immediately when the pane goes away but is left until the last session is destroyed. IMO that isn

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-07-27 Thread Nicholas Marriott
I don't think it is right to move recalculate_sizes(), we should do whatever is needed to make it safe to call it there. Do you have a backtrace? On Sat, Jul 27, 2013 at 09:22:55AM -0700, Daniel Ralston wrote: > On Sat, Jul 27, 2013 at 8:07 AM, Nicholas Marriott > wrote: > > Does this do it ins

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-07-27 Thread Nicholas Marriott
Does this do it instead? diff --git a/server-fn.c b/server-fn.c index 7ef6413..37ef879 100644 --- a/server-fn.c +++ b/server-fn.c @@ -396,9 +396,9 @@ server_destroy_session_group(struct session *s) if ((sg = session_group_find(s)) == NULL) server_destroy_session(s);

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-07-27 Thread Thomas Adam
On Thu, Jul 25, 2013 at 08:25:52PM -0700, Daniel Ralston wrote: > Hi all, > > I've found a bug. > > Repro steps: > 1. Run 'tmux' in a terminal. > > 2. In another terminal, create a grouped session, by running > 'tmux new-session -t '. > > 3. Resize the second terminal so it is bigger tha

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-07-27 Thread Thomas Adam
On 27 July 2013 12:20, Romain Francoise wrote: > Which tmux version are you using? Can you reproduce the bug with the > latest code from Git? I can, and a patch will be arriving shortly. -- Thomas Adam -- See everything

Re: BUG: Crash when killing a session's last window's program from a grouped session

2013-07-27 Thread Romain Francoise
Which tmux version are you using? Can you reproduce the bug with the latest code from Git? -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppD

BUG: Crash when killing a session's last window's program from a grouped session

2013-07-27 Thread Daniel Ralston
Hi all, I've found a bug. Repro steps: 1. Run 'tmux' in a terminal. 2. In another terminal, create a grouped session, by running 'tmux new-session -t '. 3. Resize the second terminal so it is bigger than the first one. 4. Kill the program running in the second (larger) terminal; e.g. b