Re: [patch] Fix buffer overflow crash in cmd_print()

2013-05-15 Thread Nicholas Marriott
Applied, thanks. On Tue, Apr 30, 2013 at 11:11:52AM -0700, George Nachman wrote: >cmd_print() has a bug that causes a crash on very long commands. >args_print() may return a value equal to the passed-in length, and >cmd_print() appends a null after that location, which steps on the sta

[patch] Fix buffer overflow crash in cmd_print()

2013-04-30 Thread George Nachman
cmd_print() has a bug that causes a crash on very long commands. args_print() may return a value equal to the passed-in length, and cmd_print() appends a null after that location, which steps on the stack of cmdq_continue(). This patch reserves space for the null in the length passed to arg_print()