Re: [Patch] status-drawing crash

2010-01-27 Thread Nicholas Marriott
Ah yeah it assumes that if the cellsizes match they are also the same as sx, which they don't have to be. It should be fixed to use cellsize probably, since if they are the same there isn't any point in checking further. On Wed, Jan 27, 2010 at 12:38:08PM -0800, Micah Cowan wrote: > Nicholas Marr

Re: [Patch] status-drawing crash

2010-01-27 Thread Micah Cowan
Nicholas Marriott wrote: >> Bad memory accesses occurs when we get to the call to grid_compare() >> after the "out:" label. Inside grid_compare(), the inner loop assumes >> that both grids use their entire horizontal space on each line. > > Hmm. It explicitly checks they are the same size (gla->ce

Re: [Patch] status-drawing crash

2010-01-27 Thread Nicholas Marriott
Committed, thanks. On Mon, Jan 25, 2010 at 07:34:02PM -0800, Micah Cowan wrote: > I found a bug that can cause the status bar to crash when the > window-list fills up. It only manifests when status-left is empty. > > The cause was a one-off in status.c. During calculation of how much > space wil

Re: [Patch] status-drawing crash

2010-01-27 Thread Nicholas Marriott
On Mon, Jan 25, 2010 at 07:34:02PM -0800, Micah Cowan wrote: > I found a bug that can cause the status bar to crash when the > window-list fills up. It only manifests when status-left is empty. > > The cause was a one-off in status.c. During calculation of how much > space will be available to the

[Patch] status-drawing crash

2010-01-25 Thread Micah Cowan
I found a bug that can cause the status bar to crash when the window-list fills up. It only manifests when status-left is empty. The cause was a one-off in status.c. During calculation of how much space will be available to the window-list, an extra space is counted for llen when status-left has c