Re: [PATCH 3/4] tty_term: use an unsigned int for flags

2015-02-22 Thread Nicholas Marriott
No particular reason but I don't think we should change them, I'd just cast it or leave the warning. On Sun, Feb 22, 2015 at 02:03:17PM -0500, Ben Boeckel wrote: > On Sun, Feb 22, 2015 at 18:46:33 +, Nicholas Marriott wrote: > > I always use int for flags. > > Any reason why? It changes the

Re: [PATCH 3/4] tty_term: use an unsigned int for flags

2015-02-22 Thread Ben Boeckel
On Sun, Feb 22, 2015 at 18:46:33 +, Nicholas Marriott wrote: > I always use int for flags. Any reason why? It changes the meaning of some bits, but I can use u_int for its format usage as well (it is %x). --Ben -- Do

Re: [PATCH 3/4] tty_term: use an unsigned int for flags

2015-02-22 Thread Nicholas Marriott
I always use int for flags. On Sun, Feb 22, 2015 at 11:34:25AM -0500, Ben Boeckel wrote: > Signed-off-by: Ben Boeckel > --- > tmux.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tmux.h b/tmux.h > index e296ac7..1ba0e83 100644 > --- a/tmux.h > +++ b/tmux.h > @@ -1093

[PATCH 3/4] tty_term: use an unsigned int for flags

2015-02-22 Thread Ben Boeckel
Signed-off-by: Ben Boeckel --- tmux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tmux.h b/tmux.h index e296ac7..1ba0e83 100644 --- a/tmux.h +++ b/tmux.h @@ -1093,7 +1093,7 @@ struct tty_term { #define TERM_256COLOURS 0x1 #define TERM_EARLYWRAP 0x2 - int