Re: [PATCH 1/2] Implement simple mouse wheel emulation, 3rd.

2014-02-27 Thread Nicholas Marriott
Hmm was working for me. Will try when I get home tonight Original message From: Marcel Partap Date: 27/02/2014 12:56 (GMT+00:00) To: Nicholas Marriott Cc: tmux-users@lists.sourceforge.net Subject: Re: [PATCH 1/2] Implement simple mouse wheel emulation, 3rd. Actually

Re: [PATCH 1/2] Implement simple mouse wheel emulation, 3rd.

2014-02-27 Thread Marcel Partap
Actually, it doesn't need a server_ function. Then again, it doesn't compile for some obscure reason. Huh? >From 92a2e3db2cd2e8fabb01762bec678c3868a46e11 Mon Sep 17 00:00:00 2001 From: Nicholas Marriott Date: Wed, 26 Feb 2014 23:04:23 + Subject: [PATCH] Implement simple mouse wheel emulation,

Re: [PATCH 1/2] Implement simple mouse wheel emulation, 3rd.

2014-02-27 Thread Nicholas Marriott
On Thu, Feb 27, 2014 at 08:01:24AM +0100, Marcel Partap wrote: > > Not wild about returning +/- lines from the func > one could instead switch(m->wheel) and just return unsigned lines count? > Yes I thought of this late last night, I'll try it if I get time today. > > trying to avoid adding more

Re: [PATCH 1/2] Implement simple mouse wheel emulation, 3rd.

2014-02-26 Thread Marcel Partap
> Not wild about returning +/- lines from the func one could instead switch(m->wheel) and just return unsigned lines count? > trying to avoid adding more functions to server-fn.c... I don't quite grok the seperation logic between server-fn.c/server-client.c/client.c .. > Looks like gnome eats shi

Re: [PATCH 1/2] Implement simple mouse wheel emulation, 3rd.

2014-02-26 Thread Nicholas Marriott
I don't think we need an option or a big section in the man page. Please look at this. Not wild about returning +/- lines from the func, and we do need to add to manpage somewhere, just a few lines not a whole section. Also was trying to avoid adding more functions to server-fn.c... Looks like g

Re: [PATCH 1/2] Implement simple mouse wheel emulation, 3rd.

2014-02-26 Thread Marcel Partap
> Can the duplicated code not be refactored into a shared function? It > looks like you could pass in "m" and return an integer representing the > number of key events to send? Definitely, but I'm not quite sure where to put it... ---

Re: [PATCH 1/2] Implement simple mouse wheel emulation, 3rd.

2014-02-26 Thread Paul Gideon Dann
On Wednesday 26 Feb 2014 13:04:18 Marcel Partap wrote: > [ Now why did git send-email munge my memo? .. anyway...] > Here's the 3rd iteration, including a wee man page section. > The code duplication sucks. > Comments welcome. Can the duplicated code not be refactored into a shared function? It l

Re: [PATCH 1/2] Implement simple mouse wheel emulation, 3rd.

2014-02-26 Thread Marcel Partap
[ Now why did git send-email munge my memo? .. anyway...] Here's the 3rd iteration, including a wee man page section. The code duplication sucks. Comments welcome. #Regards. -- Flow-based real-time traffic analytics softwa

[PATCH 1/2] Implement simple mouse wheel emulation, 3rd.

2014-02-26 Thread Marcel Partap
--- input-keys.c| 17 + options-table.c | 7 +++ tmux.1 | 23 +++ tmux.h | 5 + window-choose.c | 19 ++- window-copy.c | 12 +--- 6 files changed, 79 insertions(+), 4 deletions(-) diff --git a/input-key