Re: [PATCH 1/1] choose-list: Don't segfault on empty list

2012-09-05 Thread Thomas Adam
Hi, On 5 September 2012 11:04, Nicholas Marriott wrote: > This looks wrong - the first item now has index (u_int)-1? Yeah -- wasn't thinking properly. -- Thomas Adam -- Live Security Virtual Conference Exclusive live e

Re: [PATCH 1/1] choose-list: Don't segfault on empty list

2012-09-05 Thread Nicholas Marriott
This looks wrong - the first item now has index (u_int)-1? idx will still be 0 if there was nothing added, so why not just this? Index: cmd-choose-list.c === RCS file: /cvs/src/usr.bin/tmux/cmd-choose-list.c,v retrieving revision 1.2

[PATCH 1/1] choose-list: Don't segfault on empty list

2012-09-05 Thread Thomas Adam
Even though we skip empty entries separated with commas when we're looking at each item, an input such as: choose-list -l ,, would still mean we go on to display a blank line, resulting in a segfault as there's no data associated with that entry. --- cmd-choose-list.c | 15 --- 1