Re: [PATCH 0/1] Expand/collapse in choose-tree

2012-10-01 Thread Romain Francoise
Thomas Adam writes: > I am not so sure I like this -- I don't mind updating the man page to > detail this more, but I don't think this warrants explanatory text > directly on the screen. Fair enough. It won't be the only awesome feature in tmux that is only discoverable by reading the man page.

Re: [PATCH 0/1] Expand/collapse in choose-tree

2012-10-01 Thread Nicholas Marriott
No it's just an idea, can be done later. On Mon, Oct 01, 2012 at 12:33:18PM +0100, Thomas Adam wrote: > On 30 September 2012 23:50, Nicholas Marriott > wrote: > > Using space is a good idea but definitely don't want any help text > > clutter. It would be nice to make ? key show all the key bindi

Re: [PATCH 0/1] Expand/collapse in choose-tree

2012-10-01 Thread Thomas Adam
On 30 September 2012 19:00, Romain Francoise wrote: > Thanks, I like it. Two minor suggestions: > - the arrow keys are too far to reach for me, using Space to expand or > collapse the items would be nice. I implemented this in the following > patch, as a new toggle action. I quite like this -

Re: [PATCH 0/1] Expand/collapse in choose-tree

2012-10-01 Thread Thomas Adam
On 30 September 2012 23:50, Nicholas Marriott wrote: > Using space is a good idea but definitely don't want any help text > clutter. It would be nice to make ? key show all the key bindings for > modes when in that mode. Would need modes to nest though which might be > fiddly. Are you wanting me

Re: [PATCH 0/1] Expand/collapse in choose-tree

2012-09-30 Thread Nicholas Marriott
Using space is a good idea but definitely don't want any help text clutter. It would be nice to make ? key show all the key bindings for modes when in that mode. Would need modes to nest though which might be fiddly. On Sun, Sep 30, 2012 at 08:00:39PM +0200, Romain Francoise wrote: > Thomas Adam

Re: [PATCH 0/1] Expand/collapse in choose-tree

2012-09-30 Thread Romain Francoise
Thomas Adam writes: > This improves upon my original POC patch from the other day, to add in > support for expanding/collapsing sessions in choose-tree. Thanks, I like it. Two minor suggestions: - the arrow keys are too far to reach for me, using Space to expand or collapse the items would be

[PATCH 0/1] Expand/collapse in choose-tree

2012-09-26 Thread Thomas Adam
Hi, This improves upon my original POC patch from the other day, to add in support for expanding/collapsing sessions in choose-tree. Currently, the following is implemented through this new patch: * Starts off collapsed by default. * Adds +/- indicators to each session line depending on state. *