Re: [PATCH] Pass valid pointer to grid_string_cells or it segfaults

2013-03-06 Thread eugene everson
Understand, thanks for the explanation. On Wed, Mar 06, 2013 at 11:26:30AM +, Nicholas Marriott wrote: > On Wed, Mar 06, 2013 at 08:02:49PM +0900, eugene everson wrote: > > Hi Nicholas, > > > > First just quick want to say thanks first, switched yesterday to tmux and > > it's been so sweet. A

Re: [PATCH] Pass valid pointer to grid_string_cells or it segfaults

2013-03-06 Thread Nicholas Marriott
On Wed, Mar 06, 2013 at 08:02:49PM +0900, eugene everson wrote: > Hi Nicholas, > > First just quick want to say thanks first, switched yesterday to tmux and > it's been so sweet. And also love the source code. Thanks. > > About the patch, this is a bit nitpicking so if you're busy think you can >

Re: [PATCH] Pass valid pointer to grid_string_cells or it segfaults

2013-03-06 Thread eugene everson
Hi Nicholas, First just quick want to say thanks first, switched yesterday to tmux and it's been so sweet. And also love the source code. Thanks. About the patch, this is a bit nitpicking so if you're busy think you can leave this safely for later. - Later in grid_string_cells if(with_codes) is

Re: [PATCH] Pass valid pointer to grid_string_cells or it segfaults

2013-03-06 Thread Nicholas Marriott
Thanks - fixed by checking in grid_string_cells instead. On Wed, Mar 06, 2013 at 10:24:55AM +0900, eugene everson wrote: > Reproducible with :find-window .. (f) > --- > grid-view.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/grid-view.c b/grid-view.c > index

[PATCH] Pass valid pointer to grid_string_cells or it segfaults

2013-03-05 Thread eugene everson
Reproducible with :find-window .. (f) --- grid-view.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/grid-view.c b/grid-view.c index 7ef443a..c639b2a 100644 --- a/grid-view.c +++ b/grid-view.c @@ -229,10 +229,12 @@ grid_view_delete_cells(struct grid *gd, u_int px, u_int