Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-03-07 Thread Nicholas Marriott
cheers On Mon, Mar 07, 2011 at 11:46:44PM +, Nicholas Marriott wrote: > fair enough yeah, committed > > > On Thu, Mar 03, 2011 at 05:44:49PM -0800, Kevin Goodsell wrote: > > On Thu, Mar 3, 2011 at 12:08 PM, Nicholas Marriott > > wrote: > > > Oh hmm. Remind me why we need to do that? > > >

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-03-07 Thread Nicholas Marriott
fair enough yeah, committed On Thu, Mar 03, 2011 at 05:44:49PM -0800, Kevin Goodsell wrote: > On Thu, Mar 3, 2011 at 12:08 PM, Nicholas Marriott > wrote: > > Oh hmm. Remind me why we need to do that? > > > > What would the alternative be? There are a lot of escaping schemes > that could be used

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-03-03 Thread Kevin Goodsell
On Thu, Mar 3, 2011 at 12:08 PM, Nicholas Marriott wrote: > Oh hmm. Remind me why we need to do that? > What would the alternative be? There are a lot of escaping schemes that could be used, but surely some form of escaping is necessary if arbitrary strings are to be passed through (or an alterna

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-03-03 Thread Nicholas Marriott
Oh hmm. Remind me why we need to do that? On Thu, Mar 03, 2011 at 10:31:37AM -0800, Kevin Goodsell wrote: > On Thu, Mar 3, 2011 at 1:07 AM, Nicholas Marriott > wrote: > > This doesn't seem to work, I'm trying this in xterm: > > > > printf '\033Ptmux;\033]12;blue\007\033\\' > > > > Looks like it

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-03-03 Thread Kevin Goodsell
On Thu, Mar 3, 2011 at 1:07 AM, Nicholas Marriott wrote: > This doesn't seem to work, I'm trying this in xterm: > > printf '\033Ptmux;\033]12;blue\007\033\\' > > Looks like it is trimming out the second \033. I don't really > have time to investigate much further now, I guess you need a different

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-03-03 Thread Nicholas Marriott
This doesn't seem to work, I'm trying this in xterm: printf '\033Ptmux;\033]12;blue\007\033\\' Looks like it is trimming out the second \033. I don't really have time to investigate much further now, I guess you need a different state function to insert the keys after the escape (or a flag or som

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-02-15 Thread Kevin Goodsell
On Mon, Feb 14, 2011 at 12:19 PM, Nicholas Marriott wrote: > I haven't forgotten about this I've just been busy, sorry. > OK, good. Thanks for letting me know -- I was about ready to send a "hey what happened to this" email. I'll be patient. -Kevin --

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-02-14 Thread Nicholas Marriott
I haven't forgotten about this I've just been busy, sorry. On Sat, Jan 29, 2011 at 10:39:05AM -0800, Kevin Goodsell wrote: > On Fri, Jan 28, 2011 at 12:36 PM, Nicholas Marriott > wrote: > > input_dcs_dispatch should log the input string but otherwise this looks > > fine on a quick read. > > Her

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-01-29 Thread Kevin Goodsell
On Fri, Jan 28, 2011 at 12:36 PM, Nicholas Marriott wrote: > input_dcs_dispatch should log the input string but otherwise this looks > fine on a quick read. Here's an updated patch with logging of the string. No other changes. By the way, while testing I noticed that the logging in input_csi_dis

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-01-28 Thread Nicholas Marriott
logging nonprintable is fine we do it all over the place On Fri, Jan 28, 2011 at 01:28:30PM -0800, Kevin Goodsell wrote: > On Fri, Jan 28, 2011 at 12:36 PM, Nicholas Marriott > wrote: > > input_dcs_dispatch should log the input string but otherwise this looks > > fine on a quick read. > > > > T

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-01-28 Thread Kevin Goodsell
On Fri, Jan 28, 2011 at 12:36 PM, Nicholas Marriott wrote: > input_dcs_dispatch should log the input string but otherwise this looks > fine on a quick read. > This was something that occurred to me, but the string is likely to include non-printable characters. Should it be logged as-is in spite o

Re: [PATCH] Add support for passing control sequences to the underlying terminal

2011-01-28 Thread Nicholas Marriott
input_dcs_dispatch should log the input string but otherwise this looks fine on a quick read. I'm a bit tempted to say we should treat OSC and APC the same to be consistent but not sure... On Fri, Jan 28, 2011 at 09:47:00AM -0800, Kevin Goodsell wrote: > This patch allows applications to send co

[PATCH] Add support for passing control sequences to the underlying terminal

2011-01-28 Thread Kevin Goodsell
This patch allows applications to send control sequences to the underlying terminal by using DCS. It adds the dcs_escape state to the input state machine, allowing ESC characters in the dcs_handler state. Following an ESC, a backslash is interpreted as the end of the DCS string and any other charac