Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-24 Thread Balazs Kezes
On 2015-01-19 23:31 +0100, Thomas Egerer wrote: > Unfortunately the copy-line mode does not give this option. It > preselects the whole line from start to end (including \n in vi mode) > and copies it to a buffer. I actually did not know about this feature! It does sound quite nice and yes, I get

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-19 Thread Thomas Egerer
Hi Nicholas, *, On 01/18/2015 09:54 PM, Nicholas Marriott wrote: > We're not adding an option for every obscure little behaviour change, we > would quickly be coming down with options and there are already far too > many. Options are not free, they are a maintenance burden and a steeper > learning

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-19 Thread Thomas Egerer
Hi Balasz, *, On 01/18/2015 09:54 PM, Balazs Kezes wrote: > On 2015-01-18 01:50 +0100, Thomas Egerer wrote: >> the changes introduced in git-commit >>00ac1af Copy newline when at EOL in vi(1) mode, from Balazs Kezes. >> have been driving me up and down the wall during the last couple of >> day

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-19 Thread Thomas Egerer
On 01/18/2015 10:00 PM, Balazs Kezes wrote: > On 2015-01-18 20:54 +, Nicholas Marriott wrote: >> This is tricky for me because I don't care about vi mode, but the >> person who sent this change wanted it and yours is the only comment on >> it in 7 months, so I'm not inclined to revert it immedi

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-19 Thread Thomas Egerer
Hi Nicholas, On 01/18/2015 09:16 AM, Nicholas Marriott wrote: > Hi > > There is no way we are adding an option for this, sorry. Any explaination why? 'Sorry' really does not help me here. The newly introduced behavior makes the otherwise great tool less usable for the idea of being completely com

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-19 Thread Stroller
On Sun, 18 January 2015, at 12:50 am, Thomas Egerer wrote: > ... I often use the 'copy-line' command to copy command line > statements. When such a buffer is then pasted the statement is > immediately executed. I'm sorry if I'm not understanding exactly what you're doing, but it _sounds like_

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-18 Thread Balazs Kezes
On 2015-01-18 20:54 +, Nicholas Marriott wrote: > This is tricky for me because I don't care about vi mode, but the > person who sent this change wanted it and yours is the only comment on > it in 7 months, so I'm not inclined to revert it immediately. Perhaps > some other vi users will weigh i

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-18 Thread Nicholas Marriott
We're not adding an option for every obscure little behaviour change, we would quickly be coming down with options and there are already far too many. Options are not free, they are a maintenance burden and a steeper learning curve for new users. So, we pick one behaviour. For vi mode, generally t

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-18 Thread Balazs Kezes
On 2015-01-18 01:50 +0100, Thomas Egerer wrote: > the changes introduced in git-commit >00ac1af Copy newline when at EOL in vi(1) mode, from Balazs Kezes. > have been driving me up and down the wall during the last couple of > days. I often use the 'copy-line' command to copy command line > sta

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-18 Thread Nicholas Marriott
Hi There is no way we are adding an option for this, sorry. Does the current behaviour match vi(1)? On Sun, Jan 18, 2015 at 01:50:18AM +0100, Thomas Egerer wrote: > > Signed-off-by: Thomas Egerer > --- > Hello *, > > the changes introduced in git-commit >00ac1af Copy newline when at EOL

[PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-18 Thread Thomas Egerer
Signed-off-by: Thomas Egerer --- Hello *, the changes introduced in git-commit 00ac1af Copy newline when at EOL in vi(1) mode, from Balazs Kezes. have been driving me up and down the wall during the last couple of days. I often use the 'copy-line' command to copy command line statements. When