Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-19 Thread Thomas Egerer
ecause it breaks what Balasz's patch fixed. So I'm trying to convince you to compromise here: Any chance you/we could exclude copy-line from the vi-inherent 'copy-newline-at-EOL' policy? I'd happily try and hack the changes if they had any chance of getting it upstream.

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-19 Thread Thomas Egerer
Hi Balasz, *, On 01/18/2015 09:54 PM, Balazs Kezes wrote: > On 2015-01-18 01:50 +0100, Thomas Egerer wrote: >> the changes introduced in git-commit >>00ac1af Copy newline when at EOL in vi(1) mode, from Balazs Kezes. >> have been driving me up and down the wall duri

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-19 Thread Thomas Egerer
On 01/18/2015 10:00 PM, Balazs Kezes wrote: > On 2015-01-18 20:54 +, Nicholas Marriott wrote: >> This is tricky for me because I don't care about vi mode, but the >> person who sent this change wanted it and yours is the only comment on >> it in 7 months, so I'm not inclined to revert it immedi

Re: [PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-19 Thread Thomas Egerer
Hi Nicholas, On 01/18/2015 09:16 AM, Nicholas Marriott wrote: > Hi > > There is no way we are adding an option for this, sorry. Any explaination why? 'Sorry' really does not help me here. The newly introduced behavior makes the otherwise great tool less usable for the idea of being completely com

[PATCH] Add option to disable copying newline at EOL for vi(1) mode

2015-01-18 Thread Thomas Egerer
Signed-off-by: Thomas Egerer --- Hello *, the changes introduced in git-commit 00ac1af Copy newline when at EOL in vi(1) mode, from Balazs Kezes. have been driving me up and down the wall during the last couple of days. I often use the 'copy-line' command to copy command line