Re: patch for setting pane background color

2015-02-19 Thread J Raynor
I've attached a new patch. This patch: * Adds Thomas's fix for pane selection via the mouse * Gets rid of nflags in cmd_display_panes_exec * Fixes the usage of memcpy in window.c * Leaves tty_reset unchanged * Has the tty_cmd_* functions call tty_attributes instead of tty_reset * Includes u

Re: patch for setting pane background color

2015-02-19 Thread J Raynor
Sorry. I looked at your larger patch, but the brief summary of the other one (update window on mouse-select-pane) seemed unrelated, like it was for something else you were working on, so I didn't look at it. But I've seen it now, and I'll add it to the next patch. On Thu, Feb 19, 2015 at 3:36 P

Re: patch for setting pane background color

2015-02-19 Thread Thomas Adam
On Thu, Feb 19, 2015 at 12:21:37PM -0600, J Raynor wrote: > I checked back over the emails for my patch, but I don't see any > mention of mouse events. Was there a discussion off list? If so, > I'll need to know what else you've found wrong. I can't fix it if I > don't know about it. I mentione

Re: patch for setting pane background color

2015-02-19 Thread J Raynor
I checked back over the emails for my patch, but I don't see any mention of mouse events. Was there a discussion off list? If so, I'll need to know what else you've found wrong. I can't fix it if I don't know about it. > It's _still_ missing a fix in server-client. See the following: > > > dif

Re: patch for setting pane background color

2015-02-19 Thread Nicholas Marriott
screen_redraw_window implies status and borders, so can remove those. On Thu, Feb 19, 2015 at 08:27:57AM +, Thomas Adam wrote: > On Thu, Feb 19, 2015 at 01:49:14AM -0600, J Raynor wrote: > > I've attached a new patch. There are 2 new window options, > > window-style and window-active-style,

Re: patch for setting pane background color

2015-02-19 Thread Nicholas Marriott
This looks pretty good. tty_reset is not right. I've had another look and I don't think you need to change the function itself, just the tty_cmd_* calls. There are three reasons to call tty_reset: 1) It is called by, for example, tty_cmd_insertline, to set the colours and attributes to OUR pa

Re: patch for setting pane background color

2015-02-19 Thread Thomas Adam
On Thu, Feb 19, 2015 at 01:49:14AM -0600, J Raynor wrote: > I've attached a new patch. There are 2 new window options, > window-style and window-active-style, that allow you to set the > window's color and the window's active pane color. The display-panes > command can still be used to set an exp