Re: tmux hangs on aix

2014-09-22 Thread J Raynor
The patch compiles, but part of the change you made reintroduces the race condition. The parent process has to close the slave before closing the write pipe. -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analy

Re: tmux hangs on aix

2014-09-22 Thread Nicholas Marriott
Forgot to do git push sorry should be there now Original message From: J Raynor Date: 22/09/2014 19:19 (GMT+00:00) To: Nicholas Marriott Cc: tmux-users@lists.sourceforge.net Subject: Re: tmux hangs on aix > Applied with some trivial style nits, check it still builds pl

Re: tmux hangs on aix

2014-09-22 Thread J Raynor
> Applied with some trivial style nits, check it still builds please :-). I don't see any update in the git repository. How long after you apply a change does it take before showing up in git? -- Meet PCI DSS 3.0 Complia

Re: flock again

2014-09-22 Thread Dagobert Michelsen
Hi Nicholas, Am 22.09.2014 um 16:53 schrieb Dagobert Michelsen : > Am 22.09.2014 um 16:31 schrieb Nicholas Marriott > : >> Well, I don't have any Solaris boxes but it probably isn't too big a >> change - try this: >> >> diff --git a/compat.h b/compat.h >> index bf6e536..2e433a0 100644 >> --- a/c

Re: flock again

2014-09-22 Thread Dagobert Michelsen
Hi Nicholas, Am 22.09.2014 um 16:31 schrieb Nicholas Marriott : > Well, I don't have any Solaris boxes but it probably isn't too big a > change - try this: > > diff --git a/compat.h b/compat.h > index bf6e536..2e433a0 100644 > --- a/compat.h > +++ b/compat.h > @@ -176,6 +176,13 @@ typedef uint64_

Re: flock again

2014-09-22 Thread Nicholas Marriott
Well, I don't have any Solaris boxes but it probably isn't too big a change - try this: diff --git a/compat.h b/compat.h index bf6e536..2e433a0 100644 --- a/compat.h +++ b/compat.h @@ -176,6 +176,13 @@ typedef uint64_t u_int64_t; #define TTY_NAME_MAX 32 #endif +#ifndef HAVE_FLOCK +#define LOCK

Re: flock again

2014-09-22 Thread Dagobert Michelsen
Hi Nicholas, Am 11.08.2014 um 10:23 schrieb Nicholas Marriott : > From: Nicholas Marriott >> Yes it will have to be a stub, fcntl is useless too. > > I'd add a configure.ac test though and use it on any platform w/o flock not > just Solaris. As this hasn’t been done yet: are you waiting for a

Re: tmux hangs on aix

2014-09-22 Thread Nicholas Marriott
Applied with some trivial style nits, check it still builds please :-). Thanks! On Mon, Sep 22, 2014 at 01:07:16AM -0500, J Raynor wrote: > > I think you should probably loop for EINTR from read() but otherwise > > this looks fine to me. > > I've attached an updated patch. > diff --git a/compa