potential memory leak in window_copy_copy_selection

2014-02-13 Thread J Raynor
It looks like there's a potential memory leak in window_copy_copy_selection. This function calls window_copy_copy_buffer, which calls paste_replace. If paste_replace succeeds, it stores the data that was passed to it. But if paste_replace fails, such as when an invalid buffer index is specified,

Re: use "--" to mark start of command w/ neww etc to avoid quoting

2014-02-13 Thread J Raynor
> I reckon we always set PATH and yes pass it into the func. Behaviour will > only change if someone sets PATH in global or session environment > themselves. I've attached a new patch with the new PATH behavior, and the patch also fixes the 2 issues you noted with cmd_stringify_argv. tmux-dashda

Re: use "--" to mark start of command w/ neww etc to avoid quoting

2014-02-13 Thread Nicholas Marriott
I reckon we always set PATH and yes pass it into the func. Behaviour will only change if someone sets PATH in global or session environment themselves. Original message From: J Raynor Date: 13/02/2014 16:20 (GMT+00:00) To: Nicholas Marriott Cc: tmux-users@lists.sourceforg

Re: use "--" to mark start of command w/ neww etc to avoid quoting

2014-02-13 Thread J Raynor
> - If we are going to call execvp we should control PATH, I think we > should probably get it from the client if it's a command line client > else from the session environ. In any case you'll need to pass it in > from the caller as yet another argument. Tmux currently runs commands by calli

Re: How to know if tmux is running in UTF-8 mode?

2014-02-13 Thread João Cristóvão
Hi anatoly, Ctrl-b (or a) : Then type: show-options -w utf8 You can also tell tmux to run with utf support with the -u flag. Cheers, João 2014-02-10 20:02 GMT+00:00 anatoly techtonik : > I am getting question marks when I get non-English messages in my > irssi screen in PuTTY. I am certain t

Re: How to know if tmux is running in UTF-8 mode?

2014-02-13 Thread Nicholas Marriott
Two things Run tmux lsc and make sure all show (utf8) Check tmux showw -g|grep utf8 shows on. Original message From: anatoly techtonik Date: 10/02/2014 20:02 (GMT+00:00) To: tmux-users Subject: How to know if tmux is running in UTF-8 mode? I am getting question marks

Re: bell patches

2014-02-13 Thread Thomas Adam
On 12 February 2014 22:28, Filip Moc wrote: > Hi, > >> I'm not clear what this bit is supposed to fix, can you give an example? > > Problem is when visual-bell is off and bell-action is set to current > - tmux in this case behaves as if bell-action would be set to any. > Action and whether window

Re: bell patches

2014-02-13 Thread Filip Moc
Hi, > I'm not clear what this bit is supposed to fix, can you give an example? Problem is when visual-bell is off and bell-action is set to current - tmux in this case behaves as if bell-action would be set to any. Action and whether window is current must be checked before call of tty_bell(). O

How to know if tmux is running in UTF-8 mode?

2014-02-13 Thread anatoly techtonik
I am getting question marks when I get non-English messages in my irssi screen in PuTTY. I am certain that PuTTY uses UTF-8, but how can I check that tmux is in UTF-8 too to ensure that problem is with irssi? -- anatoly t. --

[PATCH] pipe-pane: Check for NULL client

2014-02-13 Thread Thomas Adam
When calling pipe-pane outside of a client, we cannot expect the status_replace() routines to happen to expand the given pipe-pane command since there's no context for them without a client. In doing that, we have to also protect the other callers of the format_() routines to not pass NULL values.