Re: Window size

2014-01-29 Thread J Raynor
> Take a look at this instead which a) uses a function like CSI, SM etc b) > don't increment m inside function arguments. This works fine. However, I noticed that just incrementing m may cause it to skip over bad input. For example, a winop of 3 is supposed to take 2 arguments. If someone enter

Re: [PATCH] remember focused window panes while changing focus

2014-01-29 Thread Suraj Kurapati
Sorry for the late reply. I totally missed this thread (again) in my inbox. These changes seem fine to me... whatever gets my patch accepted! ;) I re-used *wp instead of adding a new member because I wanted to minimize the amount of changes I made to the codebase. The less changes I make, the e

Re: Window size

2014-01-29 Thread Nicholas Marriott
Take a look at this instead which a) uses a function like CSI, SM etc b) don't increment m inside function arguments. Index: input.c === RCS file: /cvs/src/usr.bin/tmux/input.c,v retrieving revision 1.64 diff -u -p -r1.64 input.c ---

Re: Window size

2014-01-29 Thread J Raynor
> How about WINOPS instead of WMN? This matches xterm src and seems a bit > more readable. Otherwise looks good. Sure. I've attached an updated patch with WINOPS instead of WMN. diff --git a/input.c b/input.c index 259fad1..bc4f912 100644 --- a/input.c +++ b/input.c @@ -154,6 +154,7 @@ enum input

Re: Window size

2014-01-29 Thread Nicholas Marriott
How about WINOPS instead of WMN? This matches xterm src and seems a bit more readable. Otherwise looks good. On Wed, Jan 29, 2014 at 01:29:53AM -0600, J Raynor wrote: > Sorry, after I submitted the patch I realized it was incorrect. > Certain options take arguments and my patch didn't account for