Re: [PATCH] Don't send focus events to dead panes

2013-04-21 Thread Nicholas Marriott
Applied, thanks! On Sat, Apr 20, 2013 at 07:24:03PM +0200, Romain Francoise wrote: > When `remain-on-exit' is set and the terminal supports focus reporting, > tmux 1.8 sometimes crashes because it uses the bufferevent of a dead pane > in server_client_check_focus(). > > There's already a check i

Re: Integration of patches for Solaris

2013-04-21 Thread Dagobert Michelsen
Hi John, Am 21.04.2013 um 17:26 schrieb John Long : > On Sun, Apr 21, 2013 at 05:16:09PM +0200, Dagobert Michelsen wrote: >> Am 21.04.2013 um 12:48 schrieb John Long: >> All patches are against HEAD: >> https://sourceforge.net/p/tmux/tmux-code/ci/master/tree/ > > Ok, downloaded the tarball… I s

Re: FAO Thomas -> code more carefully!

2013-04-21 Thread Jason Timrod
Hi, Well, I think I would like to hear from NicM (or the person in charge). The choose-tree -u fix I think should not go in to tmux. The more code ive seen from you, the worse things get because theres been lots of fixes on top of your own code from yourself and others. It shows poor programmi

Re: FAO Thomas -> code more carefully!

2013-04-21 Thread Thomas Adam
Hello, On Sun, Apr 21, 2013 at 05:02:50AM -0700, Jason Timrod wrote: > Hi, > > Ive enjoyed using the devel version of tmux for ages - but lately ive had > problems with it: I have to say that I am very surprised by this email, and am even more puzzled as to why you feel that I am solely respons

Re: Integration of patches for Solaris

2013-04-21 Thread John Long
On Sun, Apr 21, 2013 at 05:16:09PM +0200, Dagobert Michelsen wrote: > Hi John, > > Am 21.04.2013 um 12:48 schrieb John Long: > All patches are against HEAD: > https://sourceforge.net/p/tmux/tmux-code/ci/master/tree/ Ok, downloaded the tarball... > > Make sure to call autogen.sh before buildin

Re: Integration of patches for Solaris

2013-04-21 Thread Dagobert Michelsen
Hi John, Am 21.04.2013 um 12:48 schrieb John Long: > I tried applying these against 1.8 and the first patch doesn't apply. I > tried to apply it manually (looks pretty simple) but the code doesn't build, > it had various errors (some includes weren't picked up) and the timersub > function wasn't f

Re: Integration of patches for Solaris

2013-04-21 Thread John Long
Thanks, will you please post a note here when they're in so I can download the lastest tarball and try again? /jl On Sun, Apr 21, 2013 at 01:22:06PM +0100, Nicholas Marriott wrote: > BTW these changes look fine to me and I will apply them when I have a > bit more time, thanks > > > > On Sun, A

Re: Integration of patches for Solaris

2013-04-21 Thread Nicholas Marriott
BTW these changes look fine to me and I will apply them when I have a bit more time, thanks On Sun, Apr 21, 2013 at 10:30:41AM +0200, Dagobert Michelsen wrote: > Hi John, > > Am 20.04.2013 um 21:40 schrieb John Long : > > On Fri, Apr 19, 2013 at 04:14:16PM +0200, Dagobert Michelsen wrote: > >>

FAO Thomas -> code more carefully!

2013-04-21 Thread Jason Timrod
Hi, Ive enjoyed using the devel version of tmux for ages - but lately ive had problems with it: Why is there changes to choose-tree to fix -u? Do we need this? I do not think we do - I like the way it works now. Why do we need to support hooks? These have lots of huge changes - and most of the

[PATCH 1/1] choose-tree: Fix current selection when using '-u'

2013-04-21 Thread Thomas Adam
When choose-tree learnt the '-u; option to render the tree fully expanded, it didn't then reset the current selection in the expanded tree to be that of the current session and window. This introduces a new function window_choose_set_current() which sets the intended position of the selection when

Re: Integration of patches for Solaris

2013-04-21 Thread John Long
Hi Dagobert, I tried applying these against 1.8 and the first patch doesn't apply. I tried to apply it manually (looks pretty simple) but the code doesn't build, it had various errors (some includes weren't picked up) and the timersub function wasn't found. I did a bunch of hand updates but then t

Re: Integration of patches for Solaris

2013-04-21 Thread John Long
Hi Dagobert, Thanks alot, I'll get back to you in asap. I want to test this on the latest stable version on Intel and SPARC. /jl On Sun, Apr 21, 2013 at 10:30:41AM +0200, Dagobert Michelsen wrote: > Hi John, > > Am 20.04.2013 um 21:40 schrieb John Long : > > On Fri, Apr 19, 2013 at 04:14:16PM +

Re: Integration of patches for Solaris

2013-04-21 Thread Dagobert Michelsen
Hi John, Am 20.04.2013 um 21:40 schrieb John Long : > On Fri, Apr 19, 2013 at 04:14:16PM +0200, Dagobert Michelsen wrote: >> I rewrote the patch to use contrib/ substitutions for cfmakeraw and use >> lockf: >> https://sourceforge.net/p/tmux/tmux-code/merge-requests/3/ > > Thank you. Is there so