Re: [PATCH 0/1] Hook support: proof-of-concept

2012-11-19 Thread Thomas Adam
On Mon, Nov 19, 2012 at 10:32:00AM +, Nicholas Marriott wrote: > Hi > > Not sure I follow, can you show me your code? See "hook-context.diff" attached. Please ignore any whitespace errors, as well as any logging since I'm still in the throws of messing with things. You should look (in that

Re: [PATCH 5/6] Add option 'choose-tree-collapse'.

2012-11-19 Thread Nicholas Marriott
Please make this a flag to choose-tree, not a tmux option. Also don't forget the man page. Thanks On Sat, Nov 17, 2012 at 11:42:07PM +0530, Raghavendra D Prabhu wrote: > choose-tree, by default, folds/collapses the window tree grouped by session. > This adds an option to make it configurable. >

Re: [PATCH 2/6] If select-window is invoked on same window as current, switch to previous window.

2012-11-19 Thread Nicholas Marriott
I don't like this behaviour at all, sorry. If you really want it make it a flag to select-window. Also don't goto the inside of if statements! On Sat, Nov 17, 2012 at 11:42:04PM +0530, Raghavendra D Prabhu wrote: > This is to simulate a behavior similar to what is found in window managers > whe

Re: [PATCH 1/1] Be more explicit about config reading in man page

2012-11-19 Thread Nicholas Marriott
Yes, applied with some tweaks, thanks. On Thu, Nov 15, 2012 at 11:50:34PM +, Thomas Adam wrote: > It's probably worth mentioning in the decription for the "-f" flag that the > config file is read only at server start-up, and that any other config files > which need loading can use the source-f

Re: [PATCH 1/2] Aggregate config errors from source-file commands

2012-11-19 Thread Nicholas Marriott
This breaks the case where I source a bad file from the command prompt, for example: echo 'set -g abc' >~/.tmux.conf tmux new q C-b : source ~/.tmux.conf I guess you just don't reset the state after displaying it. I've applied your other diff to add show_cfg_causes. Cheers On Thu, Nov 15, 201

Re: Binding C-\;

2012-11-19 Thread Nicholas Marriott
Hi C-; it doesn't generate anything different from ;. You can use M-; but not C-;. On Sun, Nov 18, 2012 at 12:50:55PM -0700, Matthew Monaco wrote: > On 11/18/2012 12:03 PM, Thomas Adam wrote: > > Hi, > > > > On 18 November 2012 18:28, Matthew Monaco wrote: > >> Hello, > >> > >> I noticed that

Re: [PATCH 0/1] Hook support: proof-of-concept

2012-11-19 Thread Nicholas Marriott
Hi Not sure I follow, can you show me your code? I think check() was meant for parse time so that eg bind-key could reject stuff when a key was bound rather when it was pressed, but since it is hardly used I'm fine with removing it. Note that bind/unbind use it as well as new-session. On Mon, N