Re: Default window/session templates

2012-08-10 Thread Nicholas Marriott
Yes I would like less information mostly I think. On Sat, Jul 21, 2012 at 07:19:02PM +0100, Thomas Adam wrote: > Hi, > > Something on my own TODO list which I'm thinking has to happen sooner rather > than later is to take a look at the default session/window templates. > > Now that we have the

Re: [PATCH V2 0/7] Choose-mode: winlinks colours, numeric-key prefixes

2012-08-10 Thread Nicholas Marriott
Sorry thought this was a separate change not a new version - DOH. Can you redo this so it is on top of V1 now? On Sat, Jul 21, 2012 at 07:15:23PM +0100, Thomas Adam wrote: > Hi, > > V2 of this patch series gets rid of that stupid items->pos patch in V1, and > instead uses #{line} to denote the

Re: [PATCH 1/1] Fix return type of choose-tree-exec()

2012-08-10 Thread Nicholas Marriott
Applied, htanks. On Fri, Jul 20, 2012 at 02:21:28PM +0100, Thomas Adam wrote: > Whilst it's technically correct that the return type of the cmd-* commands > is an int, it's still part of an enum field, and we already mark the other > commands like this. So do the same for choose-tree. > --- > tr

Re: [PATCH 4/6] Add pos item to denote position in choose data

2012-08-10 Thread Nicholas Marriott
I like it. Applied with one change to make the indexes line up. Thanks! On Sun, Jul 15, 2012 at 12:31:08PM +0100, Thomas Adam wrote: > So that entries as listed in choose-* mode commands can be selected with a > numeric prefix, ensure we know which prefix that is, by maintaining the > index of th

Re: [PATCH 6/6] Introduce window_mode_attrs()

2012-08-10 Thread Nicholas Marriott
n/m I see it now in the other diffs. On Sat, Aug 11, 2012 at 07:03:55AM +0100, Nicholas Marriott wrote: > Hi > > Sorry for delay. > > Do you need this for something else, not sure it saves enough code to be > worth it? > > > On Sun, Jul 15, 2012 at 12:31:10PM +0100, Thomas Adam wrote: > > Cre

Re: [PATCH 2/6] Render winlink alerts in choose-mode

2012-08-10 Thread Nicholas Marriott
Hi This is a nice idea but by default the alert colour is inverted and it looks very odd and confusing in the menu. Perhaps we should just make entries with an alert bold and not use the config options for the menu? Like this: Index: tmux.h ===

Re: [PATCH 6/6] Introduce window_mode_attrs()

2012-08-10 Thread Nicholas Marriott
Hi Sorry for delay. Do you need this for something else, not sure it saves enough code to be worth it? On Sun, Jul 15, 2012 at 12:31:10PM +0100, Thomas Adam wrote: > Create a function for setting a given grid_cell to the mode-* values, and > use it. > --- > trunk/tmux.h|1 + > trun

Re: [PATCH] add missing entries in the manual

2012-08-10 Thread Nicholas Marriott
Applied, thanks. On Sun, Jul 15, 2012 at 01:06:05PM +0200, Samuel Le Thiec wrote: > > Hello again, > > Since it looked okay, here is an other minor patch adding a few missing > entries in the manual. > > I'm not sure about the description for history_{bytes,limit}, feel free > to edit. > > Th