Re: Few questions about tlf code

2023-07-10 Thread Drew Arnett
Another vote for 80 columns. I like to run tlf in an 80x25 or 80x24 console/monitor. If I want to edit on the same platform... Tabs vs spaces is always an interesting question. I guess so long as the tabs are all meant to be 8 char (or 4 or whatever the convention is for the project). Best reg

Re: Few questions about tlf code

2023-07-06 Thread Ervin Hegedüs
Hi Marcin, On Thu, Jul 06, 2023 at 11:00:51AM +, Marcin SP6MI wrote: > I've got two additional question regarding astyle. Why tabs not spaces? I don't know... Perhaps... just... because :) > And why line lenght is set to 80 characters, even when all modern editors > (even vim and emacs) su

Re: Few questions about tlf code

2023-07-06 Thread Marcin SP6MI
Hi, thank you for that link do pull request. Interesting. Now I know how to unify my codig style to existing one in tlf :). I've got two additional question regarding astyle. Why tabs not spaces? And why line lenght is set to 80 characters, even when all modern editors (even vim and emacs) supp

Re: Few questions about tlf code

2023-07-06 Thread Ervin Hegedüs
hi guys, On Wed, Jul 05, 2023 at 05:28:23PM +, Marcin SP6MI wrote: > About formating, as example almost all if/else blocks in parse_logcfg.c file > (maybe rules for that astylerc needs to be fixed). yes, unfortunately using of astyle has became less important, but there was an intention: ht

Re: Few questions about tlf code

2023-07-05 Thread Bill Lederer
One thing I noticed is that tabs are used for indention, at least in some cases. If your editor is set up to have an indent level of four spaces, that can cause the appearance to be off. On Wed, Jul 5, 2023 at 12:29 PM Marcin SP6MI wrote: > Hi, > THank you. Good to know that this list is outda

Re: Few questions about tlf code

2023-07-05 Thread Marcin SP6MI
Hi, ok strange. I've checked twice (I'm using vscode) and in most files there is a mess with indentation in fresh cloned repository, but looking to github pages and code everything looks correct. Have to check why during clone it gets messed up or why vscode is not showing it correctly. Br Marc

Re: Few questions about tlf code

2023-07-05 Thread Marcin SP6MI
Hi, THank you. Good to know that this list is outdated. About formating, as example almost all if/else blocks in parse_logcfg.c file (maybe rules for that astylerc needs to be fixed). Thanks Br Marcin SP6MI Wysłano z bezpiecznej poczty e-mail Proton Mail. --- Original Message --- śr

Re: Few questions about tlf code

2023-07-05 Thread Csahok Zoltan
Hi Marcin, The ToDo list is somewhat outdated, qso data has been already collected into qso_t structure. Other items could be also done in the meantime. Regarding code formatting we use astyle with the 'astylerc' file that is provided in the tools directory. Ideally after all changes code should