Re: Moving telnet/telnetd from base to pkgsrc

2018-12-13 Thread Sevan Janiyan
On 13/12/2018 22:50, co...@sdf.org wrote: > telnet: > 1. terrible code, with many abstraction violations > 2. something people expect to talk to their legacy machines, which > nobody but them has access to. > 3. common use case is served by netcat, already in base. > 4. too much superfluous functio

Fix for '$' not being printed for blank lines when invoked with -se

2016-06-02 Thread Sevan Janiyan
Hello, Obtained from OpenBSD r1.13 of src/bin/cat/cat.c. When 'cat -se' is used, a '$' is not printed for blank lines, attached diff fixes that. Ok to commit? Sevan Index: cat.c === RCS file: /cvsroot/src/bin/cat/cat.c,v retrieving

Re: Fix for '$' not being printed for blank lines when invoked with -se

2016-06-03 Thread Sevan Janiyan
On 03/06/2016 17:14, Christos Zoulas wrote: > Ok, but can you add some unit-tests (atf) for it please? Sure, not looked at ATF before that's cool, will check it out :) Sevan

Re: Fix for '$' not being printed for blank lines when invoked with -se

2016-06-15 Thread Sevan Janiyan
On 03/06/2016 17:21, Sevan Janiyan wrote: > > > On 03/06/2016 17:14, Christos Zoulas wrote: >> Ok, but can you add some unit-tests (atf) for it please? > > Sure, not looked at ATF before that's cool, will check it out :) I raised a PR (bin/51250) to track the

Calling setlocale() in utilities

2016-09-19 Thread Sevan Janiyan
Hello, I was wondering if there was any reason not to add a call to setlocale in the utilities we ship in base (I'm thinking of what's in /sbin and /bin if applicable)? The intent is to get localised messages for the generic errors on the system and that paves the way for localising the remaining

Re: adding stuff to the base installation to make user experience better

2017-07-06 Thread Sevan Janiyan
On 06/07/2017 16:52, Joerg Sonnenberger wrote: > On Thu, Jul 06, 2017 at 11:23:09AM -0400, Christos Zoulas wrote: >> 1. A text browser in base. "lynx" or "links" come to mind, I don't >>mind which, both are GPL2. > No. Seriously, no. > Could we ensure it's one of the available packages on the

Support $MANPAGER in man(1)

2017-09-10 Thread Sevan Janiyan
Hello, Attached patch adds support for $MANPAGER environment variable. It's currently lacking the documentation patch, but I thought I'd post the change for code first in case the change is rejected. Thoughts? / ok to commit with man page update? Sevan Index: usr.bin/man/man.c ==

Including tools from DTrace toolkit in base

2017-09-14 Thread Sevan Janiyan
Hello, We ship NetBSD builds with DTrace enabled by default on the ports which support it. Any objection to including some of the very useful tools from the DTrace toolkit which we have in src/external/cddl/dtracetoolkit/dist as part of base as standard? Not only are they very useful system tools

Re: Including tools from DTrace toolkit in base

2017-09-14 Thread Sevan Janiyan
On 09/14/17 21:26, Sevan Janiyan wrote: > errinfo - report on syscall failures and print errno error messages. Apologies, his is actually a perl script so perhaps should be omitted. Sevan

Re: Including tools from DTrace toolkit in base

2017-09-15 Thread Sevan Janiyan
Following patch adds a new mk variable MKDTRACETOOLKIT & Makefile to src/external/cddl/dtracetoolkit to install dtruss, execsnoop, opensnoop & procsystime. http://www.netbsd.org/~sevan/patch-mkdtracetoolkit-mk2.txt Release build tested for amd64 & evbarm (ports with DTrace support) and sparc64 (po

Re: SYS_sbrk removal proposal

2017-12-19 Thread Sevan Janiyan
Hello, On 12/19/17 11:51, Anders Magnusson wrote: > Sounds good :-) > > Just a note here: > > about 15-20 years ago I did a test by removing the brk(2) syscall and > replacing its use > in malloc() by mmap(), and also add a libc wrapper for brk() that > mmap'ed MAXDSIZ/2 if ever called (as a fal

unix(3lua)

2018-05-17 Thread Sevan Janiyan
Hello, There is a unixlua[1] module which is a Lua binding for some the functions in our C libraries in base as well as system calls. The code base is small and doesn't have any tentacles (a hand full of C files, excluding headers), It's licensed under a 3 clause style BSD license and written by mb

Re: unix(3lua)

2018-05-17 Thread Sevan Janiyan
Oops, adding others in > On 17 May 2018, at 13:15, Sevan Janiyan wrote: > > > >> On 17 May 2018, at 13:02, Martin Husemann wrote: >> >> Is there any reason to import it? Why not pkgsrc? > > Because the functionality is there in base already, it's

Re: unix(3lua)

2018-05-19 Thread Sevan Janiyan
On 19/05/2018 11:36, Alexander Nasonov wrote: > The main page of the repository says it's incomplete. "This module does not aim to be complete, it merely contains functions that I needed at some point of time" > Does anyone plan to make it complete or near complete? I was thinking along that lin

Re: unix(3lua)

2018-05-19 Thread Sevan Janiyan
Hi Marc, On 17/05/2018 14:48, Marc Balmer wrote: > If the license (3-clause) is of concern, it can be changed to > whatever is preferred. That's great. Is it possible to switch to the 2-clause license as per https://www.netbsd.org/about/redistribution.html#default Your call if you want to switch

missing-prototypes enabled in bsd.sys.mk

2018-05-27 Thread Sevan Janiyan
Hello, When building Lua modules bsd.sys.mk gets included in bsd.lua.mk. In bsd.sys.mk -Wmissing-prototypes is enabled via CFLAGS. This forces the declaration of prototypes where it would not be a show stopper if it wasn't, for example in this case, a Lua module where the function is not called any

Re: missing-prototypes enabled in bsd.sys.mk

2018-05-27 Thread Sevan Janiyan
On 05/27/18 19:07, Christos Zoulas wrote: > This will warn; you either want to make foo() static, or you want to > have a prototype declaration in scope from a header file which means > that the function can be used from outside the file scope. ok, with the combination of other CFLAGS, warning a