Re: dirname(3) used on its own results?

2018-09-26 Thread maya
On Tue, Sep 25, 2018 at 04:32:03PM +1000, Simon Burge wrote: > Should you be allowed to call dirname(3) on the results of a previous > dirname(3) call? This is about minidlna, right? if it works, please feel free to add SSP_SUPPORTED= no to the makefile. it's a hack, but it'll give us the ability

Re: dirname(3) used on its own results?

2018-09-26 Thread Simon Burge
m...@netbsd.org wrote: > On Tue, Sep 25, 2018 at 04:32:03PM +1000, Simon Burge wrote: > > Should you be allowed to call dirname(3) on the results of a previous > > dirname(3) call? > > This is about minidlna, right? Yes, minidlna. > if it works, please feel free to add > SSP_SUPPORTED= no > to t

Re: dirname(3) used on its own results?

2018-09-26 Thread Christos Zoulas
In article <20180926124258.ga14...@homeworld.netbsd.org>, wrote: >On Tue, Sep 25, 2018 at 04:32:03PM +1000, Simon Burge wrote: >> Should you be allowed to call dirname(3) on the results of a previous >> dirname(3) call? > >This is about minidlna, right? if it works, please feel free to add >SSP_S

Re: dirname(3) used on its own results?

2018-09-26 Thread Robert Elz
Date:Wed, 26 Sep 2018 16:42:27 + (UTC) From:chris...@astron.com (Christos Zoulas) Message-ID: | Well, it will return the wrong results... so might as well change the | memcpy to memmove? No? That would certainly not do any harm, but it would still be better t

Re: dirname(3) used on its own results?

2018-09-26 Thread Robert Elz
Date:Wed, 26 Sep 2018 16:42:27 + (UTC) From:chris...@astron.com (Christos Zoulas) Message-ID: | Well, it will return the wrong results... so might as well change the | memcpy to memmove? No? The results would not have been wrong - this was purely a SSP detect