Re: signed overflow in atan2

2018-03-07 Thread Robert Elz
Date:Wed, 7 Mar 2018 14:00:44 +0100 From:Joerg Sonnenberger Message-ID: <20180307130044.gb24...@britannica.bec.de> | This is a transformation typically done already. I thought it might be with modern compilers - but it probably was not when atan2() was originally

Re: signed overflow in atan2

2018-03-07 Thread Christos Zoulas
In article , Eitan Adler wrote: >Hi all, > >I'd like to commit the patch below. Does anyone have concerns with it? > >Previous discussion: >https://lists.freebsd.org/pipermail/freebsd-numerics/2018-February/thread.html >https://marc.info/?l=openbsd-tech&m=151859583112854&w=2 > >Original submissio

Re: signed overflow in atan2

2018-03-07 Thread Joerg Sonnenberger
On Wed, Mar 07, 2018 at 05:56:21PM +0700, Robert Elz wrote: > Date:Wed, 7 Mar 2018 00:33:04 -0800 > From:Eitan Adler > Message-ID: > > >| I'd like to commit the patch below. Does anyone have concerns with it? > > The change looks fine technically, but it would

Re: signed overflow in atan2

2018-03-07 Thread Robert Elz
Date:Wed, 7 Mar 2018 00:33:04 -0800 From:Eitan Adler Message-ID: | I'd like to commit the patch below. Does anyone have concerns with it? The change looks fine technically, but it would be good to see some benchmark results before committing it - particularly fo

Re: signed overflow in atan2

2018-03-07 Thread Martin Husemann
On Wed, Mar 07, 2018 at 12:33:04AM -0800, Eitan Adler wrote: > performed in a somewhat more complicated way than it need be. Change > it to not be quite so cute, rather directly comparing the high/low > bits of x to the specific IEEE-754 bit pattern that encodes 1.0. Looks good to me. Martin

signed overflow in atan2

2018-03-07 Thread Eitan Adler
Hi all, I'd like to commit the patch below. Does anyone have concerns with it? Previous discussion: https://lists.freebsd.org/pipermail/freebsd-numerics/2018-February/thread.html https://marc.info/?l=openbsd-tech&m=151859583112854&w=2 Original submission: https://github.com/freebsd/freebsd/pull/