Re: namespace pollution by curses

2019-03-13 Thread Rin Okuyama
Rin Okuyama" Sent: Tue, 12 Mar 2019 13:25:13 +0300 Subject: Re: namespace pollution by curses On Tue, Mar 12, 2019 at 11:41:39 +1030, Brett Lymn wrote: > I am happy with either the rename of the static definition or > including the state variable in _cur

Re: namespace pollution by curses

2019-03-12 Thread Brett Lymn
es is allowed for but  I have never tested it and I wouldn't be surprised if it failed spectacularly. - Original Message - From: "Valery Ushakov" To: Cc:"Brett Lymn" , "Rin Okuyama" Sent:Tue, 12 Mar 2019 13:25:13 +0300 Subject:Re: namespace pollution by c

Re: namespace pollution by curses

2019-03-12 Thread Brett Lymn
Cc:"Brett Lymn" , "Rin Okuyama" Sent:Tue, 12 Mar 2019 13:25:13 +0300 Subject:Re: namespace pollution by curses On Tue, Mar 12, 2019 at 11:41:39 +1030, Brett Lymn wrote: > I am happy with either the rename of the static definition or > including the state variab

Re: namespace pollution by curses

2019-03-12 Thread Valery Ushakov
On Tue, Mar 12, 2019 at 15:21:49 -, Christos Zoulas wrote: > In article <20190312134722.ga1...@netbsd.org>, > David Holland wrote: > >On Tue, Mar 12, 2019 at 01:25:13PM +0300, Valery Ushakov wrote: > > > Admittedly, I'm not sure about the usage. E.g. in wscons case you can > > > press a mod

Re: namespace pollution by curses

2019-03-12 Thread Christos Zoulas
In article <20190312134722.ga1...@netbsd.org>, David Holland wrote: >On Tue, Mar 12, 2019 at 01:25:13PM +0300, Valery Ushakov wrote: > > Admittedly, I'm not sure about the usage. E.g. in wscons case you can > > press a modifier on one keyboard and the key on another and it should > > work. But

Re: namespace pollution by curses

2019-03-12 Thread David Holland
On Tue, Mar 12, 2019 at 01:25:13PM +0300, Valery Ushakov wrote: > Admittedly, I'm not sure about the usage. E.g. in wscons case you can > press a modifier on one keyboard and the key on another and it should > work. But in case of curses, do the users really expect to be able to > input the b

Re: namespace pollution by curses

2019-03-12 Thread Valery Ushakov
On Tue, Mar 12, 2019 at 11:41:39 +1030, Brett Lymn wrote: > I am happy with either the rename of the static definition or > including the state variable in _cursesi_screen which already holds > the tty information anyway.  Mind you, if you put the state variable > into _cursesi_screen then you may

Re: namespace pollution by curses

2019-03-12 Thread Rin Okuyama
On 2019/03/12 10:11, Brett Lymn wrote: (sorry for the top post...) I am happy with either the rename of the static definition or including the state variable in _cursesi_screen which already holds the tty information anyway.  Mind you, if you put the state variable into _cursesi_screen then yo

Re: namespace pollution by curses

2019-03-11 Thread Brett Lymn
! - Original Message - From: "Rin Okuyama" To:"Roy Marples" , "Martin Husemann" Cc:, "Ruibiao Qiu" , "NetBSD Discussion List User-Level Technical" , "Christos Zoulas" , "Valery Ushakov" Sent:Tue, 12 Mar 2019 06:55:48 +0900 Subjec

Re: namespace pollution by curses

2019-03-11 Thread Rin Okuyama
On 2019/03/11 22:08, Roy Marples wrote: On 11/03/2019 06:21, Martin Husemann wrote: On Mon, Mar 11, 2019 at 02:01:44PM +0900, Rin Okuyama wrote: (3) Put "state" struct __window (suggested by uwe) Not __window _cursesi_screen which is __screen. Oops, yes. I prefer this one too. I pr

Re: namespace pollution by curses

2019-03-11 Thread Roy Marples
On 11/03/2019 06:21, Martin Husemann wrote: On Mon, Mar 11, 2019 at 02:01:44PM +0900, Rin Okuyama wrote: (3) Put "state" struct __window (suggested by uwe) Not __window _cursesi_screen which is __screen. I prefer this one too. I prefer this also. Roy

Re: namespace pollution by curses

2019-03-10 Thread Martin Husemann
On Mon, Mar 11, 2019 at 02:01:44PM +0900, Rin Okuyama wrote: > (3) Put "state" struct __window (suggested by uwe) I prefer this one too. Martin

Re: namespace pollution by curses

2019-03-10 Thread Rin Okuyama
On 2019/03/09 1:12, Ruibiao Qiu wrote: On Fri, Mar 8, 2019 at 7:36 AM Rin Okuyama mailto:rokuyama...@gmail.com>> wrote: On 2019/03/08 22:53, Martin Husemann wrote: > On Fri, Mar 08, 2019 at 10:41:51PM +0900, Rin Okuyama wrote: > >> I've found that this is because curses uses a

Re: namespace pollution by curses

2019-03-08 Thread Ruibiao Qiu
On Fri, Mar 8, 2019 at 7:36 AM Rin Okuyama wrote: > On 2019/03/08 22:53, Martin Husemann wrote: > > On Fri, Mar 08, 2019 at 10:41:51PM +0900, Rin Okuyama wrote: > > > >> I've found that this is because curses uses a global variable "state": > >> https://nxr.netbsd.org/xref/src/lib/libcurses/getch

Re: namespace pollution by curses

2019-03-08 Thread Valery Ushakov
Rin Okuyama wrote: > I would like to propose renaming "state" into "_cursesi_state": > http://www.netbsd.org/~rin/curses_state_20190308.patch > > Can I commit the patch? In that case, should I bump libcurses minor? > (That is, no matter to pull-up if minor version is bumped?) I wonder if state

Re: namespace pollution by curses

2019-03-08 Thread Christos Zoulas
In article <20190308135342.ga17...@mail.duskware.de>, Martin Husemann wrote: >On Fri, Mar 08, 2019 at 10:41:51PM +0900, Rin Okuyama wrote: > >> I've found that this is because curses uses a global variable "state": >> https://nxr.netbsd.org/xref/src/lib/libcurses/getch.c#50 >> https://nxr.netbsd.

Re: namespace pollution by curses

2019-03-08 Thread Rin Okuyama
On 2019/03/08 22:53, Martin Husemann wrote: On Fri, Mar 08, 2019 at 10:41:51PM +0900, Rin Okuyama wrote: I've found that this is because curses uses a global variable "state": https://nxr.netbsd.org/xref/src/lib/libcurses/getch.c#50 https://nxr.netbsd.org/xref/src/lib/libcurses/get_wch.c#52 C

Re: namespace pollution by curses

2019-03-08 Thread Martin Husemann
On Fri, Mar 08, 2019 at 10:41:51PM +0900, Rin Okuyama wrote: > I've found that this is because curses uses a global variable "state": > https://nxr.netbsd.org/xref/src/lib/libcurses/getch.c#50 > https://nxr.netbsd.org/xref/src/lib/libcurses/get_wch.c#52 Can both variants of inkey() co-exist? I wo

namespace pollution by curses

2019-03-08 Thread Rin Okuyama
Hi, pkgsrc/textproc/aspell crashes when linked to our curses (pkg/44005): http://gnats.netbsd.org/44005 I've found that this is because curses uses a global variable "state": https://nxr.netbsd.org/xref/src/lib/libcurses/getch.c#50 https://nxr.netbsd.org/xref/src/lib/libcurses/get_wch.c#52 If a