Re: etiquette for new failing test cases, followed by fix

2024-09-19 Thread Roland Illig
Am 19.09.2024 um 15:20 schrieb Greg Troxel: > We currently have no remquo test. I've written one, stealing from > tests/lib/libm/t_sin, and it shows some failing output. When I'm in such a situation, I usually do a two-commit approach: The first commit demonstrates the buggy state by having a te

Re: etiquette for new failing test cases, followed by fix

2024-09-19 Thread Martin Husemann
On Thu, Sep 19, 2024 at 09:20:42AM -0400, Greg Troxel wrote: > Is this reasonable? It will show an increased failing test for a bit, > but the test really does fail, and my impression is that the xfail > scheme is about keeping known-failing not-getting-fixed tests from > obscuring "we just had a

etiquette for new failing test cases, followed by fix

2024-09-19 Thread Greg Troxel
I have found a serious bug in reqmuo(3), and a fix in FreeBSD, validated by regression tests in proj and a hand-written test. The problem exists in current and 10, and surely in 9 but I haven't checked. We currently have no remquo test. I've written one, stealing from tests/lib/libm/t_sin, and i