Re: style(5) proposal: forbid extern in .c

2023-03-15 Thread Robert Elz
Date:Thu, 16 Mar 2023 05:21:47 +1100 From:matthew green Message-ID: <6173.1678904...@splode.eterna.com.au> | doing this should never be more than a quick hack | and not in the commited treed. It probably also needs to exclude machine generated code, eg: yacc prod

re: style(5) proposal: forbid extern in .c

2023-03-15 Thread matthew green
> Pretty simple. Any objections? yes please. doing this should never be more than a quick hack and not in the commited treed. thanks. .mrg.

Re: style(5) proposal: forbid extern in .c

2023-03-15 Thread Valery Ushakov
On Wed, Mar 15, 2023 at 11:23:05 +, Taylor R Campbell wrote: > Proposal: Forbid extern declarations in .c files. > > extern declarations in .c files invite easily avoided bugs where the > definition and use have mismatched types, because the compiler doesn't > have an opportunity to check the

Re: style(5) proposal: forbid extern in .c

2023-03-15 Thread Mouse
> [...] I wonder how we can resolve this case: > extern struct netif_stats le_stats[]; > > static struct netif_dif le_ifs[] = { > /*dif_unitdif_nseldif_stats dif_private */ > { 0, NLE0CONF, &le_stats[0], le0conf,}, > }; > #define

Re: style(5) proposal: forbid extern in .c

2023-03-15 Thread Taylor R Campbell
> Date: Thu, 16 Mar 2023 01:58:48 +0900 > From: Izumi Tsutsui > > > Proposal: Forbid extern declarations in .c files. > : > > Pretty simple. Any objections? > > No objection, but I wonder how we can resolve this case: > > https://nxr.netbsd.org/xref/src/sys/arch/hp300/stand/common/if_le.c?r=

Re: style(5) proposal: forbid extern in .c

2023-03-15 Thread Izumi Tsutsui
> Proposal: Forbid extern declarations in .c files. : > Pretty simple. Any objections? No objection, but I wonder how we can resolve this case: https://nxr.netbsd.org/xref/src/sys/arch/hp300/stand/common/if_le.c?r=1.14#101 --- extern struct netif_stats le_stats[]; static struct netif_di

Re: style(5) proposal: forbid extern in .c

2023-03-15 Thread Manuel Bouyer
On Wed, Mar 15, 2023 at 11:23:05AM +, Taylor R Campbell wrote: > Proposal: Forbid extern declarations in .c files. > > extern declarations in .c files invite easily avoided bugs where the > definition and use have mismatched types, because the compiler doesn't > have an opportunity to check th

Re: style(5) proposal: forbid extern in .c

2023-03-15 Thread Paul Goyette
On Wed, 15 Mar 2023, Taylor R Campbell wrote: Proposal: Forbid extern declarations in .c files. extern declarations in .c files invite easily avoided bugs where the definition and use have mismatched types, because the compiler doesn't have an opportunity to check them. Fix: Always put the ext

Re: style(5) proposal: forbid extern in .c

2023-03-15 Thread Jason Thorpe
> On Mar 15, 2023, at 4:23 AM, Taylor R Campbell > wrote: > > Proposal: Forbid extern declarations in .c files. > > extern declarations in .c files invite easily avoided bugs where the > definition and use have mismatched types, because the compiler doesn't > have an opportunity to check them

style(5) proposal: forbid extern in .c

2023-03-15 Thread Taylor R Campbell
Proposal: Forbid extern declarations in .c files. extern declarations in .c files invite easily avoided bugs where the definition and use have mismatched types, because the compiler doesn't have an opportunity to check them. Fix: Always put the extern declaration in a .h file shared by the .c fil

GSOC Project Discussion : Audio visualizer for the NetBSD base system

2023-03-15 Thread Eshan Kelkar
Hello, My name is Eshan Kelkar and I would like to create the Audio visualizer for the NetBSD base system as a GSOC project. I went through the "NetBSD audio - an application perspective" presentation which lists the audio libraries that NetBSD supports according to which GStreamer is supported on