Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Martin Husemann
On Tue, May 26, 2020 at 01:37:41AM +0200, Kamil Rytarowski wrote: > I agree here with Joerg. > > At this point it's good to just add a wrapper as in the proposed patch. > Once we will bump libc major, we can rename the syscall and remove > pollts references. > > Weak alias would still be nicer, b

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Kamil Rytarowski
On 25.05.2020 13:15, Joerg Sonnenberger wrote: > On Mon, May 25, 2020 at 12:05:44PM +0200, Martin Husemann wrote: >> On Mon, May 25, 2020 at 03:09:09PM +0530, Apurva Nandan wrote: >>> I meant that I can't create a __weak_alias ppoll(2) to pollts(2) in libc as >>> pollts(2) has its definition in sys

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Joerg Sonnenberger
On Mon, May 25, 2020 at 12:05:44PM +0200, Martin Husemann wrote: > On Mon, May 25, 2020 at 03:09:09PM +0530, Apurva Nandan wrote: > > I meant that I can't create a __weak_alias ppoll(2) to pollts(2) in libc as > > pollts(2) has its definition in sys/sys. But yes the resulting weak alias > > symbol

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Martin Husemann
On Mon, May 25, 2020 at 03:09:09PM +0530, Apurva Nandan wrote: > I meant that I can't create a __weak_alias ppoll(2) to pollts(2) in libc as > pollts(2) has its definition in sys/sys. But yes the resulting weak alias > symbol works from everywhere. The syscall stabs are generated code, but we have

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Robert Elz
Date:Mon, 25 May 2020 06:06:09 +0200 From:Martin Husemann Message-ID: <20200525040609.ga28...@mail.duskware.de> | The man page diff does not suggest any standards that define this function. It has been (twice now) proposed to posix to be added (both still pending,

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Apurva Nandan
I meant that I can't create a __weak_alias ppoll(2) to pollts(2) in libc as pollts(2) has its definition in sys/sys. But yes the resulting weak alias symbol works from everywhere. On Mon, 25 May, 2020, 14:59 Martin Husemann, wrote: > On Mon, May 25, 2020 at 11:24:14AM +0200, Joerg Sonnenberger w

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Martin Husemann
On Mon, May 25, 2020 at 11:24:14AM +0200, Joerg Sonnenberger wrote: > On Mon, May 25, 2020 at 10:06:22AM +0200, Martin Husemann wrote: > > On Mon, May 25, 2020 at 12:20:53PM +0530, Apurva Nandan wrote: > > > The problem with __weak_alias is that they only work inside the same C > > > file > > > wh

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Joerg Sonnenberger
On Mon, May 25, 2020 at 10:06:22AM +0200, Martin Husemann wrote: > On Mon, May 25, 2020 at 12:20:53PM +0530, Apurva Nandan wrote: > > The problem with __weak_alias is that they only work inside the same C file > > where the original symbol is defined, and don't work outside that file for > > that s

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Martin Husemann
On Mon, May 25, 2020 at 10:22:12AM +0200, Kamil Rytarowski wrote: > This is a non-standard extension, but everybody mainstream (except > macosx that lacks it?) settled on the name ppoll. ... which is probably the worst name anyone could come up with. Can you explain what alias issues you have? Th

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Kamil Rytarowski
On 25.05.2020 06:06, Martin Husemann wrote: > On Mon, May 25, 2020 at 04:32:14AM +0530, Apurva Nandan wrote: >> Hi all, >> I have added ppoll(2) implementation to libc/sys, which is a wrapper around >> pollts(2) function (basically, pollts(2) and ppoll(2) are aliases, and >> NetBSD has pollts(2)).

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Martin Husemann
On Mon, May 25, 2020 at 12:20:53PM +0530, Apurva Nandan wrote: > The problem with __weak_alias is that they only work inside the same C file > where the original symbol is defined, and don't work outside that file for > that symbol. That is not true. > I have created _ppoll internal function in l

Re: Addition of ppoll(2), a wrapper around pollts(2)

2020-05-25 Thread Apurva Nandan
On Mon, 25 May, 2020, 09:36 Martin Husemann, wrote: > On Mon, May 25, 2020 at 04:32:14AM +0530, Apurva Nandan wrote: > > Hi all, > > I have added ppoll(2) implementation to libc/sys, which is a wrapper > around > > pollts(2) function (basically, pollts(2) and ppoll(2) are aliases, and > > NetBSD