Re: patch - cgdconfig do_all mode gracefully ignore detached devices

2019-11-10 Thread Robert Elz
Date:Sun, 10 Nov 2019 10:00:48 -0600 From:Jason High Message-ID: | Ok? Aside from other issues, this should still be enabled by a new flag (whether the new flag causes -C or is used in conjunction with -C doesn't matter) - simply doing "cgdconfig -C" should not c

Re: patch - cgdconfig do_all mode gracefully ignore detached devices

2019-11-10 Thread Michael van Elst
On Sun, Nov 10, 2019 at 10:00:48AM -0600, Jason High wrote: > Thanks for the quick chat. Per suggestions, I'm using open rather > than opendisk. Ok? open is better, because cgd internally just opens the path. However, > return -1; > } > > +/* if called from do_all, then igno

Re: patch - cgdconfig do_all mode gracefully ignore detached devices

2019-11-10 Thread Jason High
Thanks for the quick chat. Per suggestions, I'm using open rather than opendisk. Ok? Index: cgdconfig.c === RCS file: /cvsroot/src/sbin/cgdconfig/cgdconfig.c,v retrieving revision 1.50 diff -b -u -r1.50 cgdconfig.c --- cgdconfig.c

Re: patch - cgdconfig do_all mode gracefully ignore detached devices

2019-11-10 Thread Jason High
Thanks for your feedback! We cannot fail silently in configure as-is due to the config/verification flow. However, if what was meant was to check for ENXIO in the verification function, then that works, and is a much simpler solution. In the below diff, we removed the check on -U per the issues