Re: namespace pollution by curses

2019-03-08 Thread Ruibiao Qiu
On Fri, Mar 8, 2019 at 7:36 AM Rin Okuyama wrote: > On 2019/03/08 22:53, Martin Husemann wrote: > > On Fri, Mar 08, 2019 at 10:41:51PM +0900, Rin Okuyama wrote: > > > >> I've found that this is because curses uses a global variable "state": > >> https://nxr.netbsd.org/xref/src/lib/libcurses/getch

Re: namespace pollution by curses

2019-03-08 Thread Valery Ushakov
Rin Okuyama wrote: > I would like to propose renaming "state" into "_cursesi_state": > http://www.netbsd.org/~rin/curses_state_20190308.patch > > Can I commit the patch? In that case, should I bump libcurses minor? > (That is, no matter to pull-up if minor version is bumped?) I wonder if state

Re: namespace pollution by curses

2019-03-08 Thread Christos Zoulas
In article <20190308135342.ga17...@mail.duskware.de>, Martin Husemann wrote: >On Fri, Mar 08, 2019 at 10:41:51PM +0900, Rin Okuyama wrote: > >> I've found that this is because curses uses a global variable "state": >> https://nxr.netbsd.org/xref/src/lib/libcurses/getch.c#50 >> https://nxr.netbsd.

Re: namespace pollution by curses

2019-03-08 Thread Rin Okuyama
On 2019/03/08 22:53, Martin Husemann wrote: On Fri, Mar 08, 2019 at 10:41:51PM +0900, Rin Okuyama wrote: I've found that this is because curses uses a global variable "state": https://nxr.netbsd.org/xref/src/lib/libcurses/getch.c#50 https://nxr.netbsd.org/xref/src/lib/libcurses/get_wch.c#52 C

Re: namespace pollution by curses

2019-03-08 Thread Martin Husemann
On Fri, Mar 08, 2019 at 10:41:51PM +0900, Rin Okuyama wrote: > I've found that this is because curses uses a global variable "state": > https://nxr.netbsd.org/xref/src/lib/libcurses/getch.c#50 > https://nxr.netbsd.org/xref/src/lib/libcurses/get_wch.c#52 Can both variants of inkey() co-exist? I wo

namespace pollution by curses

2019-03-08 Thread Rin Okuyama
Hi, pkgsrc/textproc/aspell crashes when linked to our curses (pkg/44005): http://gnats.netbsd.org/44005 I've found that this is because curses uses a global variable "state": https://nxr.netbsd.org/xref/src/lib/libcurses/getch.c#50 https://nxr.netbsd.org/xref/src/lib/libcurses/get_wch.c#52 If a