Re: Definitions of types also as macros

2018-11-06 Thread Valery Ushakov
On Tue, Nov 06, 2018 at 23:20:16 +0100, Rhialto wrote: > On Tue 06 Nov 2018 at 23:19:08 +0300, Valery Ushakov wrote: > > Also your change breaks redefining intN_t types with the preprocessor. > > E.g. > > > > #define uint32_t unsigned long long > > #include > > > > is now broken with yo

Re: Definitions of types also as macros

2018-11-06 Thread Rhialto
On Tue 06 Nov 2018 at 23:19:08 +0300, Valery Ushakov wrote: > Also your change breaks redefining intN_t types with the preprocessor. > E.g. > > #define uint32_t unsigned long long > #include > > is now broken with your change. But should that really be allowed? I haven't got the Standar

Re: Definitions of types also as macros

2018-11-06 Thread Valery Ushakov
[I missed this thread, so I'm reposting my reply that I originally sent to source-changes-d] On Tue, Nov 06, 2018 at 16:38:06 +, co...@sdf.org wrote: > On Tue, Nov 06, 2018 at 08:11:03AM -0800, John Nemeth wrote: > > On Nov 6, 3:07pm, co...@sdf.org wrote: > > } > > } I wanna do this, looks g

Re: Definitions of types also as macros

2018-11-06 Thread John Nemeth
On Nov 6, 3:07pm, co...@sdf.org wrote: } } I wanna do this, looks good? No. } Index: stdint.h } === } RCS file: /cvsroot/src/sys/sys/stdint.h,v } retrieving revision 1.7 } diff -u -r1.7 stdint.h } --- stdint.h 22 Apr 2013 21:2

Re: Definitions of types also as macros

2018-11-06 Thread coypu
On Tue, Nov 06, 2018 at 08:11:03AM -0800, John Nemeth wrote: > On Nov 6, 3:07pm, co...@sdf.org wrote: > } > } I wanna do this, looks good? > > No. > > } Index: stdint.h > } === > } RCS file: /cvsroot/src/sys/sys/stdint.h,v > }

Re: Definitions of types also as macros

2018-11-06 Thread Kamil Rytarowski
On 06.11.2018 16:07, co...@sdf.org wrote: > I wanna do this, looks good? > This looks good to me! > Index: stdint.h > === > RCS file: /cvsroot/src/sys/sys/stdint.h,v > retrieving revision 1.7 > diff -u -r1.7 stdint.h > --- stdint.h

Re: Definitions of types also as macros

2018-11-06 Thread coypu
I wanna do this, looks good? Index: stdint.h === RCS file: /cvsroot/src/sys/sys/stdint.h,v retrieving revision 1.7 diff -u -r1.7 stdint.h --- stdint.h22 Apr 2013 21:26:48 - 1.7 +++ stdint.h4 Nov 2018 09:35:54 - @@