Re: "%m" formatting code and "syslog like"

2018-08-31 Thread Ian Bruene
From the pointers in this discussion I am attempting a fix, though I have to wait until one of our other devs with a NetBSD box can test it. However it was necessary to dig into the NetBSD code itself to discover what was what; I may be sending in a documentation patch soon. -- /"In the end

Re: "%m" formatting code and "syslog like"

2018-08-31 Thread Roy Marples
On 31/08/2018 14:15, Martin Husemann wrote: On Fri, Aug 31, 2018 at 02:10:12PM +0100, Roy Marples wrote: The function is currently marked as __printflike. If I re-enable the warning gcc warns me that it should be marked as __sysloglike because it calls syslog. If I change it to __sysloglike

Re: "%m" formatting code and "syslog like"

2018-08-31 Thread Martin Husemann
On Fri, Aug 31, 2018 at 02:10:12PM +0100, Roy Marples wrote: > The function is currently marked as __printflike. > If I re-enable the warning gcc warns me that it should be marked as > __sysloglike because it calls syslog. If I change it to __sysloglike > then it warns me that it should be __p

Re: "%m" formatting code and "syslog like"

2018-08-31 Thread Roy Marples
On 31/08/2018 13:29, Martin Husemann wrote: On Fri, Aug 31, 2018 at 01:23:51PM +0100, Roy Marples wrote: This allows dhcpcd to be compiled with full warnings, but I've disabled the check for specific functions. This is actually self defeating as it's just the kind of function the warnings are fo

Re: "%m" formatting code and "syslog like"

2018-08-31 Thread Martin Husemann
On Fri, Aug 31, 2018 at 01:23:51PM +0100, Roy Marples wrote: > This allows dhcpcd to be compiled with full warnings, but I've disabled the > check for specific functions. This is actually self defeating as it's just > the kind of function the warnings are for, but as best I can tell it's > impossib

Re: "%m" formatting code and "syslog like"

2018-08-31 Thread Roy Marples
Hi Ian On 30/08/2018 19:11, Ian Bruene wrote: I am one of the developers on NTPsec and we are getting warnings on NetBSD 8.0 in the form: ../../ntpd/ntp_io.c:1962:14: warning: %m is only allowed in syslog(3) like functions [-Wformat=] This feature appears to have been added here: https://g

Re: Redoing the code in /bin/sh to handle the issues in PR bin/48875

2018-08-31 Thread Edgar Fuß
A bit late due to vacation: > To me, a command substitution that runs in the background seems weird > and like something to avoid. Is there really a case where this is useful, > or would it be reasonable to include a suggestion that it's best to avoid > such a construct? The case that led to th