Re: buffer overflow in t_vis.c

2017-04-12 Thread Iain Hibbert
On Thu, 13 Apr 2017, Brooks Davis wrote: > I've found a one byte buffer overflow in t_vis.c. It's caused by a > quite reasonable confusion about an undocumented behavior of always add > a '\0' terminating the dst string in strnunvisx(). This patch fixes the > test, but I think the behavior is co

buffer overflow in t_vis.c

2017-04-12 Thread Brooks Davis
I've found a one byte buffer overflow in t_vis.c. It's caused by a quite reasonable confusion about an undocumented behavior of always add a '\0' terminating the dst string in strnunvisx(). This patch fixes the test, but I think the behavior is confusing and should be documented in addition to th