Hi,
> Looking at it, I suspect there is another bug lurking.
> bge_attach() has 14 places where it can return without
> reeaching the end.
For some drivers, the progress through the setup is tracked and the detach
or failure unwinds the successful steps. Maybe it's worth doing something
similar
On Tue, May 06, 2025 at 03:12:33PM +1000, matthew green wrote:
> seems like it would be simpler to simply move the callout_init earlier.
> bge_flags also seems like h/w features, putting this in there seems
> like, while it uses a spare bit, is the wrong place anyway, but i think
> we can simply av
seems like it would be simpler to simply move the callout_init earlier.
bge_flags also seems like h/w features, putting this in there seems
like, while it uses a spare bit, is the wrong place anyway, but i think
we can simply avoid it by moving the callout_init() earlier.
.mrg.
hello
If bge configuration goes wrong, we call bge_release_resources()
and free the callout while it may not have been allocated. The
patch below works this around. Ok to commit? I am not sure bge_flags
is the right place to store this flag.
--- sys/dev/pci/if_bgereg.h 9 Feb 2024 22:08:35 -
