a few sparc references sprinkled about in dev
Index: ic/com.c
===
RCS file: /cvs/src/sys/dev/ic/com.c,v
retrieving revision 1.160
diff -u -p -r1.160 com.c
--- ic/com.c3 Sep 2016 14:43:37 - 1.160
+++ ic/com.c4 Sep 201
Stefan Sperling wrote:
> Replace the ioctl tsleep/wakeup BUSY flag dance with an rwlock.
This does the same change for the other intel wifi drivers.
Mechanical change, but I don't have hardware to test.
Index: if_ipw.c
===
RCS file:
Martin Natano wrote:
> usermount is dead. Ok?
ok
Ali H. Fardan wrote:
> If you can read my statement and reply with a proper statement,
> I'd appreciate it.
You are wrong.
Todd C. Miller wrote:
> On Sun, 04 Sep 2016 11:58:23 -0600, "Anthony J. Bentley" wrote:
>
> > This brings /usr/share/misc/getopt in sync with the example in getopt(3).
>
> OK, though I wonder if anyone actually looks at this file?
i think it's better to delete it.
Sevan Janiyan wrote:
> Hello,
> Attached patches remove the main() prototype from
> src/{sbin,usr.bin,usb.sbin}
yes!
It seems we're sticking with the C memcpy for a while (which does the bounds
check and logging) but now we're missing out on the potential asm speedup.
Let's try the best of both worlds by having the C memcpy call into memmove.
Yes, it'll do another direction test, but then it will go zip zoom fast
Bob Beck wrote:
> >
> > Agreed, I was also a bit unclear on payload at first (though it grew on
> > me over time, so I didn't change it). Here's an update with the
> > parameter renamed and better documented.
> >
> > ok?
>
> Yeah. I'm good with this
>
> IMO get it in so we can tweak it in tree.
Michal Mazurek wrote:
> ok?
>
> Index: sbin/mount/getmntopts.c
> ===
> RCS file: /cvs/src/sbin/mount/getmntopts.c,v
> retrieving revision 1.12
> diff -u -p -r1.12 getmntopts.c
> --- sbin/mount/getmntopts.c 16 Jan 2015 06:39:59 -
Instead of always using a fixed byte pattern, I think malloc should use a
random pattern. Now, this sometimes means it's harder to identify exactly
what's used after free, so we should provide a means to get the old 0xdf
pattern back.
Since we already have two junk modes, I thought I'd carry on al
Carlin Bingham wrote:
> The "etime" keyword is currently an alias for "start". posix says it
> should be the amount of time since the program started running, in the
> format [[dd-]hh:]mm:ss, I've encountered some code that doesn't work on
> openbsd because that's what it expects. The commit that a
Currently, the bufcache doesn't know that mfs is backed by memory. All i/o to
mfs ends up being double cached, once in the userland process and again in the
kernel bufcache. This is wasteful. In particular, it means one can't use mfs
to increase the effective size of the buffer cache. Reading or wr
The _KERNEL define is overloaded to mean two things, which results in frequent
errors. 1. It means we are compiling the kernel. 2. It means we are compiling
a userland program that looks at kernel data structures.
Just because we need data structures doesn't mean we want everything else in
the ker
Bob Beck wrote:
> I really dislike "CHEAP".
>
> and it almost seems like these should actually be NOCACHE.. why the heck
> can't they be?
So i looked at NOCACHE, but it seemed like that option may destroy the buffer
too soon. Anyway, I tested it and it does go boom. With just NOCACHE in mfs,
crea
Martin Pieuchot wrote:
> I'd like to use a write lock to serialize accesses to ip_output(). This
> will be used to guarantee that atomic code sections in the socket layer
> stay atomic when the input/forwarding path won't run under KERNEL_LOCK().
>
> For such purpose I'll have to convert some tsl
Ted Unangst wrote:
> This splits gzip into two processes, such that the heavy lifting is done in a
> process with even fewer privileges. The idea is the child decompresses the
> data and feeds it to the parent over a pipe. There's also a control pipe used
> for some metadata
Philip Guenther wrote:
> So what's protecting the state that you're waiting for the change to
> occur in? If it's the mutex, then why are you accessing it with only
> the rwlock early on? If it's the rwlock then how to prevent a
> lost-wakeup by a thread on another CPU getting in between the
> rw
convert two if else if chains to switches.
Index: base64.c
===
RCS file: /cvs/src/usr.sbin/acme-client/base64.c,v
retrieving revision 1.5
diff -u -p -r1.5 base64.c
--- base64.c1 Sep 2016 13:49:32 - 1.5
+++ base64.c13
Daniel Micay wrote:
>
> The current OpenBSD code only wipes up to MALLOC_MAXCHUNK with junk @ 1,
> and it similarly doesn't wipe at all with 'U' (even though junk-on-free
> also serves the purpose of preventing information leaks, not just
> mitigating use-after-free). IMO, optimizing large allocat
So the plan is for rebound to be the 'system' resolver, with libc talking to
rbeound and rebound talking to the cloud. The main wrinkle is how does rebound
find the cloud? rebound.conf, but dhclient doesn't know anything about
rebound.conf, preferring to edit resolv.conf. But if rebound reads
resol
Bob Beck wrote:
> how is rebound going to handle a change in resolv.conf? thats still a
> problem here
oh, that's easy. it watches the file for changes. i never quite got around to
that, but it's another five lines.
Bob Beck wrote:
> wont this also mean if it is not running i have to wait for the localhost
> attempt to fail before the resolver moves on? (ASR_STATE_NEXT_NS, etc) so i
> slow everything down for a timeout?
you get back unreachable and move on. it's fast. you can try it. :)
Ted Unangst wrote:
> Bob Beck wrote:
> > how is rebound going to handle a change in resolv.conf? thats still a
> > problem here
>
> oh, that's easy. it watches the file for changes. i never quite got around to
> that, but it's another five lines.
ok, so it&#
Otto Moerbeek wrote:
> On Wed, Sep 14, 2016 at 12:53:05PM -0400, Ted Unangst wrote:
>
> > Daniel Micay wrote:
> > >
> > > The current OpenBSD code only wipes up to MALLOC_MAXCHUNK with junk @ 1,
> > > and it similarly doesn't wipe at all with 'U
Florian Obser wrote:
> Not everything listening on localhost port 53 is a recursive resolver.
> nsd(8) per defaults listens on 0.0.0.0 and will respond with REFUSED for
> almost every query. asr stops in that case and does not try the next
> resolver in the list.
Ah! There's the catch. The good ne
Ted Unangst wrote:
> So the plan is for rebound to be the 'system' resolver, with libc talking to
> rbeound and rebound talking to the cloud. The main wrinkle is how does rebound
> find the cloud? rebound.conf, but dhclient doesn't know anything about
> rebound.conf, pre
Dimitris Papastamos wrote:
> Hi everyone,
>
> I've put together a patch for 6.0-stable that adds domain name
> matching support to rebound(8). The patch is quite rough at the
> moment.
>
> The config is as follows:
>
> match "local." 10.0.0.53
> match "." 8.8.8.8
So this is taking
Dimitris Papastamos wrote:
> By the way, what do you think about TCP caching support? I could send
> a patch to do just that.
It seems unnecessary. tcp proxy support is there because it's necessary, but
not because i think it's likely to be used. i'm pretty sure i never use it,
except when i deli
no change, but makes the code a little shorter.
Index: clientloop.c
===
RCS file: /cvs/src/usr.bin/ssh/clientloop.c,v
retrieving revision 1.287
diff -u -p -r1.287 clientloop.c
--- clientloop.c12 Sep 2016 01:22:38 - 1
Ted Unangst wrote:
> no change, but makes the code a little shorter.
while here, another similar spot.
Index: clientloop.c
===
RCS file: /cvs/src/usr.bin/ssh/clientloop.c,v
retrieving revision 1.287
diff -u -p -r1.287 clientloo
Philip Guenther wrote:
> On Wed, Sep 21, 2016 at 1:30 AM, Mathieu - wrote:
> >> > I'm introducing hashfree, a counterpart to hashinit in order to pass the
> >> > size to free(9) while hiding the implementation details.
thanks, committed.
> I don't understand the rename to hashfree() from the Net
David Gwynne wrote:
> + mtx_enter(&timeout_mutex);
> + while (!CIRCQ_EMPTY(&timeout_proc)) {
> + to = timeout_from_circq(CIRCQ_FIRST(&timeout_proc));
> + CIRCQ_REMOVE(&to->to_list);
leave();
> + timeout_run(
Kinichiro Inoguchi wrote:
> I would like to cast the return variable explicitly in tls_load_file().
> This fix also avoiding Intel C++ compiler "assertion failed" described here.
> https://github.com/libressl-portable/portable/issues/209#issuecomment-249587024
This is a compiler bug? The code does
Brent Cook wrote:
> Why not just make the variable type match the return type to begin with?
sure, that's reasonable.
>
> --- a/src/lib/libtls/tls_util.c
> +++ b/src/lib/libtls/tls_util.c
> @@ -105,7 +105,8 @@ tls_load_file(const char *name, size_t *len, char
> *password)
> FILE *fp;
>
Simon Ruderich wrote:
> Hello,
>
> I stumbled upon unexpected behavior on OpenBSD 6.0 (all patches)
> which seems to allow running commands as the original user when
> using su and doas interactively because the controlling terminal
> is the same.
> Is this behavior expected and if so, how do I r
Ted Unangst wrote:
> Ted Unangst wrote:
> > So the plan is for rebound to be the 'system' resolver, with libc talking to
> > rbeound and rebound talking to the cloud. The main wrinkle is how does
> > rebound
> > find the cloud? rebound.conf, but
Christiano F. Haesbaert wrote:
> There is another bug, the thread runs outside of IPL_SOFTCLOCK, the
> interrupt handler already runs at IPL_SOFTCLOCK so it did not need to raise
> it, but the thread does.
>
> The mutex is not enough as it will drop before running the handler, this
> can cause int
Otto Moerbeek wrote:
>
> This reduces the size of the canary to 32 bytes max and also prints
> the size of the chunk and the offset corruption was spotted.
>
> a.out(22658) in free(): error: chunk canary corrupted: 0x00c800e7
>
> I allocated 200 (0xc8) bytes and overwrote a byte at offset 231
Theo Buehler wrote:
> On Thu, Oct 06, 2016 at 08:34:31PM +0100, Jason McIntyre wrote:
> > On Thu, Oct 06, 2016 at 09:27:21PM +0200, Michal Mazurek wrote:
> > >
> > > Don't place a space after the minus sign. Change from this:
> > > width in columns. Otherwise, ps defaults to the terminal wi
Kinichiro Inoguchi wrote:
> I think this 16 bytes string assignment has boundary issue.
>
> static const char sigma[16] = "expand 32-byte k";
>
> I found this when I tried to build libressl-portable with MSVC on Windows.
another broken compiler? the above line is perfectly valid C.
Brent Cook wrote:
>
> > On Oct 7, 2016, at 12:18 PM, Ted Unangst wrote:
> >
> > Kinichiro Inoguchi wrote:
> >> I think this 16 bytes string assignment has boundary issue.
> >>
> >>static const char sigma[16] = "expand 32-byte k&quo
Jan Stary wrote:
> bin/mv has its own copies of cp.c and mv.c.
> Apparently, they are modifications of cp's cp.c and rm's rm.c,
> used when moving as "copy and remove the source".
>
> In bin/mv/rm.c, the following snippet of rm_file() confuses me:
>
> if (S_ISDIR(sb.st_mode)) {
>
Jan Stary wrote:
> Why do we need to trim the newlines in unexpand(1)?
> The result seems to be the same without it.
>
> Jan
>
>
> Index: unexpand.c
> ===
> RCS file: /cvs/src/usr.bin/unexpand/unexpand.c,v
> retrieving revisio
Jan Stary wrote:
> In unexpand.c, the -a indicator is
> both a global int and a local char.
I think this is backwards. We want fewer globals, not more.
Theo de Raadt wrote:
> > On Wed, Oct 12, 2016 at 03:20:00PM +0200, Otto Moerbeek wrote:
> > > simple diff to show the hostname on the second line. OK?
> >
> > OK bluhm@
> >
> > >
> > > BTW, batch mode doesn't function here as expected. Need to look into that,
>
> I hoped this would look more li
Otto Moerbeek wrote:
> On Thu, Oct 13, 2016 at 08:20:52AM +0200, Otto Moerbeek wrote:
>
> > On Thu, Oct 13, 2016 at 08:01:22AM +0200, Otto Moerbeek wrote:
> >
> > > On Thu, Oct 13, 2016 at 12:15:34AM -0400, Ted Unangst wrote:
> > >
> > > > Theo
Currently rebound ignores packets with bad IDs. we should log them.
But while we're at it, we should do something a little sneakier. Leave the
socket open and listen for additional replies. Ordinarily that shouldn't
happen, but it can mean that somebody is trying to mess with us. A local
attacker
16 bit IDs don't offer much security. This is well known. A trick to encode
more bits into the query is to vary the case of the query name. It's case
insensitive, but all known servers echo it back exactly, case preserving. Thus
we can twiddle the query on the way out and verify we get exactly the
Ted Unangst wrote:
> 16 bit IDs don't offer much security. This is well known. A trick to encode
> more bits into the query is to vary the case of the query name. It's case
> insensitive, but all known servers echo it back exactly, case preserving. Thus
> we can twiddle th
David Gwynne wrote:
> this adds a pool backend for MCLGETI thats 2k+2 bytes in size, which
> can be used on some very common nics that have annoying constraints
> on their rx descriptors.
>
> this in turn simplifies the code in those drivers and lets them
> always operate on ETHER_ALIGN boundaries
Otto Moerbeek wrote:
> Hi,
>
> 0xdb is better dan 0xd0, since it is unaligned in more cases (think
> about the bytes being used as a pointer.
ok
Otto Moerbeek wrote:
> That is certainly not correct: snprintf and friends return the length as
> it would have been if an infinite buffer was passed in.
> So the strlen should stay. I'll make a new diff soon though with the
> error checking, although it might be overkill for this case.
I think w
Ingo Schwarze wrote:
> Hi,
>
> Anton Lindqvist wrote on Fri, Dec 02, 2016 at 10:40:16AM +0100:
>
> > Make it clear that args is a keyword followed by zero or more arguments.
>
> Your argument makes sense to me, we generally don't use "..."
> to imply a preceding .Ar, but we use it to indicate th
it occurs to me that arglist and envlist are the same thing, a strlist.
Index: parse.y
===
RCS file: /cvs/src/usr.bin/doas/parse.y,v
retrieving revision 1.25
diff -u -p -r1.25 parse.y
--- parse.y 29 Dec 2016 19:12:42 - 1.
Theo de Raadt wrote:
> I'm wondering if anyone doing an install/upgrade has noticed any
> behaviour changes in the last week...
Small buglet:
grep /tmp/i/cgiinfo: No such file
David Gwynne wrote:
> this adds the current signify pub key for base to the httpd Server
> version header.
>
> as you say, the keys are small. this could help distribute it widely.
>
> here's an example of what it looks like:
>
> dlg@mild ~$ curl -I http://es45/
> HTTP/1.1 200 OK
> Connection:
Gregor Best wrote:
> On Tue, Jul 14, 2015 at 09:57:45AM -0600, Todd C. Miller wrote:
> > [...]
> > Shouldn't this be:
> >
> > p = (p - *store) + newstore;
> > [...]
>
> Of course, that makes way more sense. An amended patch is attached.
so technically i believe this i
Todd C. Miller wrote:
> On Tue, 14 Jul 2015 12:55:35 -0400, "Ted Unangst" wrote:
>
> > so technically i believe this is still undefined since you're not supposed
> > to
> > look at freed pointers. an even more better fix would be to save the offset
> &g
Tobias Ulmer wrote:
> As we all know, some Thinkpads have problems with their EC fan control.
> EC is not spinning up the fans to maximum speed, let alone blast mode.
> They also do not offer ACPI methods to spin the fan up.
>
> Previous diffs doing manual fan control were always rejected because
Vadim Zhukov wrote:
> The manpage recommends using absolute paths for commands, but those
> won't work. :) This patch makes everything not in a list of special
> characters to be a part of word; this way you can easily put
> the following in doas.conf:
>
> permit :somepeople cmd /usr/bin/mail vi
Vadim Zhukov wrote:
> Ask for a password when we're going to fail() anyway, to avoid
> leaking information about available commands. The sudo(8) behaves
> the same way, FWIW.
>
> okay?
i need to think about this for a bit. there's a strange interaction where if
the nopasswd option is used, you've
Vadim Zhukov wrote:
> 2015-07-17 1:02 GMT+03:00 Ted Unangst :
> > Vadim Zhukov wrote:
> >> The manpage recommends using absolute paths for commands, but those
> >> won't work. :) This patch makes everything not in a list of special
> >> characters to be a
Vadim Zhukov wrote:
> 2015-07-17 1:02 GMT+03:00 Ted Unangst :
> > Vadim Zhukov wrote:
> >> The manpage recommends using absolute paths for commands, but those
> >> won't work. :) This patch makes everything not in a list of special
> >> characters to be a
Vadim Zhukov wrote:
> Ask for a password when we're going to fail() anyway, to avoid
> leaking information about available commands. The sudo(8) behaves
> the same way, FWIW.
Let's say no for now. I'm not too concerned about this leak. I'm not sure what
a user would hope to discover. Hasn't the sy
Florian Obser wrote:
> OK?
>
> diff --git httpd.conf.5 httpd.conf.5
> index b3eaad8..bfca29f 100644
> --- httpd.conf.5
> +++ httpd.conf.5
> @@ -262,6 +262,18 @@ root directory of
> .Xr httpd 8
> and defaults to
> .Pa /run/slowcgi.sock .
> +.It Ic hsts Oo Ar option Oc
> +Enable HTTP Strict Trans
Ted Unangst wrote:
> Jeremy Evans wrote:
> > As an aside, crypt("passwd", "$2") returns ":" instead of NULL. I'm not
> > sure if that's a security issue, but I think it is and we should fix it.
> > I'll see if I can get a patch f
Stuart Henderson wrote:
> On 2015/07/17 20:24, Ted Unangst wrote:
> > Jeremy Evans wrote:
> > > As an aside, crypt("passwd", "$2") returns ":" instead of NULL. I'm not
> > > sure if that's a security issue, but I think it is and
Reyk Floeter wrote:
> On Fri, Jul 17, 2015 at 08:20:11PM -0400, Ted Unangst wrote:
> > Florian Obser wrote:
> > > OK?
> > >
> > > diff --git httpd.conf.5 httpd.conf.5
> > > index b3eaad8..bfca29f 100644
> > > --- httpd.conf.5
> > >
Sevan Janiyan wrote:
> The feature was actually added to ensure whatever cat was meant to be
> reading from was indeed a plain file and not another which could block a
> process.
> "Use cat -f to avoid denial of service attacks by people who make
> .rhosts files fifos."
> http://mail-index.netbsd.o
Sevan Janiyan wrote:
>
>
> On 19/07/2015 15:35, Bob Beck wrote:
> > The place to solve this is in whatever is using cat for this purpose.
> > check for the file type before blindly cat'ing.
>
> Understood both your & Ted's explanation regarding cat.
> Just so it's crisp clear, ignoring cat(1), h
Manuel Giraud wrote:
> Hi,
>
> I've just shot myself in the foot after /etc/doas.conf tweaking. This
> patch adds a failsafe "permit :wheel" rule in case of syntax error. Is
> this safe enough? Should it be done elsewhere (with some kind of
> visudo)?
I think the failsafe is "run su". Since it is
Jeremy Evans wrote:
>
> If this is worthy of more work, the command line options can certainly
> be changed. I just used getopt(3) since it seemed like the easiest
> way to handle it.
I talked with theo about this some. I'd say it's probably too early, and may
lead us down a weird path, where ta
li...@wrant.com wrote:
> > I think the failsafe is "run su".
>
> Visudo(8) style wrapper for doas(1) that would respect the editor
> preferences... is only a suggestion, no? We're 2015 here.
and vipf after that? there are countless config files, even more dangerous
than doas.conf, that you edit a
Kenneth R Westerback wrote:
> CAVEAT: The metadata version has changed so new volumes you create
> will not be loadable on boxes running older versions of OpenBSD.
>
> CAVEAT: You can't rebuild a volume created with *only* 512-byte
> devices onto a 4K-sector device. The volume must be created with
Michael McConville wrote:
> There was a great discussion about softdep recently:
>
> https://marc.info/?t=14216401691&r=1&w=2
>
> It needs extra memory, so the FAQ warns against its use on really old
> architectures.
>
> tedu@ described the two main deterrents:
>
> https://marc.
David Gwynne wrote:
> this is rough, but enough to start a discussion.
>
> this lets doas authenticate a user by talking to their ssh agent
> by specifying 'ssh-agent' on a permit line in the config. if agent
> auth fails, doas falls back to bsd auth (ie, password auth).
>
> to minimise the amoun
Marc Espie wrote:
>
> I don't think it falls on the side of bloat, and it's a pretty nifty option
> to sudo...
well, it's not just about code bloat. or even mostly about code bloat.
every option added to the program is added to the man page, and then users
learning how to use the program must
Marc Espie wrote:
>
> I don't think it falls on the side of bloat, and it's a pretty nifty option
> to sudo...
> @@ -361,7 +365,7 @@ main(int argc, char **argv, char **envp)
> }
>
> if (!(rule->options & NOPASS)) {
> - if (!auth_userokay(myname, NULL, NULL, NULL)) {
>
Theo Buehler wrote:
> I'm probably missing something, but from reading your implementation of
> checktimeout() it seems that you can easily cumvent the password prompt
> using something like this (assuming the timeout is enabled for the
> user):
And this is why this feature is not included in doas
Gregory Edigarov wrote:
> hi,
> here's an updated diff using /var/doas directory root:wheel owned with a
> strict 700 permissions. checks and batteries included.
Sorry, but this is not a feature we want at this time.
Martijn van Duren wrote:
> Hello tech@,
>
> I looked at the doas code and really like the concept and simplicity. I
> did found the strtogid code a little odd for two reasons:
> 1) It reads like an mangled variety on the parseuid function.
> 2) It returns -1 on error, but gid_t is defined as a __
A few patches are now available. Please consult the website for details.
OpenBSD 5.6 errata:
http://www.openbsd.org/errata56.html
027: SECURITY FIX: July 14, 2015 All architectures
A TCP socket can become confused and not properly cleanup resources.
A source code patch exists which remedies
Vadim Zhukov wrote:
> I see no point in hidding underlying error message from user.
> Found while preparing chroot for doas run tests.
>
> Okay?
setusercontext(3) doesn't say anything about setting errno, so it's not clear
it will always be set or to a correct value.
Vadim Zhukov wrote:
> This fixes (as t-run-keepenv-path says) the problem found be Ze Loff:
> http://marc.info/?l=openbsd-misc&m=143807620616845&w=2
>
> Okay?
ah, oops. that was supposed to be --nextras i think, but it's clearer this
way.
> --
> WBR,
> Vadim Zhukov
>
>
> Index: doas.c
>
Sevan Janiyan wrote:
>
>
> On 21/07/2015 00:16, Sevan Janiyan wrote:
> > Hi,
> > Attached is a diff for a couple of issues raised by coverity, obtained
> > from NetBSD src/bin/cat/cat.c r1.53 & r1.54
> >
> >>From the commit message in NetBSD CVS:
> > "bin/cat/cat.c 976654 Argument cannot be nega
Karel Gardas wrote:
> Yes, Free also adds softdep journaling. on the other hand Net
> completely abandoned softdep in favour of wapbl, this thing is
> interesting since it's about ~1k lines. Net also as the only one from
> *BSD supports ffs snapshoting, this is about another ~2k lines of
> code. Su
Michael Reed wrote:
> I only have a very loose idea of what gets accepted or not when the tree
> is "locked", so apologies if this should have been sent at a different
> time.
patches are always welcome. they just get overlooked sometimes. :)
> Index: worm.c
>
Jan Engelhardt wrote:
>
> On Wednesday 2015-08-12 20:29, Mark Kettenis wrote:
> >
> >One possible reason to deviate from using the LibreSSL release version
> >would be if we want to continue to be a drop-in replacement for
> >OpenSSL. In that case continuing to adevrtise a reasonable OpenSSL
> >v
Martin Pieuchot wrote:
>
> How many sparc64 come with em(4)? Can we assume that the amount of
> wasted memory on such system is acceptable? What about other strict-
> alignment architectures?
just(? mostly?) t5120. mine has 32gb in it. it is, or could be, a popular
openbsd machine. it's also ne
Michael McConville wrote:
> ndex: faq/ports/guide.html
> ===
> RCS file: /cvs/www/faq/ports/guide.html,v
> retrieving revision 1.37
> diff -u -p -r1.37 guide.html
> --- faq/ports/guide.html 2 Jul 2015 05:49:05 - 1.37
> +
Rafael Zalamena wrote:
> On Mon, Aug 17, 2015 at 01:00:26PM -0300, Vinicios Barros wrote:
> > Hello all,
> >
> > I would like to suggest these changes to remove unused variables
> > and a respectively unnecessary call of the gettimeofday, also removes
> > a casting in the malloc, that seems to be
Theo Buehler wrote:
> In episode 103 of BSD Now, Bryan Cantrill talks about the fact that
> on illumos "rm -rf /" is an error. It turns out that this behavior
> is mandated by POSIX 1003.1-2013:
>
> "If either of the files dot or dot-dot are specified as the basename
> portion of an operand (that
Alexander Hall wrote:
> I was inspired by a related mail to send out this doas auth diff again.
> Hopefully my phone won't ruin the formatting.
>
> . . . . .
>
> Add a type to auth_userokay() to allow for giving a specific
> authentication method for doas in login.conf, e.g.
>
> staff:\
>
Renaud Allard wrote:
> On 08/26/2015 06:39 PM, Michael Reed wrote:
> > Hi Renauld,
> >
> > On 08/26/15 09:38, Renaud Allard wrote:
> >> I rewrote a little bit the patch to remove a small kind-of typo in the
> >> manpage and remove too long lines.
> >> So with this patch, you add the user the right
Renaud Allard wrote:
>
>
> On 27/08/15 18:32, Ted Unangst wrote:
>
> >
> > Sorry, I think adding an option is too much. I just committed halex's
> > original
> > diff to only change the type. I thought he was going to do that by now.
> >
>
&g
add some sizes to free.
as a bonus, an xxx comment where i believe there's a leak.
Index: aesni.c
===
RCS file: /cvs/src/sys/arch/amd64/amd64/aesni.c,v
retrieving revision 1.32
diff -u -p -r1.32 aesni.c
--- aesni.c 14 Mar 2015 0
I would prefer that apmd log 10% increments not 20. And fix the off by one,
which made it 21. (I find it odd to see a sequence of 99, 78, 57% in logs.)
Index: apmd.c
===
RCS file: /cvs/src/usr.sbin/apmd/apmd.c,v
retrieving revision 1
Mark Kettenis wrote:
> This diff is purely mechanical. This means that it also changes some
> pool_allocator_nointr into pool_allocator_single where the intention
> was to signal that the pool would never be used in interrupt context.
> However, using pool_allocator_single in those cases isn't a b
Mark Kettenis wrote:
> > From: "Ted Unangst"
> > Date: Sat, 29 Aug 2015 18:38:45 -0400
> >
> > Mark Kettenis wrote:
> > > This diff is purely mechanical. This means that it also changes some
> > > pool_allocator_nointr into pool_allocator_sin
Michael McConville wrote:
> Also, why is fs on line 390 cast to char* when afree() takes void*?
this code is older than void. and NULL apparently. please remove the casts
too.
601 - 700 of 1831 matches
Mail list logo
