Re: slimblade support

2021-01-09 Thread Peter Hessler
On 2021 Jan 09 (Sat) at 07:00:29 -0700 (-0700), Thomas Frohwein wrote: :On Sat, Nov 21, 2020 at 08:10:03AM +0200, Timo Myyrä wrote: :> Hi, :> :> The last attempt at adding Kensington Slimblade trackball support seems :> to have stalled: :> https://marc.info/?l=openbsd-tech&m=147444999319756&w=2 :>

Re: iwm(4) A-MSDU support

2021-03-30 Thread Peter Hessler
On 2021 Mar 29 (Mon) at 19:27:15 +0200 (+0200), Stefan Sperling wrote: :This patch attempts to add support for receiving A-MSDUs to iwm(4). :If you are using iwm(4) then please run with this patch and let me :know if it causes regressions. Thanks! : :ACHTUNG: This patch breaks iwx(4)! Don't use it

Re: iwm(4) A-MSDU support

2021-03-30 Thread Peter Hessler
On 2021 Mar 30 (Tue) at 20:22:09 +0200 (+0200), Stefan Sperling wrote: :On Tue, Mar 30, 2021 at 07:36:28PM +0200, Peter Hessler wrote: :> Been running this for about 24 hours on my x395, seems to be good. :> :> Had only one stuck wifi when first trying it, but I was also stuck on a

Re: request_sleep: new machine independent sleep api

2023-07-08 Thread Peter Hessler
On 2023 Jul 08 (Sat) at 13:09:00 +0300 (+0300), Tobias Heider wrote: : : :On July 8, 2023 11:36:21 AM GMT+03:00, Mark Kettenis wrote: :>> Date: Sat, 8 Jul 2023 10:10:51 +0200 :>> From: Tobias Heider :>> :>> This diff adds request_sleep(), a MI way of sending the machine to sleep in a :>> safe

Re: vmd/vmm: remove an ioctl from the vcpu hotpath, go brrr

2023-09-02 Thread Peter Hessler
I just upgraded to -current and didn't have this patch in for a little bit, and woof that was super noticable. Still works for my big VM host. OK On 2023 Sep 01 (Fri) at 15:50:31 -0400 (-0400), Dave Voutila wrote: :Now that my i8259 fix is in, it's safe to expand the testing pool for :this diff

Re: Replace selwakeup() with knote(9) in wscons(4) and make filterops mpsafe

2023-09-07 Thread Peter Hessler
On 2023 Jul 11 (Tue) at 16:40:32 +0300 (+0300), Vitaliy Makkoveev wrote: :Use per 'wseventvar' structure `mtx' mutex(9) to protect `put' and `get' :circular buffer indexes together with klist data. Not a big deal, but :Xorg will not kernel lock while polling keyboard and mouse events. Also :removed

Re: azalia: use HDMI as second fallback

2023-10-29 Thread Peter Hessler
Yes please! On 2023 Oct 29 (Sun) at 14:55:09 +0100 (+0100), Christopher Zimmermann wrote: :Hi, : :for me azalia HDMI audio playback works fine. According to [1] it had or :still has problems. For machines where the default audio should not be :(possibly broken) rsnd/0, but rsnd/1 this can be conf

audio devices for armv7

2021-05-24 Thread Peter Hessler
After the recent uaudio dma fixes, I tried out audio playing on my armv7 system. Tested on the built-in audio port on hw.product=Tinker-RK3288, sounds fine. OK? (N.B. 'twrget' is not a typo, even if it looks like one) Index: etc/etc.armv7/MAKEDEV.md

Re: slaacd(8): moving between networks

2018-07-22 Thread Peter Hessler
On 2018 Jul 22 (Sun) at 18:19:01 +0200 (+0200), Florian Obser wrote: :When one is connected to a network, suspends or hibernates, moves to a :different network and wakes up one ends up with ip addresses from both :networks and things probably go sideways. There is a good chance that :source address

Re: Add acpipci(4) on amd64

2018-10-23 Thread Peter Hessler
On 2018 Oct 22 (Mon) at 21:45:06 +0200 (+0200), Mark Kettenis wrote: :Diff below adds an acpipci(4) driver on amd64. For now the main :purpose of this driver is to make the PCI-specific _OSC calls to :advertise the functionality we support. Most notably this advertises :support for PCIE native ho

Re: pvclock(4)

2018-12-04 Thread Peter Hessler
On 2018 Dec 03 (Mon) at 16:56:10 -0800 (-0800), Chris Cappuccio wrote: :Reyk Floeter [r...@openbsd.org] wrote: :> :> Yes, KVM???s stable bit is not a reliable indication as it is seems to depend on the capabilities of the KVM version and not the actual availability of the feature on the particula

Re: pvclock(4)

2018-12-05 Thread Peter Hessler
On 2018 Dec 04 (Tue) at 15:14:51 +0100 (+0100), Reyk Floeter wrote: :On Tue, Dec 04, 2018 at 05:43:48AM -0800, Chris Cappuccio wrote: :> Of course printf instead of panic for testers :> : :Oh, right, thanks! : :@john: Does this "slightly less simple" diff work for you? : :@phessler, Chris: Maybe

Re: vport: set UP on ip assign

2021-11-15 Thread Peter Hessler
On 2021 Nov 15 (Mon) at 13:58:08 +0100 (+0100), Claudio Jeker wrote: :On Mon, Nov 15, 2021 at 12:23:02PM +, Klemens Nanni wrote: ... :Sure people got used to this mode. I agree with dlg@ that the way that :this auto interface up happens is rather horrible from a network stack :view. Also it mak

Call uvm_grow() on armv7

2020-09-25 Thread Peter Hessler
After Mark noticed that arm64 didn't have it, I checked armv7 and it also doesn't have it. Successfully tested on a Tinker-RK3288 OK? Index: sys/arch/arm/arm/fault.c === RCS file: /home/cvs/openbsd/src/sys/arch/arm/arm/fault.c,v re

Re: Call uvm_grow() on armv7

2020-09-25 Thread Peter Hessler
On 2020 Sep 25 (Fri) at 14:51:01 +0200 (+0200), Mark Kettenis wrote: :> Date: Fri, 25 Sep 2020 14:38:23 +0200 :> From: Peter Hessler :> :> After Mark noticed that arm64 didn't have it, I checked armv7 and it :> also doesn't have it. :> :> Successfully test

Re: net80211: Better gapwait accounting

2020-12-07 Thread Peter Hessler
On 2020 Dec 07 (Mon) at 15:02:14 +0100 (+0100), Stefan Sperling wrote: :On Mon, Dec 07, 2020 at 02:36:05PM +0100, Tobias Heider wrote: :> Hi, :> :> our net80211 gapwait accounting implementation seems to have several :> problems: :> - If we lose packets with serial numbers 0 und 2 but receive the

Re: iwm(4): decoding of multiple MPDUs in one receive packet

2020-12-07 Thread Peter Hessler
OK On 2020 Dec 07 (Mon) at 10:28:59 +0100 (+0100), Tobias Heider wrote: :Hi, : :In iwm_rx_pkt() the calculation of "remain" seems to be wrong if :there are three or more MPDUs in one packet. :"remain" is initialized with the output buffer size. :Each time an MPDU is found in the packet remain is r

Re: net80211: Use a BA agreement for rx immediately

2020-12-07 Thread Peter Hessler
On 2020 Dec 07 (Mon) at 16:41:33 +0100 (+0100), Stefan Sperling wrote: :On Mon, Dec 07, 2020 at 03:49:20PM +0100, Tobias Heider wrote: :> On Mon, Dec 07, 2020 at 02:33:10PM +0100, Stefan Sperling wrote: :> > On Mon, Dec 07, 2020 at 01:31:09PM +0100, Tobias Heider wrote: :> > > Some APs request a BA

Re: net80211: fix announced RSN (WPA2) capabilities

2020-12-07 Thread Peter Hessler
Looks good, no regression for my AP at home. OK On 2020 Dec 07 (Mon) at 22:55:29 +0100 (+0100), Stefan Sperling wrote: :When announcing RSN (WPA2) capabilities in management frames such as :association requests, we currently echo back all RSN (i.e. WPA2) :capabilities which were announced by our

Re: bfd: respond to poll sequence from peer

2019-06-05 Thread Peter Hessler
Hi Mitchell Thanks a lot for the work you are putting into BFD, I'll be able to review this properly over the weekend. -peter On 2019 Jun 03 (Mon) at 20:37:17 +1000 (+1000), Mitchell Krome wrote: :Hi, : :Testing bfd against frr on linux, their bfd implementation sends polls :as soon as the sess

Re: initial iwx(4) 11ac patch for testing

2022-03-10 Thread Peter Hessler
On 2022 Mar 10 (Thu) at 12:35:20 +0100 (+0100), Stefan Sperling wrote: :On Thu, Mar 10, 2022 at 12:25:17PM +0100, Stefan Sperling wrote: :> Unless anyone else finds a problem, this patch can be considered ready :> for review and commit. : :Of course, I forgot to apply my sysassert fix to the second

Re: [patch] CPU frequency scheduler change proposal

2022-03-20 Thread Peter Hessler
On 2022 Mar 20 (Sun) at 18:13:20 + (+), Stuart Henderson wrote: :On 2022/03/20 18:13, Solene Rapenne wrote: :> I'm proposing a very simple change to the automatic policy of the CPU :> frequency scheduler. :> :> Currently, every 100ms the scheduler is doing this: :> :> - when the CPU load

vmctl show

2018-02-10 Thread Peter Hessler
My fingers have typed "vmctl show" instead of "vmctl status" for over a year now, so add it as an alias. OK? Index: main.c === RCS file: /cvs/openbsd/src/usr.sbin/vmctl/main.c,v retrieving revision 1.34 diff -u -p -u -p -r1.34 main.

Re: armv7 ABI fix

2018-02-27 Thread Peter Hessler
On 2018 Feb 27 (Tue) at 22:04:15 +0100 (+0100), Mark Kettenis wrote: :The "new" AAPCS-based ABI that we have been using on armv7 for a while :now requires various 64-bit types to be aligned on an 8-byte boundary. :Unfortunately we didn't realize this when we switched and didn't :adjust the definiti

Re: slaacd(8): RFC 7136

2018-03-07 Thread Peter Hessler
yup, makes sense. OK On 2018 Mar 07 (Wed) at 18:29:07 +0100 (+0100), Florian Obser wrote: :RFC 7136 clarifies that the "u" and "g" bits are only significant when :IPv6 unicast interface identifiers are derived from IEEE link-layer :addresses. In all other cases the interface identifier should be

Re: correctly calculate RFC7217 based IPv6 address

2018-03-13 Thread Peter Hessler
On 2018 Mar 13 (Tue) at 12:41:17 +0100 (+0100), Florian Obser wrote: :(sending this to tech@ so that more people see this) : :semarie@ pointed out on bugs@ ( :https://marc.info/?l=openbsd-bugs&m=152084960013726&w=2 ) that his :RFC7217 IPv6 address changed after an upgrade. Of course it should not.

Re: ifconfig,route,netstat: s/tableid/rtable/ for consistency

2018-04-11 Thread Peter Hessler
No, all of these uses are correct as-is. On 2018 Apr 10 (Tue) at 23:23:24 +0200 (+0200), Klemens Nanni wrote: :Several tools may operate on specific routing tables (or routing domains :in special cases). : :With the exception of `tableid' in ifconfig(8), route(8) and netstat(1), :all other manual

Re: ifconfig,route,netstat: s/tableid/rtable/ for consistency

2018-04-12 Thread Peter Hessler
On 2018 Apr 11 (Wed) at 23:01:45 +0200 (+0200), Klemens Nanni wrote: :On Wed, Apr 11, 2018 at 09:28:03AM +0200, Peter Hessler wrote: :> No, all of these uses are correct as-is. :`tableid' surely isn't wrong, but using the argument name across manuals :seems nicer to me. : No, they

Re: RTM_CHGADDRATTR

2018-04-25 Thread Peter Hessler
On 2018 Apr 18 (Wed) at 19:49:41 +0200 (+0200), Florian Obser wrote: :On Wed, Apr 18, 2018 at 05:05:59PM +0200, Florian Obser wrote: :> This is to inform userland (i.e. slaacd(8)) when duplicate address :> detection finishes. :> :> Not a big fan of the lock/unlock dance but I guess it can't be hel

Re: net80211: fix WEP

2018-04-27 Thread Peter Hessler
Verified it fixes WEP. OK On 2018 Apr 27 (Fri) at 16:30:50 +0200 (+0200), Stefan Sperling wrote: :We just found out that WEP has been broken since August 2017. :Apparently not many people noticed. The commit which broke :it was: : :[[[ :CVSROOT: /cvs :Module name: src :Changes

Re: net80211: fix WEP

2018-04-27 Thread Peter Hessler
On 2018 Apr 27 (Fri) at 17:45:44 +0300 (+0300), Paul Irofti wrote: :On Fri, Apr 27, 2018 at 04:30:50PM +0200, Stefan Sperling wrote: :> We just found out that WEP has been broken since August 2017. :> Apparently not many people noticed. The commit which broke :> it was: :> :> [[[ :> CVSROOT: /

free all nodes and set linkstate to down when entering the SCAN state for all drivers

2018-04-28 Thread Peter Hessler
Some drivers use their own functions to change the link state for a non-background scan, so ensure that they set the link state to down, and free all nodes. This is a follow up to stsp@'s ieee80211.c:r1.68. (N.B. the atu driver already calls ieee80211_free_allnodes in this case statement, but out

Re: rssi comparison threshold

2018-04-29 Thread Peter Hessler
On 2018 Apr 29 (Sun) at 11:51:26 +0200 (+0200), Stefan Sperling wrote: :This diff tries to avoid situations where background scans play :ping-pong between different APs with nearly equal RSSI, as :observed by phessler. : :Not all drivers represent RSSI values in dBm or percentage, so the :diff incl

Re: rssi comparison threshold

2018-05-01 Thread Peter Hessler
On 2018 May 01 (Tue) at 11:20:54 +0200 (+0200), Stefan Sperling wrote: :On Mon, Apr 30, 2018 at 08:57:23AM +0200, Peter Hessler wrote: :> On 2018 Apr 29 (Sun) at 11:51:26 +0200 (+0200), Stefan Sperling wrote: :> :This diff tries to avoid situations where background scans play :> :ping-pon

Re: 5GHz AP RSSI measurement problem

2018-05-02 Thread Peter Hessler
On 2018 Apr 30 (Mon) at 10:55:22 +0200 (+0200), Stefan Sperling wrote: :Setting aside concerns about my lack of understanding of the underlying :reason for this behaviour, the hack below is sufficient to make this AP :show up as a strong contender in the candidate list and be preferred :over 2GHz a

Re: slaacd(8) handle RTM_DELETE of default route

2018-05-17 Thread Peter Hessler
Running this for a little bit, done a bunch of lladdr random tests, as well as suspend resume tests (which I've added lladdr random on resume). This fixes the issues I'm seeing, OK. On 2018 May 17 (Thu) at 14:25:44 +0200 (+0200), Florian Obser wrote: :Peter points out that I never got around to

Re: bgpd softreconf in optimisation

2018-07-04 Thread Peter Hessler
yes please! OK On 2018 Jul 03 (Tue) at 22:37:29 +0200 (+0200), Claudio Jeker wrote: :There is no need to run against both input filters. :path_update() and prefix_remove() are both smart enough to handle all :cases (similar to a regular update). Should make reloads a bit faster. : :More precise

Re: rc(8): don't hide failures from route6d & rtadvd

2018-07-11 Thread Peter Hessler
net.inet6.ip6.forwarding=0 OK(failed) On 2018 Jul 11 (Wed) at 09:58:18 +0200 (+0200), Florian Obser wrote: :at least rtadvd has it's own check and failes to start if forwarding :is not enabled, not sure what route6d is doing. : :rc(8) should not silently hide errors. : :OK? : :diff --git etc/rc e

Re: spelling correction

2019-02-10 Thread Peter Hessler
$ grep -c nonexistant /usr/share/dict/words 0 $ grep -c nonexistent /usr/share/dict/words 2 OK or if someone else wants to give me an OK I can commit this. On 2019 Feb 10 (Sun) at 11:13:04 -0500 (-0500), Pamela Mosiejczuk wrote: :Hi, :I noticed "non-existant" crop up in an error message and w

Re: xhci: set chain bit in link TRBs

2019-02-21 Thread Peter Hessler
On 2019 Feb 21 (Thu) at 16:19:22 +0100 (+0100), Patrick Wildt wrote: :On Thu, Feb 21, 2019 at 03:56:57PM +0100, Stefan Sperling wrote: :> On Thu, Feb 21, 2019 at 10:50:40AM +0100, Patrick Wildt wrote: :> > Hi, :> > :> > on my i.MX8M machine which features a DWC3 xHCI 1.10 controller I have :> > se

Re: [1/4] Re: Add support for Meinberg DCF600USB to umbg(4)

2019-03-22 Thread Peter Hessler
OK On 2019 Mar 22 (Fri) at 10:03:26 +0100 (+0100), Paul de Weerd wrote: : :Index: usbdevs :=== :RCS file: /home/OpenBSD/cvs/src/sys/dev/usb/usbdevs,v :retrieving revision 1.695 :diff -u -p -r1.695 usbdevs :--- usbdevs24 Feb 2019

Re: [4/4] Re: Add support for Meinberg DCF600USB to umbg(4)

2019-03-22 Thread Peter Hessler
OK On 2019 Mar 22 (Fri) at 10:04:37 +0100 (+0100), Paul de Weerd wrote: :Index: GENERIC :=== :RCS file: /home/OpenBSD/cvs/src/sys/arch/amd64/conf/GENERIC,v :retrieving revision 1.466 :diff -u -p -r1.466 GENERIC :--- GENERIC19 Jan

Re: [3/4] Re: Add support for Meinberg DCF600USB to umbg(4)

2019-03-22 Thread Peter Hessler
OK On 2019 Mar 22 (Fri) at 10:04:19 +0100 (+0100), Paul de Weerd wrote: : :Index: share/man/man4/umbg.4 :=== :RCS file: /home/OpenBSD/cvs/src/share/man/man4/umbg.4,v :retrieving revision 1.4 :diff -u -p -r1.4 umbg.4 :--- share/man/ma

Re: ksh "clear-screen" editing command

2019-04-02 Thread Peter Hessler
On 2019 Apr 01 (Mon) at 09:53:31 -0600 (-0600), Todd C. Miller wrote: :On Mon, 01 Apr 2019 16:52:34 +0200, Jeremie Courreges-Anglas wrote: : :> Since this went in, I'm using it on my machines instead of a bind -m hack. :> :> Can't we make ^L=clear-screen the default behavior? I don't see :> discus

Re: ifmedia_ioctl: ignore ENETRESET from ifm_change()

2019-04-24 Thread Peter Hessler
On 2019 Apr 24 (Wed) at 22:50:58 +1000 (+1000), Jonathan Matthew wrote: :On Wed, Apr 24, 2019 at 12:21:47PM +0200, Stefan Sperling wrote: :> On Sun, Apr 21, 2019 at 09:44:08PM +0800, Kevin Lo wrote: :> > On Sun, Apr 21, 2019 at 01:02:39PM +1000, Jonathan Matthew wrote: :> > > Currently we have some

Re: increase IEEE80211_CACHE_SIZE

2019-12-28 Thread Peter Hessler
OK On 2019 Dec 28 (Sat) at 14:27:01 +0100 (+0100), Stefan Sperling wrote: :The number of entries in the node cache is currently capped to 100. : :This limit is outdated. Modern hardware like iwm(4) 8265 supports 46 :distinct channels (1-13, 36-165) each of which can host multiple APs. : :The limi

apply changes immediately to join'd essids

2020-01-12 Thread Peter Hessler
When we change attributes for a join essid, we should apply the change immediately instead of waiting to (randomly) switch away and switch back. Found by martijn@ OK? Index: net80211/ieee80211_ioctl.c === RCS file: /home/cvs/openbs

Re: apply changes immediately to join'd essids

2020-01-14 Thread Peter Hessler
On 2020 Jan 12 (Sun) at 21:39:19 +0100 (+0100), Peter Hessler wrote: :When we change attributes for a join essid, we should apply the change :immediately instead of waiting to (randomly) switch away and switch :back. And if we are connected to an AP, remove the node from the cache so we can

Re: apply changes immediately to join'd essids

2020-01-14 Thread Peter Hessler
On 2020 Jan 14 (Tue) at 13:11:57 +0100 (+0100), Stefan Sperling wrote: :On Mon, Jan 13, 2020 at 10:38:35PM +0100, Peter Hessler wrote: :> On 2020 Jan 12 (Sun) at 21:39:19 +0100 (+0100), Peter Hessler wrote: :> :When we change attributes for a join essid, we should apply the change :> :im

Re: Support for newer Broadcom bge(4) chipsets.

2009-05-21 Thread Peter Hessler
Tested on a slightly older chipset, works fine for me. bge0 at pci3 dev 0 function 0 "Broadcom BCM5755M" rev 0x02, BCM5755 A2 (0xa002): apic 2 int 17 (irq 10), address 00:1c:23:15:76:47 brgphy0 at bge0 phy 1: BCM5755 10/100/1000baseT PHY, rev. 0 On 2009 May 17 (Sun) at 08:14:52 -0400 (-0400),

Re: mixerctl(1) to sysctl(8); a simpler interface

2009-11-20 Thread Peter Hessler
mixerctl inputs.master=[0,255] mixerctl outputs.master=[0,255] those two should do what you want. the rest are there for people that like to poke at their audio bits. On 2009 Nov 20 (Fri) at 15:39:55 +0100 (+0100), Thomas Pfaff wrote: :Hi. : :I've been thinking a bit about how to simplify the

Re: Atheros AR5424 rev 0x01 hal error

2010-04-20 Thread Peter Hessler
this is a known unsupported chip. I believe the ISC atheros driver is compatible, so you may be able to borrow code from linux/freebsd/netbsd to fix it. (think of it as a TODO item ;) ) On 2010 Apr 20 (Tue) at 10:55:18 -0400 (-0400), Adam M. Dutko wrote: :When I attempt to use my wireless card

Re: Missing check in ftp(1)

2010-06-26 Thread Peter Hessler
Hi Alexander This diff had some issues for me, namely the chunk below. :+ if (line == NULL); However I did adjust it and came up with this instead, does it also fix the issue for you? Index: list.c === RCS f

Re: Missing check in ftp(1)

2010-06-27 Thread Peter Hessler
On 2010 Jun 27 (Sun) at 12:41:21 +0200 (+0200), Alexander Schrijver wrote: :Now it just does nothing, like it is supposed to (The second is with your fix applied): : :$ echo 'mget -r . ' | ftp ftp://ftp.cs.cmu.edu :Segmentation fault (core dumped) :$ echo 'mget -r . ' | ./ftp ftp://ftp.cs.cm

Re: better cpu throttling

2010-06-30 Thread Peter Hessler
On 2010 Jun 30 (Wed) at 22:25:45 +0100 (+0100), Luis Henriques wrote: :Eventually there are usage scenarios where setting the maximum :performance to 50% (or whatever value) may make sense -- if you want to :save some power, for example. It doesn't really save any power. I've done tests while doi

Re: I have a program I wish to submit for the base

2016-02-02 Thread Peter Hessler
On 2016 Feb 01 (Mon) at 15:31:25 -0600 (-0600), Luke Small wrote: :I think that there is some unwritten policy that nobody can get something :like this into the system. Why on earth hasn't this happened yet? Your proposed addition has been rejected, and will continue to be rejected. 1) The code i

Re: spamd - blacklists

2016-03-16 Thread Peter Hessler
On 2016 Mar 16 (Wed) at 10:53:36 +1100 (+1100), Damien Miller wrote: :On Tue, 15 Mar 2016, li...@wrant.com wrote: : :> What's going on with the BGP as a transport then, is it available to :> the general public? Must be much better than the fubar DNS. Nackts :> thing and we'd be attempting carping

bgpd: fix adding a new interface and network inet connected

2016-03-21 Thread Peter Hessler
We ran into a situation where we accidentally blackholed traffic going to a new Internet Exchange. When we added the new vlans and new peers, the nexthop address on that vlan was *not* our neighbor's address, but instead used our own IP address on that new interface. "bgpctl show rib", showed the

Re: bgpd: fix adding a new interface and network inet connected

2016-03-21 Thread Peter Hessler
On 2016 Mar 21 (Mon) at 16:22:53 +0100 (+0100), Claudio Jeker wrote: :On Mon, Mar 21, 2016 at 03:54:38PM +0100, Peter Hessler wrote: :> We ran into a situation where we accidentally blackholed traffic going to :> a new Internet Exchange. When we added the new vlans and new peers, the :>

Re: bgpd: fix adding a new interface and network inet connected

2016-03-21 Thread Peter Hessler
On 2016 Mar 21 (Mon) at 16:22:53 +0100 (+0100), Claudio Jeker wrote: :On Mon, Mar 21, 2016 at 03:54:38PM +0100, Peter Hessler wrote: :> We ran into a situation where we accidentally blackholed traffic going to :> a new Internet Exchange. When we added the new vlans and new peers, the :>

Re: route(4) diff

2016-03-22 Thread Peter Hessler
OK On 2016 Mar 22 (Tue) at 10:47:53 +0100 (+0100), Sebastian Benoit wrote: :add missing RTF_CONNECTED. :remove ESIS (End System to Intermediate System Protocol), ann NDP in :comment. :add information about RTF_FMASK. : :ok? : :diff --git share/man/man4/route.4 share/man/man4/route.4 :index 7c1402

bgpd: dispatch_rtmsg_addr[change] mpath route not found

2016-03-31 Thread Peter Hessler
We see occasional bgpd deaths during boot. This is apparently caused by a race with ospfd starting up. The underlying problem is we are reciving a CHANGE route message for an MPATH path, where the gateway doesn't match the route message. In our case, the prefix is assigned to a Connected (and Ba

Re: bgpd: dispatch_rtmsg_addr[change] mpath route not found

2016-04-05 Thread Peter Hessler
On 2016 Apr 04 (Mon) at 18:07:52 +0100 (+0100), Stuart Henderson wrote: :On 2016/03/31 12:40, Peter Hessler wrote: :> We see occasional bgpd deaths during boot. This is apparently caused by :> a race with ospfd starting up. :> :> The underlying problem is we are reciving a CHANGE r

Re: ifconfig(8): Do not print MPSAFE

2016-05-07 Thread Peter Hessler
SINCE THIS IS UNDER HEAVY DEVELOPMENT: as a user, I want to know if my interface is marked as MP safe or not. I don't care if this is done in dmesg, or in ifconfig. once it stabilizes, I'm happy for the notice to go away. On 2016 May 07 (Sat) at 16:56:02 +0200 (+0200), Martin Pieuchot wrote: :I

Re: [patch/openbgpd] make man example works

2017-05-26 Thread Peter Hessler
looks good to me, OK On 2017 May 21 (Sun) at 19:36:36 +0200 (+0200), Denis Fondras wrote: :Hi, : :bgpd.conf manual has an example with : : :good="{ 192.168.0.0/16, 172.16.0.0/12, 10.0.0.0/8 }" :bad="{ 224.0.0.0/4 prefixlen >= 4, 240.0.0.0/4 prefixlen >= 4 }" :ugly="{ 127.0.0.1/8, 169.254.0.0/16 }

Re: OpenBGPd: expand rib list (updated for r1.295)

2017-05-26 Thread Peter Hessler
Also looks good to me, OK On 2017 Jan 20 (Fri) at 21:19:22 +0100 (+0100), Denis Fondras wrote: :Hello, : :Here is a patch to expand RIB names in rules. When playing with multi-RIBs, it :allows to simplify ruleset. : : Ex : :# cat /etc/bgpd.conf :[...] :peer_ribs = "{ m1, m2, m3 }" :deny rib m2 f

[bgpd] RFC 7607 Codification of AS 0 Processing

2017-05-26 Thread Peter Hessler
Apropos of "I found it", I implemented support for RFC 7607. It's a super short RFC, but basically it forbids use of AS 0 anywhere. OK? Index: parse.y === RCS file: /cvs/openbsd/src/usr.sbin/bgpd/parse.y,v retrieving revision 1.300

Re: [bgpd] RFC 7607 Codification of AS 0 Processing

2017-05-26 Thread Peter Hessler
On 2017 May 26 (Fri) at 20:01:00 +0200 (+0200), Peter Hessler wrote: :Apropos of "I found it", I implemented support for RFC 7607. It's a :super short RFC, but basically it forbids use of AS 0 anywhere. : :OK? : : Fixed some denglish in an error message, mention the RFC in th

Re: [bgpd] RFC 7607 Codification of AS 0 Processing

2017-05-26 Thread Peter Hessler
On 2017 May 26 (Fri) at 22:15:37 +0200 (+0200), Sebastian Benoit wrote: :diff is ok, but please consider this: : :i think we should limit the list to the features we support so :that users can check if a certain something should work or not. : :this is not a feature, this is a protocol clarificatio

Re: bgpd: local-as

2017-05-27 Thread Peter Hessler
On 2016 Sep 26 (Mon) at 20:09:13 +0200 (+0200), Peter Hessler wrote: :We already have a local AS saved per peer. Let's use it. This is very :useful when one needs to change their local AS. : :" :neighbor 192.0.2.1 { : remote-as 65530 : local-as 131000 :} :" : :OK? : U

Re: bgpd: local-as

2017-05-27 Thread Peter Hessler
On 2017 May 27 (Sat) at 11:05:30 +0200 (+0200), Peter Hessler wrote: :On 2016 Sep 26 (Mon) at 20:09:13 +0200 (+0200), Peter Hessler wrote: ::We already have a local AS saved per peer. Let's use it. This is very ::useful when one needs to change their local AS. :: ::" ::neighbor

[bgpd] local-as for use in filters

2017-05-27 Thread Peter Hessler
Right now, we have 'neighbor-as' that can be used as magic syntax sugar for filter rules. I want to have magic syntax sugar for 'local-as', which expands to our ASN. It already plays nicely with the local-as diff I sent, and can be committed in either order. match in from $neighbor set commu

[bgpd] enforce local-as no

2017-05-27 Thread Peter Hessler
Allow us to receive our own AS paths from a neighbor. Like several of the related diffs, this also invites dragons and grues into your network. Probably needs the most love in the man page, as usual ;). OK? Index: bgpd.conf.5 ===

Re: Throttle bgpd's RDE if the client is slow

2017-05-27 Thread Peter Hessler
This improves our AMS-IX border router (200 configured sessions, plus Route Servers) starting performance. >From 45 minutes to bring everyone up, to 3 minutes, and bgpctl stays acceptably responsive during the thundering herd. Memory pressure is also far more relaxed. OK On 2017 May 26 (Fri) a

Re: bgpd on other rdomains

2017-05-28 Thread Peter Hessler
looks fine to me, OK On 2017 May 28 (Sun) at 19:12:34 +0200 (+0200), Sebastian Benoit wrote: :Hi, : :testing hennigs diff i found having to specify the socket on the command :line annoying: : : bgpctl -s /var/run/rdomain123.bgpd.sock sh rib : :srly? : :I figure when you are debuging things in rd

Re: tcpdump: enable some more bgp info

2017-05-30 Thread Peter Hessler
On 2017 May 30 (Tue) at 10:21:17 +0200 (+0200), Michal Mazurek wrote: :On 12:15:06, 29.05.17, Job Snijders wrote: :> perhaps add a comment like /* RFC 6608 */ above the below: : :Right, it will make it more consistent. : :> > +static const char *bgpnotify_minor_fsm[] = { :> > + NULL, "In OpenSent

Re: [PATCH 1/3] openbgpd: Allow localpref of zero

2017-06-25 Thread Peter Hessler
OK On 2017 Jun 23 (Fri) at 16:01:16 +0200 (+0200), Job Snijders wrote: :Dear team, : :The lowest valid BGP LOCAL_PREF is 0, allowing bgpd to set 0 too will :accomodate interopability. : :Kind regards, : :Job : :--- a/usr.sbin/bgpd/parse.y :+++ b/usr.sbin/bgpd/parse.y :@@ -1988,7 +1988,7 @@ filter_

Re: [PATCH 3/3] openbgpd: Add well-known community GRACEFUL_SHUTDOWN

2017-06-25 Thread Peter Hessler
OK On 2017 Jun 23 (Fri) at 16:02:13 +0200 (+0200), Job Snijders wrote: :Dear team, : :This patch adds support for the "graceful shutdown" well-known :community as described in draft-ietf-grow-bgp-gshut. : :An example implementation would be to add the following to your :bgpd.conf: : :match fro

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

2017-06-25 Thread Peter Hessler
On 2017 Jun 23 (Fri) at 16:01:58 +0200 (+0200), Job Snijders wrote: :Dear team, : :This patch makes 'unknown' well-known communities more of a first-class :citizen. : :A powerful property of well-known communities is that (often) operators :can implement the feature associated with a given well-kno

Re: show ASN details in bgplg(8)

2017-08-09 Thread Peter Hessler
Sorry for the delay. I just committed this, thanks! On 2017 Jul 19 (Wed) at 21:40:09 +0200 (+0200), Denis Fondras wrote: :Hi, : :I can be useful to display details about an ASN from the looking-glass. : :rt-grav-01.liopen.net> show ip bgp detail as 199881 : :BGP routing table entry for 2a00:6060

include pinebook firmware in the install media

2017-08-27 Thread Peter Hessler
(this depends on the patch to u-boot I just sent to ports@) If we should manage to boot on a Pinebook machine, we should install the correct firmware for it. OK? Index: distrib/arm64/ramdisk/Makefile === RCS file: /cvs/openbsd/src/d

[phess...@openbsd.org: add pinebook support to u-boot]

2017-08-27 Thread Peter Hessler
- Forwarded message from Peter Hessler - taken from Icenowy Zheng's repository, commit bd656cab0c3e0669e977641c15095f32d7b0731f This gives us basic support for the Pine64 Pinebook OK? $ sysctl hw hw.machine=arm64 hw.model=ARM Cortex-A53 r0p4 hw.ncpu=1 hw.byteorder=1234 hw.pagesize

Re: [phess...@openbsd.org: add pinebook support to u-boot]

2017-08-27 Thread Peter Hessler
On 2017 Aug 27 (Sun) at 22:30:37 +0200 (+0200), Mark Kettenis wrote: :> Date: Sun, 27 Aug 2017 22:15:46 +0200 :> From: Peter Hessler :> :> This gives us basic support for the Pine64 Pinebook :> :> OK? :> :> $ sysctl hw :> hw.machine=arm64 :> hw.model=AR

Re: include pinebook firmware in the install media

2017-08-31 Thread Peter Hessler
On 2017 Aug 27 (Sun) at 21:54:07 +0200 (+0200), Peter Hessler wrote: :(this depends on the patch to u-boot I just sent to ports@) : :If we should manage to boot on a Pinebook machine, we should install the :correct firmware for it. : :OK? : Updated to a now working copy! This grew bsd.rd a bit

Re: [phess...@openbsd.org: add pinebook support to u-boot]

2017-08-31 Thread Peter Hessler
On 2017 Aug 27 (Sun) at 22:15:46 +0200 (+0200), Peter Hessler wrote: :- Forwarded message from Peter Hessler - :taken from Icenowy Zheng's repository, :commit bd656cab0c3e0669e977641c15095f32d7b0731f : :This gives us basic support for the Pine64 Pinebook : :OK? : :$ sysctl hw :hw.ma

Re: [phess...@openbsd.org: add pinebook support to u-boot]

2017-08-31 Thread Peter Hessler
On 2017 Aug 31 (Thu) at 10:41:41 +0200 (+0200), Peter Hessler wrote: :On 2017 Aug 27 (Sun) at 22:15:46 +0200 (+0200), Peter Hessler wrote: ::- Forwarded message from Peter Hessler - ::taken from Icenowy Zheng's repository, ::commit bd656cab0c3e0669e977641c15095f32d7b0731f :: ::This

Re: [phess...@openbsd.org: add pinebook support to u-boot]

2017-08-31 Thread Peter Hessler
On 2017 Aug 31 (Thu) at 19:16:57 +1000 (+1000), Jonathan Gray wrote: :On Thu, Aug 31, 2017 at 10:59:20AM +0200, Peter Hessler wrote: :> On 2017 Aug 31 (Thu) at 10:41:41 +0200 (+0200), Peter Hessler wrote: :> :On 2017 Aug 27 (Sun) at 22:15:46 +0200 (+0200), Peter Hessler wrote: :> ::-

teach wsconsctl about efifb

2017-09-02 Thread Peter Hessler
on a laptop with a simplefb[1] display, wsconsctl shows display.type=unknown_71. With the below patch, it shows display.type=efifb I checked the other values, and it was the only missing display type. [1] simplefb claims to be WSDISPLAY_TYPE_EFIFB OK? Index: sbin/wsconsctl/util.c ==

Re: bgpd: filter as path with operators

2016-05-31 Thread Peter Hessler
On 2016 May 31 (Tue) at 08:10:22 +0200 (+0200), Claudio Jeker wrote: :On Mon, May 30, 2016 at 10:43:49PM +0200, Sebastian Benoit wrote: :> /Benno :> :> diff --git etc/examples/bgpd.conf etc/examples/bgpd.conf :> index 8ffa8a8..02a31f9 100644 :> --- etc/examples/bgpd.conf :> +++ etc/examples/bgpd.c

Re: bgpd: print AS range

2016-06-04 Thread Peter Hessler
This didn't quite work, as log_as will override itself when used twice in the same printf. I also fixed some knf bits. On 2016 Jun 04 (Sat) at 22:13:07 +0200 (+0200), Denis Fondras wrote: :With the support of AS range filtering, we need to print the configuration :accordingly. : :Before : :# bgpd

Re: bgpd logging nexthop valid

2016-06-20 Thread Peter Hessler
On 2016 Jun 19 (Sun) at 17:39:53 +0200 (+0200), Sebastian Benoit wrote: :i would like to make bgpd a bit more quiet. : :This type of message : : bgpd[59424]: nexthop 1.2.3.4 now valid: via 192.168.0.1 : :happens quite often depending on your upstreams. This makes it a debug :message only. : :ok? :

bgpd.conf: make it clear what "announce IPv6 unicast" does

2016-08-16 Thread Peter Hessler
The man page is a bit confusing for how we can control which address families we support during the capabilities negotiation. Slightly reorganize the man page to be more clear, and explicitly state what the default is. OK? Index: bgpd.conf.5 =

pid for RTM_ADD

2016-08-17 Thread Peter Hessler
It sure would be nice if we could see the PID of the process that added routes. Heck, route(8) even tries to print them already. Add the fields to the appropriate struct, and while here, document which fields are in sync. (requested by krw@) OK? Index: net/if.h ===

Re: pid for RTM_ADD

2016-08-17 Thread Peter Hessler
On 2016 Aug 17 (Wed) at 10:39:51 +0100 (+0100), Stuart Henderson wrote: :On 2016/08/17 10:11, Peter Hessler wrote: :> It sure would be nice if we could see the PID of the process that added :> routes. Heck, route(8) even tries to print them already. :> :> Add the fields to the approp

Re: cwm(1): Enable numpad Enter on menus

2016-08-28 Thread Peter Hessler
On 2016 Aug 27 (Sat) at 23:53:14 -0300 (-0300), Henrique N. Lengler wrote: :> Hi, :> :> This is a tiny patch to enable the use of numpad Enter key on cwm menus. :> :> Regards, :> :> Henrique N. Lengler : :No intention to apply this? : :Numpad enter key is is recognized by every program on openbs

Re: ifconfig baudrate

2016-08-31 Thread Peter Hessler
On 2016 Aug 31 (Wed) at 17:04:38 +0200 (+0200), Stefan Sperling wrote: :This makes ifconfig display baudrates defined in ifmedia.h tables. : :Before (prints media subtype): : :$ ifconfig iwn0 | grep media: :media: IEEE802.11 autoselect (OFDM6 mode 11a) :$ ifconfig em0 | grep media: :

teach BFD how to send route messages

2016-09-14 Thread Peter Hessler
This is a work-in-progress diff that I would like to commit. I can print a few things, but there is a problem when trying to bring in more fields. Printing is also ugly, but I can fix that in-tree. While here, I print the descr's as ints, the same way Juniper does it. I also had to add RTM_INVAL

let openbgpd announce rtlabels

2016-09-14 Thread Peter Hessler
It is quite common to want to do a cross-protocol readvertisement from IGP->EGP. We can add rtlabels in bgpd and ospfd, but only advertise in ospfd. This diff lets bgpd announce routes based on rtlabels. The existing "cannot announce routes that point to localhost" and "cannot announce defaults"

Re: teach BFD how to send route messages

2016-09-15 Thread Peter Hessler
On 2016 Sep 15 (Thu) at 13:28:10 +0200 (+0200), Martin Pieuchot wrote: :On 14/09/16(Wed) 15:50, Peter Hessler wrote: :> This is a work-in-progress diff that I would like to commit. I can print :> a few things, but there is a problem when trying to bring in more :> fields. Printing is

Re: teach BFD how to send route messages

2016-09-15 Thread Peter Hessler
On 2016 Sep 15 (Thu) at 16:18:46 +0200 (+0200), Henning Brauer wrote: :* Peter Hessler [2016-09-15 14:48]: :> On 2016 Sep 15 (Thu) at 13:28:10 +0200 (+0200), Martin Pieuchot wrote: :> :By the way 'softc' is generally for device drivers, you might prefer :> :something like bfd

  1   2   3   >