Fully enable Intel AlderLake HD Audio

2022-09-07 Thread Neel Chauhan
Index: dev/pci/azalia.c === RCS file: /cvs/src/sys/dev/pci/azalia.c,v retrieving revision 1.275 diff -u -p -u -p -r1.275 azalia.c --- dev/pci/azalia.c24 Aug 2022 11:21:12 - 1.275 +++ dev/pci/azalia.c7 Sep 2022 23:27:0

Recognize Realtek ALC245 Audio Codec

2022-09-07 Thread Neel Chauhan
Index: dev/pci/azalia_codec.c === RCS file: /cvs/src/sys/dev/pci/azalia_codec.c,v retrieving revision 1.188 diff -u -p -u -p -r1.188 azalia_codec.c --- dev/pci/azalia_codec.c 3 Aug 2022 05:54:50 - 1.188 +++ dev/pci/azal

Re: Fully enable Intel AlderLake HD Audio

2022-09-07 Thread Neel Chauhan
22 at 04:35:32PM -0700, Neel Chauhan wrote: Index: dev/pci/azalia.c === RCS file: /cvs/src/sys/dev/pci/azalia.c,v retrieving revision 1.275 diff -u -p -u -p -r1.275 azalia.c --- dev/pci/azalia.c24 Aug 2022 11:21:12 -

Re: Fully enable Intel AlderLake HD Audio

2022-09-07 Thread Neel Chauhan
o you have a machine with any of the added ids? > > The match table is added to when we find machines with an > unexpected subclass. > > On Wed, Sep 07, 2022 at 04:35:32PM -0700, Neel Chauhan wrote: > > Index: dev/pci/azalia.c > > ===

sysctl: Fixing "second level name in XX. is invalid" on trailing period

2023-08-29 Thread Neel Chauhan
Hi, I don't know if this is a big issue for you, but when doing a `sysctl` call with a trailing period ("."), like `sysctl kern.`, I get an error like this: sysctl: second level name in kern. is invalid On other systems, if I do `sysctl XX.`, I get all the entries inside XX. We should fix it

Re: sysctl: Fixing "second level name in XX. is invalid" on trailing period

2023-08-29 Thread Neel Chauhan
On 2023-08-29 14:23, Theo Buehler wrote: + if (string[strlen(string) - 1] == '.') + buf[strlen(string) - 1] = '\0'; Careful with out-of-bounds accesses. What if string is "" ? Probably easiest to do "len = strlen(string);" and if (len > 0 && ...). Good catch! Does this lo

Removing extra space in "sysctl: top level name in . is invalid"

2023-08-29 Thread Neel Chauhan
Hi, I have noticed a bug. When running "sysctl ." or "sysctl kern." without my other patch, I get an extra space between "name" and "in": sysctl: top level name in . is invalid It should be: sysctl: top level name in . is invalid I also have a patch. What this patch does is if the top

Re: Removing extra space in "sysctl: top level name in . is invalid"

2023-08-29 Thread Neel Chauhan
On 2023-08-29 17:21, Ingo Schwarze wrote: Hi Neel, Neel Chauhan wrote on Tue, Aug 29, 2023 at 02:48:54PM -0700: I have noticed a bug. When running "sysctl ." or "sysctl kern." without my other patch, I get an extra space between "name" and "in":